diff options
author | Maurício Meneghini Fauth <mauricio@fauth.dev> | 2022-06-30 08:01:21 +0300 |
---|---|---|
committer | Maurício Meneghini Fauth <mauricio@fauth.dev> | 2022-06-30 08:01:21 +0300 |
commit | ef299ea809aeaa83c3bef443e271cdf29005b1c9 (patch) | |
tree | 2e281335b3bb8f8b3879a53ec011293dd5131d3e | |
parent | f7379a6a2b1d67bbe1b95e381ab68e6e67e2a616 (diff) |
Extract side effects from page_settings.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
-rw-r--r-- | js/src/main.js | 3 | ||||
-rw-r--r-- | js/src/page_settings.js | 10 | ||||
-rw-r--r-- | libraries/classes/Header.php | 2 |
3 files changed, 10 insertions, 5 deletions
diff --git a/js/src/main.js b/js/src/main.js index 3779902868..c199a67fc7 100644 --- a/js/src/main.js +++ b/js/src/main.js @@ -35,3 +35,6 @@ window.AJAX.registerTeardown('indexes.js', Indexes.off()); window.AJAX.registerOnload('indexes.js', Indexes.on()); $(() => Functions.checkNumberOfFields()); + +window.AJAX.registerTeardown('page_settings.js', window.PageSettings.off()); +window.AJAX.registerOnload('page_settings.js', window.PageSettings.on()); diff --git a/js/src/page_settings.js b/js/src/page_settings.js index d65eb2eb4e..0b6a0239b1 100644 --- a/js/src/page_settings.js +++ b/js/src/page_settings.js @@ -33,16 +33,18 @@ function showNaviSettings () { showSettings('#pma_navigation_settings'); } -window.AJAX.registerTeardown('page_settings.js', function () { +window.PageSettings = {}; + +window.PageSettings.off = () => function () { $('#page_settings_icon').css('display', 'none'); $('#page_settings_icon').off('click'); $('#pma_navigation_settings_icon').off('click'); -}); +}; -window.AJAX.registerOnload('page_settings.js', function () { +window.PageSettings.on = () => function () { if ($('#page_settings_modal').length) { $('#page_settings_icon').css('display', 'inline'); $('#page_settings_icon').on('click', showPageSettings); } $('#pma_navigation_settings_icon').on('click', showNaviSettings); -}); +}; diff --git a/libraries/classes/Header.php b/libraries/classes/Header.php index 6c333cfbba..327b615a59 100644 --- a/libraries/classes/Header.php +++ b/libraries/classes/Header.php @@ -148,8 +148,8 @@ class Header $this->scripts->addFile('navigation.js'); $this->scripts->addFile('indexes.js'); $this->scripts->addFile('common.js'); - $this->scripts->addFile('main.js'); $this->scripts->addFile('page_settings.js'); + $this->scripts->addFile('main.js'); $this->scripts->addCode($this->getJsParamsCode()); } |