diff options
| author | Maurício Meneghini Fauth <mauricio@fauth.dev> | 2022-10-08 03:38:17 +0300 |
|---|---|---|
| committer | Maurício Meneghini Fauth <mauricio@fauth.dev> | 2022-10-08 03:38:17 +0300 |
| commit | 5e137ac0fcd432940ac988605661855a14de8695 (patch) | |
| tree | 4bbe7b4c4f658b2b00f6e94ea0a233c3f8363db1 /psalm-baseline.xml | |
| parent | 222ffa1e1a8ca13c5006b3c8659632137c51c2fd (diff) | |
Update Psalm/PHPStan baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Diffstat (limited to 'psalm-baseline.xml')
| -rw-r--r-- | psalm-baseline.xml | 3430 |
1 files changed, 2041 insertions, 1389 deletions
diff --git a/psalm-baseline.xml b/psalm-baseline.xml index 874757e842..80d5f58cda 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<files psalm-version="4.27.0@faf106e717c37b8c81721845dba9de3d8deed8ff"> +<files psalm-version="4.28.0@52e96bea381e6cb07a672aefec791a5817694a26"> <file src="index.php"> <InvalidGlobal occurrences="1"> <code>global $route, $containerBuilder, $request;</code> @@ -107,14 +107,12 @@ </RedundantCastGivenDocblockType> </file> <file src="libraries/classes/BrowseForeigners.php"> - <MixedArgument occurrences="7"> - <code>$_POST['foreign_filter']</code> + <MixedArgument occurrences="5"> <code>$descriptions[$indexByDescription]</code> <code>$descriptions[$indexByKeyname]</code> <code>$foreignData['the_total'] / $this->maxRows</code> <code>$horizontalCount</code> <code>$indexByDescription</code> - <code>$pos / $this->maxRows</code> </MixedArgument> <MixedArrayAccess occurrences="2"> <code>$relrow[$foreignData['foreign_display']]</code> @@ -124,21 +122,27 @@ <code>$relrow[$foreignData['foreign_display']]</code> <code>$relrow[$foreignData['foreign_field']]</code> </MixedArrayOffset> - <MixedAssignment occurrences="7"> + <MixedAssignment occurrences="5"> <code>$descriptions[]</code> <code>$keys[]</code> <code>$leftKeyname</code> - <code>$pos</code> - <code>$pos</code> <code>$relrow</code> <code>$rightKeyname</code> </MixedAssignment> - <MixedOperand occurrences="4"> + <MixedOperand occurrences="2"> <code>$foreignData['the_total']</code> <code>$html</code> - <code>$pos</code> - <code>$pos</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['foreign_filter']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['rownumber']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="2"> + <code>$pos</code> + <code>$this->maxRows</code> + </PossiblyInvalidOperand> <RedundantCast occurrences="4"> <code>(bool) $cfg['ShowAll']</code> <code>(int) $cfg['LimitChars']</code> @@ -267,13 +271,9 @@ </NonInvariantDocblockPropertyType> </file> <file src="libraries/classes/Common.php"> - <MixedArgument occurrences="9"> - <code>$_REQUEST['back']</code> - <code>$_REQUEST['goto']</code> + <MixedArgument occurrences="5"> <code>$_SESSION[' PMA_token ']</code> - <code>$back</code> <code>$cfg['Server']['user']</code> - <code>$goto</code> <code>$sqlDelimiter</code> <code>$sql_query</code> <code>$urlParams</code> @@ -286,15 +286,24 @@ <MixedArrayAssignment occurrences="1"> <code>$urlParams['goto']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="7"> - <code>$back</code> + <MixedAssignment occurrences="4"> <code>$controlLink</code> - <code>$goto</code> <code>$sqlDelimiter</code> <code>$sql_query</code> - <code>$urlParams['goto']</code> <code>$userLink</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="2"> + <code>$_REQUEST['back']</code> + <code>$_REQUEST['goto']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_REQUEST['back']</code> + <code>$_REQUEST['goto']</code> + </PossiblyInvalidCast> + <RedundantCast occurrences="2"> + <code>(string) $_POST['token']</code> + <code>(string) $_POST['token']</code> + </RedundantCast> </file> <file src="libraries/classes/Config.php"> <InvalidArgument occurrences="1"> @@ -303,7 +312,7 @@ <InvalidArrayOffset occurrences="1"> <code>$cfg['Server']['hide_connection_errors']</code> </InvalidArrayOffset> - <MixedArgument occurrences="16"> + <MixedArgument occurrences="15"> <code>$collation_connection</code> <code>$config_data</code> <code>$config_data</code> @@ -312,7 +321,6 @@ <code>$each_server</code> <code>$gd_nfo['GD Version']</code> <code>$path</code> - <code>$request</code> <code>$server['verbose']</code> <code>$server_index</code> <code>$this->settings['Servers']</code> @@ -344,7 +352,7 @@ <code>$this->settings['Servers'][$server]</code> <code>$this->settings['Servers'][$this->settings['ServerDefault']]</code> </MixedArrayOffset> - <MixedAssignment occurrences="26"> + <MixedAssignment occurrences="25"> <code>$cfg['LoginCookieValidity']</code> <code>$collation_connection</code> <code>$config_data</code> @@ -358,7 +366,6 @@ <code>$prefs_type</code> <code>$prefs_type</code> <code>$request</code> - <code>$request</code> <code>$server</code> <code>$server</code> <code>$server[$item]</code> @@ -384,12 +391,21 @@ <code>$default_value</code> <code>$request</code> </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="1"> + <code>$_COOKIE[$this->getCookieName($cookieName)]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="1"> + <code>$request</code> + </PossiblyInvalidCast> <PossiblyNullArgument occurrences="1"> <code>$oldErrorReporting</code> </PossiblyNullArgument> <RedundantConditionGivenDocblockType occurrences="1"> <code>$tmanager->theme !== null</code> </RedundantConditionGivenDocblockType> + <RiskyCast occurrences="1"> + <code>$server['port']</code> + </RiskyCast> </file> <file src="libraries/classes/Config/ConfigFile.php"> <InvalidIterator occurrences="1"> @@ -460,6 +476,15 @@ <code>$verbose</code> <code>empty($host) ? 'localhost' : $host</code> </MixedReturnStatement> + <PossiblyInvalidArrayOffset occurrences="7"> + <code>$_SESSION[$this->id]</code> + <code>$_SESSION[$this->id]</code> + <code>$_SESSION[$this->id]</code> + <code>$_SESSION[$this->id]</code> + <code>$_SESSION[$this->id]</code> + <code>$_SESSION[$this->id]</code> + <code>$_SESSION[$this->id]</code> + </PossiblyInvalidArrayOffset> <PossiblyNullArgument occurrences="1"> <code>$this->baseCfg</code> </PossiblyNullArgument> @@ -522,9 +547,7 @@ </UnevaluatedCode> </file> <file src="libraries/classes/Config/FormDisplay.php"> - <MixedArgument occurrences="22"> - <code>$_POST[$key]</code> - <code>$_POST[$key]</code> + <MixedArgument occurrences="20"> <code>$canonicalPath</code> <code>$errorList</code> <code>$form->fields[$field]</code> @@ -559,8 +582,7 @@ <code>$opts['values']['iconv']</code> <code>$opts['values']['recode']</code> </MixedArrayAccess> - <MixedArrayAssignment occurrences="3"> - <code>$_POST[$key][]</code> + <MixedArrayAssignment occurrences="2"> <code>$opts['values']['iconv']</code> <code>$opts['values']['recode']</code> </MixedArrayAssignment> @@ -584,7 +606,7 @@ <code>$values[$path]</code> <code>$values[$systemPath]</code> </MixedArrayOffset> - <MixedAssignment occurrences="29"> + <MixedAssignment occurrences="28"> <code>$canonicalPath</code> <code>$errorList</code> <code>$errorList</code> @@ -612,7 +634,6 @@ <code>$valueDefault</code> <code>$valueDefaultJs</code> <code>$values[$path]</code> - <code>$values[$systemPath]</code> <code>$workPath</code> </MixedAssignment> <MixedOperand occurrences="6"> @@ -632,7 +653,8 @@ <PossiblyFalseIterator occurrences="1"> <code>$values[$path]</code> </PossiblyFalseIterator> - <PossiblyInvalidArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="3"> + <code>$_POST[$key]</code> <code>$valueDefault</code> <code>$valueDefaultJs</code> </PossiblyInvalidArgument> @@ -1003,9 +1025,12 @@ </MixedArgument> </file> <file src="libraries/classes/Controllers/CollationConnectionController.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$_POST['collation_connection']</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['collation_connection']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Config/SetConfigController.php"> <MixedArgument occurrences="1"> @@ -1013,9 +1038,12 @@ </MixedArgument> </file> <file src="libraries/classes/Controllers/Database/CentralColumns/PopulateColumnsController.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$_POST['selectedTable']</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['selectedTable']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/CentralColumnsController.php"> <MixedArgument occurrences="24"> @@ -1083,7 +1111,36 @@ </MixedOperand> </file> <file src="libraries/classes/Controllers/Database/DesignerController.php"> - <MixedArgument occurrences="45"> + <InvalidScalarArgument occurrences="2"> + <code>$_POST['selected_page']</code> + <code>$_POST['selected_page']</code> + </InvalidScalarArgument> + <MixedArgument occurrences="7"> + <code>$db</code> + <code>$db</code> + <code>$html</code> + <code>$position['dbName']</code> + <code>$position['tableName']</code> + <code>$sub_part ?? ''</code> + <code>$success</code> + </MixedArgument> + <MixedArgumentTypeCoercion occurrences="1"> + <code>['db' => $db]</code> + </MixedArgumentTypeCoercion> + <MixedArrayAccess occurrences="4"> + <code>$position['dbName']</code> + <code>$position['dbName']</code> + <code>$position['tableName']</code> + <code>$position['tableName']</code> + </MixedArrayAccess> + <MixedAssignment occurrences="1"> + <code>$position</code> + </MixedAssignment> + <MixedOperand occurrences="2"> + <code>$position['dbName']</code> + <code>$position['tableName']</code> + </MixedOperand> + <PossiblyInvalidArgument occurrences="36"> <code>$_GET['db']</code> <code>$_GET['db']</code> <code>$_GET['db']</code> @@ -1110,58 +1167,54 @@ <code>$_POST['index']</code> <code>$_POST['on_delete']</code> <code>$_POST['on_update']</code> - <code>$_POST['selected_page']</code> - <code>$_POST['selected_page']</code> <code>$_POST['selected_value']</code> <code>$_POST['selected_value']</code> <code>$_POST['selected_value']</code> <code>$_POST['table']</code> <code>$_POST['table']</code> <code>$_POST['value']</code> - <code>$db</code> - <code>$db</code> <code>$display_page</code> <code>$display_page</code> <code>$display_page</code> - <code>$html</code> <code>$page</code> - <code>$position['dbName']</code> - <code>$position['tableName']</code> - <code>$sub_part ?? ''</code> - <code>$success</code> - </MixedArgument> - <MixedArgumentTypeCoercion occurrences="1"> - <code>['db' => $db]</code> - </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="4"> - <code>$position['dbName']</code> - <code>$position['dbName']</code> - <code>$position['tableName']</code> - <code>$position['tableName']</code> - </MixedArrayAccess> - <MixedAssignment occurrences="4"> - <code>$display_page</code> - <code>$page</code> - <code>$params['db']</code> - <code>$position</code> - </MixedAssignment> - <MixedOperand occurrences="2"> - <code>$position['dbName']</code> - <code>$position['tableName']</code> - </MixedOperand> - <PossiblyNullArgument occurrences="5"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="29"> <code>$_GET['db']</code> - <code>$display_page</code> - <code>$display_page</code> - <code>$page</code> + <code>$_GET['db']</code> + <code>$_GET['db']</code> + <code>$_POST['DB1']</code> + <code>$_POST['DB2']</code> + <code>$_POST['F1']</code> + <code>$_POST['F1']</code> + <code>$_POST['F2']</code> + <code>$_POST['F2']</code> + <code>$_POST['T1']</code> + <code>$_POST['T1']</code> + <code>$_POST['T2']</code> + <code>$_POST['T2']</code> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + <code>$_POST['field']</code> + <code>$_POST['index']</code> + <code>$_POST['on_delete']</code> + <code>$_POST['on_update']</code> + <code>$_POST['selected_value']</code> + <code>$_POST['selected_value']</code> + <code>$_POST['table']</code> + <code>$_POST['value']</code> + </PossiblyInvalidCast> + <PossiblyNullArgument occurrences="1"> <code>$selected_page</code> </PossiblyNullArgument> <PossiblyNullIterator occurrences="1"> <code>$tab_pos</code> </PossiblyNullIterator> - <PossiblyUndefinedArrayOffset occurrences="1"> - <code>$_GET['db']</code> - </PossiblyUndefinedArrayOffset> </file> <file src="libraries/classes/Controllers/Database/EventsController.php"> <MixedArgument occurrences="4"> @@ -1201,10 +1254,9 @@ <MixedArrayAssignment occurrences="1"> <code>$urlParams['goto']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="3"> + <MixedAssignment occurrences="2"> <code>$GLOBALS['single_table']</code> <code>$each_table</code> - <code>$table_select</code> </MixedAssignment> </file> <file src="libraries/classes/Controllers/Database/ImportController.php"> @@ -1222,38 +1274,45 @@ <MixedArrayOffset occurrences="2"> <code>$_SESSION[$SESSION_KEY]</code> </MixedArrayOffset> - <MixedAssignment occurrences="3"> + <MixedAssignment occurrences="1"> <code>$idKey</code> - <code>$localImportFile</code> - <code>$timeoutPassed</code> </MixedAssignment> <MixedMethodCall occurrences="1"> <code>$_SESSION[$SESSION_KEY]['handler']::getIdKey()</code> </MixedMethodCall> + <PossiblyInvalidCast occurrences="1"> + <code>$_GET['format']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/MultiTableQuery/QueryController.php"> - <MixedArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="2"> <code>$params['db']</code> <code>$params['sql_query']</code> - </MixedArgument> - <PossiblyNullArgument occurrences="1"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> <code>$params['db']</code> - </PossiblyNullArgument> + <code>$params['sql_query']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/MultiTableQuery/TablesController.php"> - <MixedArgument occurrences="2"> - <code>$params['db']</code> + <MixedArgument occurrences="1"> <code>$table</code> </MixedArgument> <MixedAssignment occurrences="1"> <code>$table</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$params['db']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$params['db']</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$params['tables']</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Database/Operations/CollationController.php"> - <MixedArgument occurrences="7"> - <code>$_POST['db_collation']</code> - <code>$_POST['db_collation'] ?? ''</code> - <code>$_POST['db_collation'] ?? ''</code> + <MixedArgument occurrences="4"> <code>$db</code> <code>$db</code> <code>$db</code> @@ -1266,39 +1325,61 @@ <code>$data</code> <code>$tableName</code> </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="3"> <code>$_POST['db_collation']</code> - </PossiblyNullArgument> + <code>$_POST['db_collation'] ?? ''</code> + <code>$_POST['db_collation'] ?? ''</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$_POST['db_collation']</code> + <code>$_POST['db_collation'] ?? ''</code> + <code>$_POST['db_collation'] ?? ''</code> + </PossiblyInvalidCast> <UnusedForeachValue occurrences="1"> <code>$data</code> </UnusedForeachValue> </file> <file src="libraries/classes/Controllers/Database/OperationsController.php"> - <MixedArgument occurrences="10"> - <code>$_POST['comment']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$db</code> - <code>$db</code> - <code>$db</code> + <InvalidArgument occurrences="2"> + <code>['db' => $db]</code> + <code>['db' => $db]</code> + </InvalidArgument> + <MixedArgument occurrences="2"> <code>$db</code> <code>$message</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="1"> - <code>['db' => $db]</code> - </MixedArgumentTypeCoercion> <MixedArrayAssignment occurrences="1"> <code>$urlParams['goto']</code> </MixedArrayAssignment> <MixedArrayOffset occurrences="1"> <code>$cfg['Servers'][$server]</code> </MixedArrayOffset> - <MixedAssignment occurrences="2"> + <PossiblyInvalidArgument occurrences="10"> + <code>$_POST['comment']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> <code>$db</code> <code>$db</code> - </MixedAssignment> + <code>$db</code> + <code>$db</code> + <code>$db</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="9"> + <code>$_POST['comment']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + </PossiblyInvalidCast> + <PossiblyUndefinedArrayOffset occurrences="1"> + <code>$_POST['newname']</code> + </PossiblyUndefinedArrayOffset> <RedundantCondition occurrences="10"> <code>! $_error</code> <code>! $_error</code> @@ -1313,10 +1394,10 @@ </RedundantCondition> </file> <file src="libraries/classes/Controllers/Database/QueryByExampleController.php"> - <MixedArgument occurrences="10"> - <code>$_POST['db']</code> + <InvalidArgument occurrences="1"> <code>$_POST['searchId']</code> - <code>$_POST['searchName']</code> + </InvalidArgument> + <MixedArgument occurrences="7"> <code>$db</code> <code>$db</code> <code>$db</code> @@ -1331,9 +1412,17 @@ <MixedArrayAssignment occurrences="1"> <code>$urlParams['goto']</code> </MixedArrayAssignment> + <PossiblyInvalidArgument occurrences="2"> + <code>$_POST['db']</code> + <code>$_POST['searchName']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST['db']</code> + <code>$_POST['searchName']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/RoutinesController.php"> - <MixedArgument occurrences="8"> + <MixedArgument occurrences="7"> <code>$db</code> <code>$db</code> <code>$db</code> @@ -1341,16 +1430,17 @@ <code>$item</code> <code>$sub_part ?? ''</code> <code>$table</code> - <code>$type</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="2"> <code>$urlParams</code> <code>['db' => $db]</code> </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$item</code> - <code>$type</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$type</code> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Database/SearchController.php"> <MixedArgument occurrences="3"> @@ -1366,7 +1456,8 @@ </MixedArrayAssignment> </file> <file src="libraries/classes/Controllers/Database/SqlAutoCompleteController.php"> - <MixedArgument occurrences="2"> + <MixedArgument occurrences="3"> + <code>$db</code> <code>$db</code> <code>$tableName</code> </MixedArgument> @@ -1374,90 +1465,93 @@ <code>$db</code> <code>$tableName</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="2"> + <code>$db</code> + <code>$db</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$db</code> + <code>$db</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/SqlController.php"> - <MixedArgument occurrences="2"> - <code>$_POST['delimiter']</code> + <MixedArgument occurrences="1"> <code>$db</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>['db' => $db]</code> </MixedArgumentTypeCoercion> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['delimiter']</code> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Database/SqlFormatController.php"> - <MixedArgument occurrences="1"> - <code>$query</code> - </MixedArgument> - <MixedAssignment occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$query</code> - </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$params['sql']</code> <code>$query</code> - </PossiblyNullArgument> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/Structure/AddPrefixController.php"> - <MixedAssignment occurrences="3"> + <MixedAssignment occurrences="2"> <code>$params['selected'][]</code> - <code>$selected</code> <code>$selectedValue</code> </MixedAssignment> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Database/Structure/AddPrefixTableController.php"> - <MixedArgument occurrences="3"> + <MixedArgument occurrences="1"> <code>$db</code> - <code>$selected</code> - <code>$selected[$i]</code> </MixedArgument> - <MixedArrayAccess occurrences="1"> - <code>$selected[$i]</code> - </MixedArrayAccess> - <MixedAssignment occurrences="1"> + <PossiblyInvalidArgument occurrences="2"> <code>$selected</code> - </MixedAssignment> - <MixedOperand occurrences="1"> + <code>$selected[$i]</code> + </PossiblyInvalidArgument> + <PossiblyInvalidOperand occurrences="2"> <code>$_POST['add_prefix']</code> - </MixedOperand> + <code>$selected[$i]</code> + </PossiblyInvalidOperand> </file> <file src="libraries/classes/Controllers/Database/Structure/CentralColumns/AddController.php"> - <MixedArgument occurrences="1"> - <code>$selected</code> - </MixedArgument> - <MixedAssignment occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$selected</code> - </MixedAssignment> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Database/Structure/CentralColumns/MakeConsistentController.php"> - <MixedArgument occurrences="2"> + <MixedArgument occurrences="1"> <code>$db</code> - <code>$selected</code> </MixedArgument> - <MixedAssignment occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$selected</code> - </MixedAssignment> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Database/Structure/CentralColumns/RemoveController.php"> - <MixedArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="2"> <code>$_POST['db']</code> <code>$selected</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$selected</code> - </MixedAssignment> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['db']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/Structure/ChangePrefixFormController.php"> - <MixedAssignment occurrences="4"> - <code>$selected</code> + <MixedAssignment occurrences="2"> <code>$selectedValue</code> - <code>$submitMult</code> <code>$urlParams['selected'][]</code> </MixedAssignment> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Database/Structure/CopyFormController.php"> - <MixedAssignment occurrences="6"> + <MixedAssignment occurrences="5"> <code>$databaseName</code> <code>$databasesList</code> <code>$key</code> - <code>$selected</code> <code>$selectedValue</code> <code>$urlParams['selected'][]</code> </MixedAssignment> @@ -1468,47 +1562,55 @@ <MixedPropertyFetch occurrences="1"> <code>$dblist->databases</code> </MixedPropertyFetch> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Database/Structure/CopyTableController.php"> - <MixedArgument occurrences="9"> - <code>$_POST['what']</code> + <MixedArgument occurrences="2"> <code>$db</code> <code>$db</code> + </MixedArgument> + <PossiblyInvalidArgument occurrences="8"> + <code>$_POST['what']</code> <code>$selected</code> <code>$selected[$i]</code> <code>$selected[$i]</code> <code>$selected[$i]</code> <code>$selected[$i]</code> <code>$targetDb</code> - </MixedArgument> - <MixedArrayAccess occurrences="1"> + <code>$targetDb</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="6"> + <code>$_POST['what']</code> + <code>$selected[$i]</code> + <code>$selected[$i]</code> + <code>$selected[$i]</code> <code>$selected[$i]</code> - </MixedArrayAccess> - <MixedAssignment occurrences="2"> - <code>$selected</code> <code>$targetDb</code> - </MixedAssignment> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/Structure/CopyTableWithPrefixController.php"> - <MixedArgument occurrences="5"> - <code>$current</code> - <code>$current</code> + <MixedArgument occurrences="2"> <code>$db</code> <code>$db</code> - <code>$selected</code> </MixedArgument> - <MixedArrayAccess occurrences="1"> - <code>$selected[$i]</code> - </MixedArrayAccess> - <MixedAssignment occurrences="4"> + <PossiblyInvalidArgument occurrences="3"> + <code>$current</code> <code>$current</code> - <code>$fromPrefix</code> <code>$selected</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$current</code> + <code>$current</code> + <code>$fromPrefix</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> <code>$toPrefix</code> - </MixedAssignment> - <MixedOperand occurrences="1"> + </PossiblyInvalidOperand> + <PossiblyNullOperand occurrences="1"> <code>$toPrefix</code> - </MixedOperand> + </PossiblyNullOperand> </file> <file src="libraries/classes/Controllers/Database/Structure/DropFormController.php"> <MixedArgument occurrences="3"> @@ -1516,65 +1618,66 @@ <code>$current</code> <code>$db</code> </MixedArgument> - <MixedAssignment occurrences="5"> + <MixedAssignment occurrences="4"> <code>$current</code> - <code>$selected</code> <code>$selectedValue</code> <code>$selectedValue</code> <code>$urlParams['selected'][]</code> </MixedAssignment> + <PossiblyInvalidIterator occurrences="2"> + <code>$selected</code> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Database/Structure/DropTableController.php"> - <MixedArgument occurrences="5"> - <code>$current</code> - <code>$current</code> + <MixedArgument occurrences="1"> <code>$db</code> - <code>$selected</code> - <code>$selected[$i]</code> </MixedArgument> - <MixedArrayAccess occurrences="3"> + <MixedArrayAccess occurrences="2"> <code>$_SESSION['tmpval']['table_limit_offset']</code> <code>$_SESSION['tmpval']['table_limit_offset_db']</code> - <code>$selected[$i]</code> </MixedArrayAccess> - <MixedAssignment occurrences="4"> - <code>$current</code> - <code>$multBtn</code> + <MixedAssignment occurrences="1"> <code>$reload</code> - <code>$selected</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="4"> + <code>$current</code> + <code>$current</code> + <code>$selected</code> + <code>$selected[$i]</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$selected[$i]</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/Structure/EmptyFormController.php"> <MixedArgument occurrences="1"> <code>$selectedValue</code> </MixedArgument> - <MixedAssignment occurrences="2"> - <code>$selected</code> + <MixedAssignment occurrences="1"> <code>$selectedValue</code> </MixedAssignment> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Database/Structure/EmptyTableController.php"> - <MixedArgument occurrences="6"> + <InvalidArgument occurrences="1"> <code>$_REQUEST['pos']</code> + </InvalidArgument> + <MixedArgument occurrences="3"> <code>$db</code> <code>$db</code> - <code>$selected</code> - <code>$selected[$i]</code> <code>$table</code> </MixedArgument> - <MixedArrayAccess occurrences="1"> - <code>$selected[$i]</code> - </MixedArrayAccess> - <MixedAssignment occurrences="2"> - <code>$multBtn</code> + <PossiblyInvalidArgument occurrences="2"> <code>$selected</code> - </MixedAssignment> + <code>$selected[$i]</code> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Database/Structure/FavoriteTableController.php"> - <MixedArgument occurrences="5"> - <code>$favoriteTable</code> + <MixedArgument occurrences="3"> <code>$favoriteTables</code> - <code>$parameters['favoriteTables']</code> <code>$value['db']</code> <code>$value['table']</code> </MixedArgument> @@ -1592,13 +1695,29 @@ <code>$_SESSION['tmpval']['favorites_synced']</code> <code>$favoriteTables[$user]</code> </MixedArrayAssignment> - <MixedAssignment occurrences="5"> - <code>$favoriteTable</code> + <MixedAssignment occurrences="4"> <code>$favoriteTables</code> <code>$favoriteTables</code> <code>$value</code> <code>$value</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="5"> + <code>$favoriteTable</code> + <code>$favoriteTable</code> + <code>$favoriteTable</code> + <code>$favoriteTable</code> + <code>$parameters['favoriteTables']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="5"> + <code>$favoriteTable</code> + <code>$favoriteTable</code> + <code>$favoriteTable</code> + <code>$favoriteTable</code> + <code>$parameters['favoriteTables']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> + <code>$favoriteTable</code> + </PossiblyInvalidOperand> </file> <file src="libraries/classes/Controllers/Database/Structure/RealRowCountController.php"> <MixedArgument occurrences="1"> @@ -1614,49 +1733,47 @@ <MixedAssignment occurrences="1"> <code>$table</code> </MixedAssignment> + <PossiblyInvalidCast occurrences="1"> + <code>$parameters['table']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Database/Structure/ReplacePrefixController.php"> - <MixedArgument occurrences="6"> + <MixedArgument occurrences="1"> + <code>$db</code> + </MixedArgument> + <PossiblyInvalidArgument occurrences="5"> <code>$current</code> <code>$current</code> - <code>$db</code> <code>$newTableName</code> <code>$selected</code> <code>$selected[$i]</code> - </MixedArgument> - <MixedArrayAccess occurrences="1"> - <code>$selected[$i]</code> - </MixedArrayAccess> - <MixedAssignment occurrences="5"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$current</code> <code>$current</code> <code>$fromPrefix</code> - <code>$newTableName</code> - <code>$selected</code> - <code>$toPrefix</code> - </MixedAssignment> - <MixedOperand occurrences="1"> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> <code>$toPrefix</code> - </MixedOperand> + </PossiblyInvalidOperand> <RedundantCast occurrences="1"> <code>(string) $fromPrefix</code> </RedundantCast> </file> <file src="libraries/classes/Controllers/Database/Structure/ShowCreateController.php"> - <MixedArgument occurrences="2"> - <code>$object->showCreate()</code> + <InvalidArgument occurrences="1"> <code>$selected</code> + </InvalidArgument> + <MixedArgument occurrences="1"> + <code>$object->showCreate()</code> </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$selected</code> - </MixedAssignment> </file> <file src="libraries/classes/Controllers/Database/StructureController.php"> <InvalidScalarArgument occurrences="2"> <code>$formattedOverhead</code> <code>$formattedSize</code> </InvalidScalarArgument> - <MixedArgument occurrences="37"> - <code>$_POST['primary_connection'] ?? null</code> + <MixedArgument occurrences="36"> <code>$checkTime</code> <code>$checkTimeAll</code> <code>$createTime</code> @@ -1721,7 +1838,7 @@ <MixedArrayAssignment occurrences="1"> <code>$currentTable['TABLE_ROWS']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="29"> + <MixedAssignment occurrences="27"> <code>$charset</code> <code>$checkTime</code> <code>$checkTimeAll</code> @@ -1748,8 +1865,6 @@ <code>$truename</code> <code>$updateTime</code> <code>$updateTimeAll</code> - <code>$urlParams['sort']</code> - <code>$urlParams['sort_order']</code> <code>$value</code> </MixedAssignment> <MixedMethodCall occurrences="1"> @@ -1763,6 +1878,9 @@ <code>$currentTable['TABLE_NAME']</code> <code>$currentTable['TABLE_ROWS']</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['primary_connection'] ?? null</code> + </PossiblyInvalidArgument> <PossiblyNullArrayAccess occurrences="8"> <code>$formattedOverhead</code> <code>$formattedSize</code> @@ -1786,10 +1904,7 @@ </RedundantCondition> </file> <file src="libraries/classes/Controllers/Database/TrackingController.php"> - <MixedArgument occurrences="14"> - <code>$_POST['selected']</code> - <code>$_POST['table']</code> - <code>$_POST['version']</code> + <MixedArgument occurrences="11"> <code>$data['ddlog']</code> <code>$data['ddlog']</code> <code>$db</code> @@ -1827,6 +1942,17 @@ <code>$entry['statement']</code> <code>$entry['username']</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="3"> + <code>$_POST['selected']</code> + <code>$_POST['table']</code> + <code>$_POST['version']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['table']</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$_POST['selected_tbl']</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Database/TriggersController.php"> <MixedArgument occurrences="4"> @@ -1976,10 +2102,6 @@ <code>$GLOBALS['language_stats'][$lang]</code> <code>$cfg['Servers'][$server]</code> </MixedArrayOffset> - <MixedAssignment occurrences="2"> - <code>$db</code> - <code>$webServer['software']</code> - </MixedAssignment> <PossiblyNullArgument occurrences="1"> <code>$this->config->get('TempDir')</code> </PossiblyNullArgument> @@ -1991,12 +2113,10 @@ <DocblockTypeContradiction occurrences="1"> <code>$import_plugin == null</code> </DocblockTypeContradiction> - <MixedArgument occurrences="39"> - <code>$_POST['bkm_label']</code> - <code>$_POST['bkm_label']</code> - <code>$_POST['bookmark_variable']</code> - <code>$_POST['sql_query']</code> - <code>$_POST['sql_query']</code> + <InvalidArgument occurrences="1"> + <code>$urlParams</code> + </InvalidArgument> + <MixedArgument occurrences="30"> <code>$_SESSION['Import_message']['go_back_url']</code> <code>$analyzed_sql_results</code> <code>$cfg['MemoryLimit']</code> @@ -2012,7 +2132,6 @@ <code>$db</code> <code>$die['error']</code> <code>$die['sql']</code> - <code>$format</code> <code>$goto</code> <code>$goto</code> <code>$importHandle ?? null</code> @@ -2020,9 +2139,6 @@ <code>$import_file</code> <code>$import_notice</code> <code>$import_text</code> - <code>$import_type</code> - <code>$local_import_file</code> - <code>$replacement</code> <code>$sql_query</code> <code>$sql_query</code> <code>$sql_query</code> @@ -2032,10 +2148,6 @@ <code>$table</code> <code>$table</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="2"> - <code>$parameter</code> - <code>$urlParams</code> - </MixedArgumentTypeCoercion> <MixedArrayAccess occurrences="10"> <code>$_FILES['import_file']['name']</code> <code>$_FILES['import_file']['name']</code> @@ -2060,81 +2172,90 @@ <code>$_SESSION['Import_message']['message']</code> <code>$_SESSION['Import_message']['message']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="29"> - <code>$MAX_FILE_SIZE</code> + <MixedAssignment occurrences="17"> <code>$_SESSION['Import_message']['go_back_url']</code> <code>$_SESSION['Import_message']['message']</code> <code>$active_page</code> - <code>$charset_of_file</code> <code>$die</code> <code>$display_query</code> - <code>$format</code> <code>$import_file</code> <code>$import_file</code> <code>$import_file_name</code> <code>$import_text</code> - <code>$import_type</code> - <code>$is_js_confirmed</code> - <code>$local_import_file</code> - <code>$message_to_show</code> - <code>$noplugin</code> <code>$offset</code> <code>$offset</code> <code>$reload</code> <code>$reload</code> - <code>$replacement</code> - <code>$show_as_php</code> - <code>$skip_queries</code> <code>$sql_queries</code> <code>$sql_query</code> <code>$table</code> <code>$table</code> - <code>$urlParams['local_import_file']</code> </MixedAssignment> <MixedMethodCall occurrences="2"> <code>close</code> <code>getDisplay</code> </MixedMethodCall> - <MixedOperand occurrences="8"> + <MixedOperand occurrences="5"> <code>$_FILES['import_file']['name']</code> <code>$charset_connection</code> - <code>$charset_of_file</code> - <code>$format</code> <code>$goto</code> <code>$goto</code> <code>$goto</code> - <code>$local_import_file</code> </MixedOperand> - <PossiblyInvalidArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="11"> + <code>$_POST['bkm_label']</code> + <code>$_POST['bkm_label']</code> + <code>$_POST['bookmark_variable']</code> + <code>$_POST['sql_query']</code> + <code>$_POST['sql_query']</code> + <code>$format</code> + <code>$import_type</code> + <code>$local_import_file</code> + <code>$parameter</code> + <code>$replacement</code> <code>$skip < $read_limit ? $skip : $read_limit</code> </PossiblyInvalidArgument> - <PossiblyNullArrayAccess occurrences="1"> - <code>$_FILES['import_file']['name']</code> - </PossiblyNullArrayAccess> + <PossiblyInvalidCast occurrences="7"> + <code>$_POST['bkm_label']</code> + <code>$_POST['bkm_label']</code> + <code>$_POST['sql_query']</code> + <code>$_POST['sql_query']</code> + <code>$format</code> + <code>$local_import_file</code> + <code>$replacement</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="3"> + <code>$charset_of_file</code> + <code>$format</code> + <code>$local_import_file</code> + </PossiblyInvalidOperand> <PossiblyUndefinedArrayOffset occurrences="1"> <code>$_FILES['import_file']</code> </PossiblyUndefinedArrayOffset> <RedundantCondition occurrences="1"> <code>$offset == 0</code> </RedundantCondition> + <RiskyCast occurrences="1"> + <code>$_POST['id_bookmark']</code> + </RiskyCast> <TypeDoesNotContainType occurrences="2"> <code>$finished</code> <code>$timeout_passed</code> </TypeDoesNotContainType> </file> <file src="libraries/classes/Controllers/Import/StatusController.php"> - <MixedArgument occurrences="2"> - <code>$_GET['id']</code> + <MixedArgument occurrences="1"> <code>$_SESSION['Import_message']['message'] ?? ''</code> </MixedArgument> <MixedArrayAssignment occurrences="1"> <code>$_SESSION['Import_message']['message']</code> </MixedArrayAssignment> - </file> - <file src="libraries/classes/Controllers/LintController.php"> - <MixedAssignment occurrences="1"> - <code>$options</code> - </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$_GET['id']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_GET['id']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/LogoutController.php"> <MixedMethodCall occurrences="1"> @@ -2142,7 +2263,7 @@ </MixedMethodCall> </file> <file src="libraries/classes/Controllers/NavigationController.php"> - <MixedArgument occurrences="9"> + <PossiblyInvalidArgument occurrences="9"> <code>! empty($_POST['tableName']) ? $_POST['tableName'] : null</code> <code>! empty($_POST['tableName']) ? $_POST['tableName'] : null</code> <code>$_POST['dbName']</code> @@ -2152,16 +2273,19 @@ <code>$_POST['itemName']</code> <code>$_POST['itemType']</code> <code>$_POST['itemType']</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="7"> + <code>$_POST['dbName']</code> + <code>$_POST['dbName']</code> + <code>$_POST['dbName']</code> + <code>$_POST['itemName']</code> + <code>$_POST['itemName']</code> + <code>$_POST['itemType']</code> + <code>$_POST['itemType']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/NormalizationController.php"> - <MixedArgument occurrences="48"> - <code>$_POST['newTables']</code> - <code>$_POST['newTablesName']</code> - <code>$_POST['pd']</code> - <code>$_POST['pd']</code> - <code>$_POST['pd']</code> - <code>$_POST['tables']</code> + <MixedArgument occurrences="36"> <code>$db</code> <code>$db</code> <code>$db</code> @@ -2179,14 +2303,9 @@ <code>$db</code> <code>$db</code> <code>$dependencies</code> - <code>$newColumn</code> - <code>$newTable</code> <code>$newtables</code> - <code>$normalForm</code> <code>$partialDependencies</code> <code>$partialDependencies</code> - <code>$primary_columns</code> - <code>$repeatingColumns</code> <code>$table</code> <code>$table</code> <code>$table</code> @@ -2202,80 +2321,73 @@ <code>$table</code> <code>$table</code> <code>$tables</code> - <code>$tables</code> <code>$tablesName</code> </MixedArgument> - <MixedAssignment occurrences="12"> + <MixedAssignment occurrences="6"> <code>$dependencies</code> - <code>$newColumn</code> - <code>$newTable</code> <code>$newtables</code> - <code>$normalForm</code> <code>$partialDependencies</code> <code>$partialDependencies</code> - <code>$primary_columns</code> - <code>$repeatingColumns</code> - <code>$tables</code> <code>$tables</code> <code>$tablesName</code> </MixedAssignment> <MixedOperand occurrences="1"> <code>$table</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="12"> + <code>$_POST['newTables']</code> + <code>$_POST['newTablesName']</code> + <code>$_POST['pd']</code> + <code>$_POST['pd']</code> + <code>$_POST['pd']</code> + <code>$_POST['tables']</code> + <code>$newColumn</code> + <code>$newTable</code> + <code>$normalForm</code> + <code>$primary_columns</code> + <code>$repeatingColumns</code> + <code>$tables</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="11"> + <code>$_POST['newTables']</code> + <code>$_POST['newTablesName']</code> + <code>$_POST['pd']</code> + <code>$_POST['pd']</code> + <code>$_POST['pd']</code> + <code>$_POST['tables']</code> + <code>$newColumn</code> + <code>$newTable</code> + <code>$normalForm</code> + <code>$primary_columns</code> + <code>$repeatingColumns</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Preferences/ExportController.php"> - <MixedArgument occurrences="1"> - <code>$tabHash</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$tabHash</code> - </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$tabHash</code> - </PossiblyNullArgument> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Preferences/FeaturesController.php"> - <MixedArgument occurrences="1"> - <code>$tabHash</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$tabHash</code> - </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$tabHash</code> - </PossiblyNullArgument> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Preferences/ImportController.php"> - <MixedArgument occurrences="1"> - <code>$tabHash</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$tabHash</code> - </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$tabHash</code> - </PossiblyNullArgument> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Preferences/MainPanelController.php"> - <MixedArgument occurrences="1"> - <code>$tabHash</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$tabHash</code> - </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$tabHash</code> - </PossiblyNullArgument> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Preferences/ManageController.php"> - <MixedArgument occurrences="7"> + <MixedArgument occurrences="4"> <code>$_FILES['import_file']['tmp_name']</code> <code>$_FILES['import_file']['tmp_name']</code> <code>$configuration['ThemeDefault']</code> <code>$configuration['ThemeDefault']</code> - <code>$json</code> - <code>$return_url</code> - <code>$return_url</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$key</code> @@ -2285,112 +2397,109 @@ <code>$_FILES['import_file']['tmp_name']</code> <code>$_FILES['import_file']['tmp_name']</code> </MixedArrayAccess> - <MixedAssignment occurrences="7"> + <MixedAssignment occurrences="5"> <code>$_POST[str_replace('/', '-', (string) $k)]</code> <code>$configuration</code> - <code>$json</code> <code>$params['lang']</code> - <code>$return_url</code> <code>$v</code> <code>$val</code> </MixedAssignment> - <PossiblyFalseArgument occurrences="1"> - <code>$json</code> - </PossiblyFalseArgument> <PossiblyFalseOperand occurrences="1"> <code>$pos</code> </PossiblyFalseOperand> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="3"> <code>$json</code> - </PossiblyNullArgument> + <code>$return_url</code> + <code>$return_url</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$json</code> + <code>$return_url</code> + <code>$return_url</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Preferences/NavigationController.php"> - <MixedArgument occurrences="1"> - <code>$tabHash</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$tabHash</code> - </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$tabHash</code> - </PossiblyNullArgument> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Preferences/SqlController.php"> - <MixedArgument occurrences="1"> - <code>$tabHash</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$tabHash</code> - </MixedAssignment> - <PossiblyNullArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$tabHash</code> - </PossiblyNullArgument> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Preferences/TwoFactorController.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$_POST['2fa_configure']</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['2fa_configure']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/SchemaExportController.php"> - <MixedArgument occurrences="1"> - <code>$_POST['export_type']</code> - </MixedArgument> - <PossiblyUndefinedArrayOffset occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$_POST['export_type']</code> - </PossiblyUndefinedArrayOffset> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Server/BinlogController.php"> - <MixedArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="2"> <code>$params['log']</code> <code>$params['log'] ?? ''</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$urlParams['log']</code> - </MixedAssignment> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$params['log'] ?? ''</code> + </PossiblyInvalidCast> <RedundantCast occurrences="1"> <code>(int) $cfg['MaxRows']</code> </RedundantCast> + <RiskyCast occurrences="1"> + <code>$params['pos']</code> + </RiskyCast> </file> <file src="libraries/classes/Controllers/Server/Databases/CreateController.php"> - <MixedArgument occurrences="6"> + <InvalidArgument occurrences="1"> + <code>['db' => $params['new_db']]</code> + </InvalidArgument> + <PossiblyInvalidArgument occurrences="6"> <code>$params['db_collation']</code> <code>$params['db_collation']</code> <code>$params['db_collation']</code> <code>$params['new_db']</code> <code>$params['new_db']</code> <code>$params['new_db']</code> - </MixedArgument> - <MixedArgumentTypeCoercion occurrences="1"> - <code>['db' => $params['new_db']]</code> - </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="1"> - <code>$db</code> - </MixedAssignment> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="4"> + <code>$params['db_collation']</code> + <code>$params['db_collation']</code> + <code>$params['new_db']</code> + <code>$params['new_db']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Server/Databases/DestroyController.php"> - <MixedArgument occurrences="3"> - <code>$database</code> - <code>$database</code> - <code>$database</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$database</code> - </MixedAssignment> <MixedMethodCall occurrences="1"> <code>build</code> </MixedMethodCall> <MixedPropertyFetch occurrences="1"> <code>$dblist->databases</code> </MixedPropertyFetch> + <PossiblyInvalidArgument occurrences="3"> + <code>$database</code> + <code>$database</code> + <code>$database</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$database</code> + <code>$database</code> + </PossiblyInvalidCast> + <TypeDoesNotContainType occurrences="1"> + <code>$selected_dbs === []</code> + </TypeDoesNotContainType> </file> <file src="libraries/classes/Controllers/Server/DatabasesController.php"> - <MixedArgument occurrences="12"> - <code>$_POST['primary_connection'] ?? null</code> + <MixedArgument occurrences="9"> <code>$database['DEFAULT_COLLATION_NAME']</code> <code>$database['SCHEMA_NAME']</code> <code>$dblist->databases</code> - <code>$params['sort_by']</code> - <code>$params['sort_order']</code> <code>$primaryInfo['Do_DB']</code> <code>$primaryInfo['Do_DB']</code> <code>$primaryInfo['Ignore_DB']</code> @@ -2439,12 +2548,20 @@ <MixedPropertyFetch occurrences="1"> <code>$dblist->databases</code> </MixedPropertyFetch> + <PossiblyInvalidArgument occurrences="3"> + <code>$_POST['primary_connection'] ?? null</code> + <code>$params['sort_by']</code> + <code>$params['sort_order']</code> + </PossiblyInvalidArgument> <PropertyNotSetInConstructor occurrences="4"> <code>$hasStatistics</code> <code>$position</code> <code>$sortBy</code> <code>$sortOrder</code> </PropertyNotSetInConstructor> + <RiskyCast occurrences="1"> + <code>$params['pos']</code> + </RiskyCast> </file> <file src="libraries/classes/Controllers/Server/ExportController.php"> <MixedArgument occurrences="6"> @@ -2468,19 +2585,18 @@ <MixedArrayOffset occurrences="2"> <code>$_SESSION[$SESSION_KEY]</code> </MixedArrayOffset> - <MixedAssignment occurrences="3"> + <MixedAssignment occurrences="1"> <code>$idKey</code> - <code>$localImportFile</code> - <code>$timeoutPassed</code> </MixedAssignment> <MixedMethodCall occurrences="1"> <code>$_SESSION[$SESSION_KEY]['handler']::getIdKey()</code> </MixedMethodCall> + <PossiblyInvalidCast occurrences="1"> + <code>$_GET['format']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Server/PrivilegesController.php"> - <MixedArgument occurrences="16"> - <code>$_POST['userGroup']</code> - <code>$db</code> + <MixedArgument occurrences="14"> <code>$db</code> <code>$db_name ?? ''</code> <code>$password ?? ''</code> @@ -2499,9 +2615,7 @@ <MixedArgumentTypeCoercion occurrences="1"> <code>$queries</code> </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="5"> - <code>$_REQUEST['db']</code> - <code>$db</code> + <MixedAssignment occurrences="3"> <code>$db_name</code> <code>$message</code> <code>$queries</code> @@ -2510,32 +2624,61 @@ <code>$export</code> <code>$title</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="2"> + <code>$_POST['userGroup']</code> + <code>$db</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST['userGroup']</code> + <code>$db</code> + </PossiblyInvalidCast> <UnusedVariable occurrences="1"> <code>$key</code> </UnusedVariable> </file> <file src="libraries/classes/Controllers/Server/ReplicationController.php"> - <MixedArgument occurrences="2"> - <code>$_POST['primary_connection'] ?? null</code> + <MixedArgument occurrences="1"> <code>$replicaInfo['status']</code> </MixedArgument> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['primary_connection'] ?? null</code> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Server/Status/Monitor/ChartingDataController.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$params['requiredData'] ?? ''</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$params['requiredData'] ?? ''</code> + </PossiblyInvalidCast> + </file> + <file src="libraries/classes/Controllers/Server/Status/Monitor/GeneralLogController.php"> + <RiskyCast occurrences="2"> + <code>$params['time_end']</code> + <code>$params['time_start']</code> + </RiskyCast> </file> <file src="libraries/classes/Controllers/Server/Status/Monitor/LogVarsController.php"> - <MixedArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="2"> <code>$params['varName']</code> <code>$params['varValue']</code> - </MixedArgument> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Server/Status/Monitor/QueryAnalyzerController.php"> - <MixedArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="2"> <code>$params['database'] ?? ''</code> <code>$params['query'] ?? ''</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$params['database'] ?? ''</code> + <code>$params['query'] ?? ''</code> + </PossiblyInvalidCast> + </file> + <file src="libraries/classes/Controllers/Server/Status/Monitor/SlowLogController.php"> + <RiskyCast occurrences="2"> + <code>$params['time_end']</code> + <code>$params['time_start']</code> + </RiskyCast> </file> <file src="libraries/classes/Controllers/Server/Status/QueriesController.php"> <MixedArgumentTypeCoercion occurrences="1"> @@ -2599,9 +2742,6 @@ </MixedOperand> </file> <file src="libraries/classes/Controllers/Server/Status/VariablesController.php"> - <MixedArgument occurrences="1"> - <code>$params['flush']</code> - </MixedArgument> <MixedArgumentTypeCoercion occurrences="2"> <code>$name</code> <code>$name</code> @@ -2619,6 +2759,12 @@ <code>$this->data->status['Qcache_total_blocks']</code> <code>$this->data->variables['thread_cache_size']</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="1"> + <code>$params['flush']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$params['flush']</code> + </PossiblyInvalidCast> <UnusedForeachValue occurrences="3"> <code>$linkUrl</code> <code>$sectionLinks</code> @@ -2629,21 +2775,28 @@ </UnusedVariable> </file> <file src="libraries/classes/Controllers/Server/UserGroupsController.php"> - <MixedArgument occurrences="5"> + <PossiblyInvalidArgument occurrences="5"> <code>$_POST['userGroup']</code> <code>$_POST['userGroup']</code> <code>$_POST['userGroup']</code> <code>$_POST['userGroup']</code> <code>$_POST['userGroup']</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="4"> + <code>$_POST['userGroup']</code> + <code>$_POST['userGroup']</code> + <code>$_POST['userGroup']</code> + <code>$_POST['userGroup']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Server/UserGroupsFormController.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$username</code> - </MixedArgument> - <MixedAssignment occurrences="1"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_GET['username']</code> <code>$username</code> - </MixedAssignment> + </PossiblyInvalidCast> <PossiblyNullArrayOffset occurrences="1"> <code>$allUserGroups</code> </PossiblyNullArrayOffset> @@ -2687,8 +2840,7 @@ <MixedArrayTypeCoercion occurrences="1"> <code>$serverVarsSession[$name]</code> </MixedArrayTypeCoercion> - <MixedAssignment occurrences="2"> - <code>$filterValue</code> + <MixedAssignment occurrences="1"> <code>$value</code> </MixedAssignment> </file> @@ -2710,59 +2862,63 @@ </MixedArgument> </file> <file src="libraries/classes/Controllers/Sql/EnumValuesController.php"> - <MixedArgument occurrences="4"> - <code>$column</code> - <code>$curr_value</code> + <MixedArgument occurrences="2"> <code>$db</code> <code>$table</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <PossiblyInvalidArgument occurrences="2"> <code>$column</code> <code>$curr_value</code> - </MixedAssignment> - </file> - <file src="libraries/classes/Controllers/Sql/RelationalValuesController.php"> - <MixedArgument occurrences="4"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> <code>$column</code> <code>$curr_value</code> + </PossiblyInvalidCast> + </file> + <file src="libraries/classes/Controllers/Sql/RelationalValuesController.php"> + <MixedArgument occurrences="2"> <code>$db</code> <code>$table</code> </MixedArgument> <MixedArrayAccess occurrences="1"> <code>$_SESSION['tmpval']['relational_display']</code> </MixedArrayAccess> - <MixedAssignment occurrences="3"> + <PossiblyInvalidArgument occurrences="2"> <code>$column</code> <code>$curr_value</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$column</code> <code>$curr_value</code> - </MixedAssignment> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Sql/SetValuesController.php"> - <MixedArgument occurrences="5"> - <code>$column</code> - <code>$currentValue</code> + <MixedArgument occurrences="2"> <code>$db</code> <code>$table</code> - <code>$whereClause</code> </MixedArgument> - <MixedAssignment occurrences="4"> + <PossiblyInvalidArgument occurrences="4"> + <code>$column</code> <code>$column</code> <code>$currentValue</code> - <code>$fullValues</code> <code>$whereClause</code> - </MixedAssignment> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="4"> + <code>$column</code> + <code>$column</code> + <code>$currentValue</code> + <code>$whereClause</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Sql/SqlController.php"> - <MixedArgument occurrences="26"> - <code>$_GET['sql_query']</code> - <code>$_GET['sql_signature']</code> - <code>$_POST['bkm_fields']</code> + <MixedArgument occurrences="24"> <code>$analyzed_sql_results</code> <code>$complete_query ?? null</code> <code>$db</code> <code>$db</code> <code>$db</code> <code>$db</code> + <code>$db</code> <code>$disp_message ?? null</code> <code>$errorUrl</code> <code>$errorUrl</code> @@ -2781,17 +2937,11 @@ <code>$table</code> <code>isset($disp_query) ? $display_query : null</code> </MixedArgument> - <MixedArrayAccess occurrences="3"> - <code>$_POST['bkm_fields']['bkm_label']</code> - <code>$_POST['bkm_fields']['bkm_label']</code> + <MixedArrayAccess occurrences="1"> <code>$ajax_reload['reload']</code> </MixedArrayAccess> - <MixedAssignment occurrences="7"> - <code>$db</code> + <MixedAssignment occurrences="3"> <code>$errorUrl</code> - <code>$sql_query</code> - <code>$sql_query</code> - <code>$sql_query</code> <code>$table</code> <code>$unlim_num_rows</code> </MixedAssignment> @@ -2799,37 +2949,63 @@ <code>$_POST['bkm_fields']['bkm_label']</code> <code>$errorUrl</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="8"> + <code>$_GET['sql_query']</code> + <code>$_GET['sql_signature']</code> + <code>$_POST['bkm_fields']</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$sql_query</code> + <code>$sql_query</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="2"> + <code>$_POST['bkm_fields']['bkm_label']</code> + <code>$_POST['bkm_fields']['bkm_label']</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="6"> + <code>$_GET['sql_query']</code> + <code>$_GET['sql_signature']</code> + <code>$db</code> + <code>$db</code> + <code>$sql_query</code> + <code>$sql_query</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/AddFieldController.php"> - <MixedArgument occurrences="11"> + <MixedArgument occurrences="8"> <code>$_POST['field_input_transformation'][$fieldindex]</code> <code>$_POST['field_input_transformation_options'][$fieldindex]</code> - <code>$_POST['field_name'][$fieldindex]</code> - <code>$_POST['field_name'][$fieldindex]</code> <code>$_POST['field_transformation'][$fieldindex]</code> <code>$_POST['field_transformation_options'][$fieldindex]</code> <code>$cfg['DefaultTabTable']</code> <code>$db</code> - <code>$mimetype</code> <code>$regenerate</code> <code>$table</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$url_params</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="4"> + <PossiblyInvalidArgument occurrences="3"> + <code>$_POST['field_name'][$fieldindex]</code> + <code>$_POST['field_name'][$fieldindex]</code> + <code>$mimetype</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="4"> <code>$_POST['field_input_transformation'][$fieldindex]</code> <code>$_POST['field_input_transformation_options'][$fieldindex]</code> <code>$_POST['field_transformation'][$fieldindex]</code> <code>$_POST['field_transformation_options'][$fieldindex]</code> - </MixedArrayAccess> - <MixedAssignment occurrences="3"> - <code>$_POST['after_field']</code> - <code>$_POST['field_where']</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST['field_name'][$fieldindex]</code> <code>$mimetype</code> - </MixedAssignment> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/ChangeController.php"> + <InvalidArgument occurrences="1"> + <code>$urlParams</code> + </InvalidArgument> <MixedArgument occurrences="33"> <code>$current_result</code> <code>$current_row</code> @@ -2865,9 +3041,6 @@ <code>$where_clause_array</code> <code>$where_clauses</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="1"> - <code>$urlParams</code> - </MixedArgumentTypeCoercion> <MixedArrayAccess occurrences="1"> <code>$unsaved_values[$row_id]</code> </MixedArrayAccess> @@ -2908,63 +3081,72 @@ <code>$biggest_max_file_size > 0</code> </TypeDoesNotContainType> </file> - <file src="libraries/classes/Controllers/Table/ChangeRowsController.php"> - <MixedAssignment occurrences="2"> - <code>$i_where_clause</code> - <code>$where_clause[]</code> - </MixedAssignment> - </file> <file src="libraries/classes/Controllers/Table/ChartController.php"> <DocblockTypeContradiction occurrences="1"> <code>empty($statement->limit)</code> </DocblockTypeContradiction> - <MixedArgument occurrences="11"> + <InvalidArgument occurrences="2"> + <code>$rows</code> + <code>$start</code> + </InvalidArgument> + <InvalidScalarArgument occurrences="2"> <code>$_REQUEST['pos']</code> <code>$_REQUEST['session_max_rows']</code> + </InvalidScalarArgument> + <MixedArgument occurrences="7"> <code>$db</code> <code>$db</code> <code>$db</code> - <code>$rows</code> <code>$sql_query</code> <code>$sql_query</code> - <code>$start</code> <code>$table</code> <code>$table</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$url_params</code> </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="3"> - <code>$rows</code> - <code>$start</code> + <MixedAssignment occurrences="1"> <code>$url_params['db']</code> </MixedAssignment> - <MixedOperand occurrences="2"> + <PossiblyInvalidOperand occurrences="4"> <code>$_REQUEST['pos']</code> <code>$_REQUEST['pos']</code> - </MixedOperand> + <code>$statement->limit->offset</code> + <code>$statement->limit->rowCount</code> + </PossiblyInvalidOperand> </file> <file src="libraries/classes/Controllers/Table/CreateController.php"> - <MixedArgument occurrences="9"> + <MixedArgument occurrences="6"> <code>$_POST['field_input_transformation'][$fieldindex]</code> <code>$_POST['field_input_transformation_options'][$fieldindex]</code> - <code>$_POST['field_name'][$fieldindex]</code> - <code>$_POST['field_name'][$fieldindex]</code> <code>$_POST['field_transformation'][$fieldindex]</code> <code>$_POST['field_transformation_options'][$fieldindex]</code> <code>$db</code> - <code>$mimetype</code> <code>$table</code> </MixedArgument> - <MixedArrayAccess occurrences="4"> + <PossiblyInvalidArgument occurrences="7"> <code>$_POST['field_input_transformation'][$fieldindex]</code> <code>$_POST['field_input_transformation_options'][$fieldindex]</code> + <code>$_POST['field_name'][$fieldindex]</code> + <code>$_POST['field_name'][$fieldindex]</code> <code>$_POST['field_transformation'][$fieldindex]</code> <code>$_POST['field_transformation_options'][$fieldindex]</code> - </MixedArrayAccess> - <MixedAssignment occurrences="1"> <code>$mimetype</code> - </MixedAssignment> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="4"> + <code>$_POST['field_input_transformation'][$fieldindex]</code> + <code>$_POST['field_input_transformation_options'][$fieldindex]</code> + <code>$_POST['field_transformation'][$fieldindex]</code> + <code>$_POST['field_transformation_options'][$fieldindex]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="6"> + <code>$_POST['field_input_transformation'][$fieldindex]</code> + <code>$_POST['field_input_transformation_options'][$fieldindex]</code> + <code>$_POST['field_name'][$fieldindex]</code> + <code>$_POST['field_transformation'][$fieldindex]</code> + <code>$_POST['field_transformation_options'][$fieldindex]</code> + <code>$mimetype</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/DeleteConfirmController.php"> <MixedArgumentTypeCoercion occurrences="1"> @@ -2972,8 +3154,10 @@ </MixedArgumentTypeCoercion> </file> <file src="libraries/classes/Controllers/Table/DeleteRowsController.php"> - <MixedArgument occurrences="10"> + <InvalidArgument occurrences="1"> <code>$_REQUEST['pos']</code> + </InvalidArgument> + <MixedArgument occurrences="9"> <code>$db</code> <code>$db</code> <code>$db</code> @@ -2984,34 +3168,41 @@ <code>$table</code> <code>$table</code> </MixedArgument> - <MixedAssignment occurrences="5"> - <code>$mult_btn</code> - <code>$original_sql_query</code> + <MixedAssignment occurrences="1"> <code>$row</code> - <code>$selected</code> - <code>$sql_query</code> </MixedAssignment> - </file> - <file src="libraries/classes/Controllers/Table/DropColumnConfirmationController.php"> - <MixedAssignment occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> + <code>$sql_query</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$sql_query</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> <code>$selected</code> - </MixedAssignment> + </PossiblyInvalidIterator> + <RedundantCondition occurrences="1"> + <code>isset($original_sql_query)</code> + </RedundantCondition> </file> <file src="libraries/classes/Controllers/Table/DropColumnController.php"> - <MixedArgument occurrences="4"> + <MixedArgument occurrences="3"> <code>$field</code> <code>$field</code> <code>$message->getMessage()</code> - <code>$selected</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$field</code> - <code>$selected</code> </MixedAssignment> <MixedMethodCall occurrences="2"> <code>getMessage</code> <code>isError</code> </MixedMethodCall> + <PossiblyInvalidArgument occurrences="1"> + <code>$selected</code> + </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/ExportController.php"> <MixedArgument occurrences="7"> @@ -3035,21 +3226,13 @@ <code>$GLOBALS['single_table']</code> </MixedAssignment> </file> - <file src="libraries/classes/Controllers/Table/ExportRowsController.php"> - <MixedAssignment occurrences="2"> - <code>$i_where_clause</code> - <code>$where_clause[]</code> - </MixedAssignment> - </file> <file src="libraries/classes/Controllers/Table/FindReplaceController.php"> - <MixedArgument occurrences="27"> + <InvalidScalarArgument occurrences="3"> <code>$_POST['columnIndex']</code> <code>$_POST['columnIndex']</code> - <code>$_POST['find']</code> - <code>$_POST['findString']</code> - <code>$_POST['replaceWith']</code> - <code>$_POST['replaceWith']</code> <code>$_POST['useRegex']</code> + </InvalidScalarArgument> + <MixedArgument occurrences="20"> <code>$column</code> <code>$column</code> <code>$column</code> @@ -3092,33 +3275,46 @@ <code>$row</code> <code>$row</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="4"> + <code>$_POST['find']</code> + <code>$_POST['findString']</code> + <code>$_POST['replaceWith']</code> + <code>$_POST['replaceWith']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="4"> + <code>$_POST['find']</code> + <code>$_POST['findString']</code> + <code>$_POST['replaceWith']</code> + <code>$_POST['replaceWith']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/GetFieldController.php"> - <MixedArgument occurrences="7"> - <code>$_GET['transform_key']</code> - <code>$_GET['where_clause']</code> - <code>$_GET['where_clause_sign']</code> + <MixedArgument occurrences="4"> <code>$db</code> <code>$db</code> <code>$db</code> <code>$table</code> </MixedArgument> - <MixedOperand occurrences="2"> + <PossiblyInvalidArgument occurrences="3"> <code>$_GET['transform_key']</code> <code>$_GET['where_clause']</code> - </MixedOperand> + <code>$_GET['where_clause_sign']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_GET['where_clause']</code> + <code>$_GET['where_clause_sign']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="2"> + <code>$_GET['transform_key']</code> + <code>$_GET['where_clause']</code> + </PossiblyInvalidOperand> <PossiblyNullArgument occurrences="1"> <code>$result</code> </PossiblyNullArgument> </file> <file src="libraries/classes/Controllers/Table/GisVisualizationController.php"> - <MixedArgument occurrences="6"> - <code>$_GET['fileFormat']</code> - <code>$_GET['sql_query']</code> - <code>$_GET['sql_signature']</code> - <code>$sqlQuery</code> + <MixedArgument occurrences="1"> <code>$urlParams</code> - <code>$visualizationSettings['spatialColumn']</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>['db' => $db]</code> @@ -3133,18 +3329,40 @@ <code>$urlParams['sql_query']</code> <code>$urlParams['sql_signature']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="4"> - <code>$sqlQuery</code> - <code>$sqlQuery</code> + <MixedAssignment occurrences="2"> <code>$val</code> <code>$visualizationSettings[$setting]</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="8"> + <code>$_GET['fileFormat']</code> + <code>$_GET['sql_query']</code> + <code>$_GET['sql_signature']</code> + <code>$sqlQuery</code> + <code>$sqlQuery</code> + <code>$sqlQuery</code> + <code>$sqlQuery</code> + <code>$visualizationSettings['spatialColumn']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="8"> + <code>$_GET['fileFormat']</code> + <code>$_GET['sql_query']</code> + <code>$_GET['sql_signature']</code> + <code>$sqlQuery</code> + <code>$sqlQuery</code> + <code>$sqlQuery</code> + <code>$sqlQuery</code> + <code>$visualizationSettings['spatialColumn']</code> + </PossiblyInvalidCast> <PropertyNotSetInConstructor occurrences="1"> <code>$visualization</code> </PropertyNotSetInConstructor> <RedundantCast occurrences="1"> <code>(int) $GLOBALS['cfg']['MaxRows']</code> </RedundantCast> + <RiskyCast occurrences="2"> + <code>$_POST['pos'] ?? $_GET['pos'] ?? $_SESSION['tmpval']['pos']</code> + <code>$_POST['session_max_rows'] ?? $_GET['session_max_rows']</code> + </RiskyCast> </file> <file src="libraries/classes/Controllers/Table/ImportController.php"> <MixedArgumentTypeCoercion occurrences="1"> @@ -3157,64 +3375,52 @@ <MixedArrayOffset occurrences="2"> <code>$_SESSION[$SESSION_KEY]</code> </MixedArrayOffset> - <MixedAssignment occurrences="3"> + <MixedAssignment occurrences="1"> <code>$idKey</code> - <code>$localImportFile</code> - <code>$timeoutPassed</code> </MixedAssignment> <MixedMethodCall occurrences="1"> <code>$_SESSION[$SESSION_KEY]['handler']::getIdKey()</code> </MixedMethodCall> + <PossiblyInvalidCast occurrences="1"> + <code>$_GET['format']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/IndexRenameController.php"> - <MixedArgument occurrences="1"> - <code>$_POST['index']</code> - </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$urlParams</code> </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="2"> - <code>$formParams['old_index']</code> - <code>$formParams['old_index']</code> - </MixedAssignment> </file> <file src="libraries/classes/Controllers/Table/IndexesController.php"> - <MixedArgument occurrences="4"> - <code>$_POST['columns']</code> - <code>$_POST['index']</code> + <MixedArgument occurrences="2"> <code>$_POST['index']['columns']['names']</code> <code>$fields</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$urlParams</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="1"> - <code>$_POST['index']['Index_choice']</code> - </MixedArrayAccess> - <MixedAssignment occurrences="4"> - <code>$add_fields</code> + <MixedAssignment occurrences="1"> <code>$fields</code> - <code>$form_params['old_index']</code> - <code>$form_params['old_index']</code> </MixedAssignment> - <MixedOperand occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['columns']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="1"> + <code>$_POST['index']['Index_choice']</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['columns']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="2"> <code>$_POST['added_fields']</code> - </MixedOperand> + <code>$add_fields</code> + </PossiblyInvalidOperand> </file> <file src="libraries/classes/Controllers/Table/OperationsController.php"> - <MixedArgument occurrences="24"> - <code>$GLOBALS['dblist']->databases</code> - <code>$_POST['db']</code> - <code>$_POST['new_name']</code> - <code>$_POST['new_name']</code> - <code>$_POST['new_name']</code> - <code>$_POST['new_tbl_storage_engine']</code> - <code>$_POST['new_tbl_storage_engine']</code> - <code>$_POST['order_field']</code> - <code>$_POST['order_order'] ?? null</code> + <InvalidArgument occurrences="1"> <code>$_POST['partition_name']</code> - <code>$_POST['partition_operation']</code> - <code>$_POST['tbl_collation']</code> + </InvalidArgument> + <MixedArgument occurrences="13"> + <code>$GLOBALS['dblist']->databases</code> <code>$_message</code> <code>$_message</code> <code>$create_options['pack_keys']</code> @@ -3234,19 +3440,41 @@ <MixedArrayAccess occurrences="1"> <code>$GLOBALS['showtable']['Row_format']</code> </MixedArrayAccess> - <MixedAssignment occurrences="8"> + <MixedAssignment occurrences="7"> <code>$GLOBALS['showtable']</code> <code>$GLOBALS['showtable']</code> <code>$create_options['page_checksum']</code> <code>$create_options['page_checksum']</code> <code>$databaseList</code> - <code>$db</code> <code>$reread_info</code> <code>$row_format</code> </MixedAssignment> <MixedMethodCall occurrences="1"> <code>getList</code> </MixedMethodCall> + <PossiblyInvalidArgument occurrences="10"> + <code>$_POST['db']</code> + <code>$_POST['new_name']</code> + <code>$_POST['new_name']</code> + <code>$_POST['new_name']</code> + <code>$_POST['new_tbl_storage_engine']</code> + <code>$_POST['new_tbl_storage_engine']</code> + <code>$_POST['order_field']</code> + <code>$_POST['order_order'] ?? null</code> + <code>$_POST['partition_operation']</code> + <code>$_POST['tbl_collation']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="9"> + <code>$_POST['db']</code> + <code>$_POST['new_name']</code> + <code>$_POST['new_name']</code> + <code>$_POST['new_name']</code> + <code>$_POST['new_tbl_storage_engine']</code> + <code>$_POST['new_tbl_storage_engine']</code> + <code>$_POST['order_field']</code> + <code>$_POST['partition_operation']</code> + <code>$_POST['tbl_collation']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/Partition/AnalyzeController.php"> <MixedArgument occurrences="1"> @@ -3275,34 +3503,26 @@ </MixedArgument> </file> <file src="libraries/classes/Controllers/Table/RecentFavoriteController.php"> - <MixedArgument occurrences="4"> + <PossiblyInvalidArgument occurrences="4"> <code>$_REQUEST['db']</code> <code>$_REQUEST['db']</code> <code>$_REQUEST['table']</code> <code>$_REQUEST['table']</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="4"> + <code>$_REQUEST['db']</code> + <code>$_REQUEST['db']</code> + <code>$_REQUEST['table']</code> + <code>$_REQUEST['table']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/RelationController.php"> <InvalidArgument occurrences="1"> <code>usort($tables, 'strnatcasecmp')</code> </InvalidArgument> - <MixedArgument occurrences="18"> - <code>$_POST['destination_column']</code> - <code>$_POST['destination_db']</code> - <code>$_POST['destination_foreign_column']</code> - <code>$_POST['destination_foreign_db']</code> - <code>$_POST['destination_foreign_table']</code> - <code>$_POST['destination_table']</code> - <code>$_POST['display_field']</code> - <code>$_POST['foreignDb']</code> - <code>$_POST['foreignDb']</code> - <code>$_POST['foreignDb']</code> - <code>$_POST['foreignDb']</code> + <MixedArgument occurrences="4"> <code>$column['Field']</code> - <code>$foreignTable</code> <code>$html</code> - <code>$multi_edit_columns_name</code> - <code>$multi_edit_columns_name</code> <code>$preview_sql_data</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="2"> @@ -3313,27 +3533,40 @@ <code>$column_array[$column['Field']]</code> <code>$column_hash_array[$column['Field']]</code> </MixedArrayOffset> - <MixedAssignment occurrences="5"> + <MixedAssignment occurrences="2"> <code>$GLOBALS['display_query']</code> <code>$column_array[$column['Field']]</code> - <code>$foreignTable</code> - <code>$multi_edit_columns_name</code> - <code>$multi_edit_columns_name</code> </MixedAssignment> - <PossiblyNullArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="15"> + <code>$_POST['destination_column']</code> + <code>$_POST['destination_db']</code> + <code>$_POST['destination_foreign_column']</code> + <code>$_POST['destination_foreign_db']</code> + <code>$_POST['destination_foreign_table']</code> + <code>$_POST['destination_table']</code> + <code>$_POST['display_field']</code> + <code>$_POST['foreignDb']</code> + <code>$_POST['foreignDb']</code> + <code>$_POST['foreignDb']</code> + <code>$_POST['foreignDb']</code> + <code>$foreignTable</code> + <code>$foreignTable</code> <code>$multi_edit_columns_name</code> <code>$multi_edit_columns_name</code> - </PossiblyNullArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="5"> + <code>$_POST['display_field']</code> + <code>$_POST['foreignDb']</code> + <code>$_POST['foreignDb']</code> + <code>$foreignTable</code> + <code>$foreignTable</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/ReplaceController.php"> <InvalidArgument occurrences="1"> <code>$insert_errors</code> </InvalidArgument> - <MixedArgument occurrences="49"> - <code>$_POST['db']</code> - <code>$_POST['rel_fields_list']</code> - <code>$_POST['table']</code> - <code>$_POST['transform_fields_list']</code> + <MixedArgument occurrences="45"> <code>$column_name</code> <code>$column_name</code> <code>$column_name</code> @@ -3389,7 +3622,7 @@ <code>$rownumber</code> </MixedArgumentTypeCoercion> <MixedArrayAccess occurrences="6"> - <code>$_POST['fields_name']['multi_edit']</code> + <code>$_POST['fields_name']['multi_edit'][0]</code> <code>$extra_data['relations']</code> <code>$multi_edit_columns[$key]</code> <code>$transformation[$type]</code> @@ -3406,17 +3639,14 @@ <MixedArrayOffset occurrences="1"> <code>$mime_map[$column_name]</code> </MixedArrayOffset> - <MixedAssignment occurrences="28"> - <code>$GLOBALS['cfg']['InsertRows']</code> + <MixedAssignment occurrences="24"> <code>$GLOBALS['sql_query']</code> - <code>$clauseIsUnique</code> <code>$column_name</code> <code>$column_name</code> <code>$column_name</code> <code>$curr_rel_field</code> <code>$current_value</code> <code>$extra_data['row_count']</code> - <code>$insertRows</code> <code>$multi_edit_auto_increment</code> <code>$multi_edit_columns</code> <code>$multi_edit_columns_name</code> @@ -3432,7 +3662,6 @@ <code>$relation_field_value</code> <code>$transformation</code> <code>$unsaved_values[$rownumber]</code> - <code>$urlParams['after_insert']</code> <code>$urlParams['where_clause'][]</code> <code>$where_clause</code> </MixedAssignment> @@ -3445,10 +3674,28 @@ <code>$where_clause</code> <code>$where_clause</code> </MixedOperand> - <PossiblyNullArgument occurrences="10"> - <code>$current_value</code> - <code>$current_value</code> - <code>$current_value</code> + <PossiblyInvalidArgument occurrences="4"> + <code>$_POST['db']</code> + <code>$_POST['rel_fields_list']</code> + <code>$_POST['table']</code> + <code>$_POST['transform_fields_list']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="4"> + <code>$_POST['fields_name']['multi_edit']</code> + <code>$multi_edit_columns[$key]</code> + <code>$multi_edit_columns[$key]</code> + <code>$multi_edit_columns[$key]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="4"> + <code>$_POST['db']</code> + <code>$_POST['rel_fields_list']</code> + <code>$_POST['table']</code> + <code>$_POST['transform_fields_list']</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$_POST['where_clause']</code> + </PossiblyInvalidIterator> + <PossiblyNullArgument occurrences="7"> <code>$multi_edit_columns_null</code> <code>$multi_edit_columns_null</code> <code>$multi_edit_columns_null_prev</code> @@ -3462,13 +3709,7 @@ </PossiblyUndefinedVariable> </file> <file src="libraries/classes/Controllers/Table/SearchController.php"> - <MixedArgument occurrences="11"> - <code>$_POST['column']</code> - <code>$_POST['db']</code> - <code>$_POST['table']</code> - <code>$_POST['where_clause']</code> - <code>$_POST['where_clause_sign']</code> - <code>$selected_operator</code> + <MixedArgument occurrences="5"> <code>$this->columnNames[$column_index]</code> <code>$this->columnNames[$column_index]</code> <code>$this->columnNullFlags[$column_index]</code> @@ -3478,42 +3719,59 @@ <MixedArgumentTypeCoercion occurrences="1"> <code>$urlParams</code> </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="5"> + <MixedAssignment occurrences="3"> <code>$collation</code> - <code>$entered_value</code> <code>$is_unsigned</code> - <code>$selected_operator</code> <code>$type</code> </MixedAssignment> - <MixedOperand occurrences="1"> + <PossiblyInvalidArgument occurrences="6"> + <code>$_POST['column']</code> + <code>$_POST['db']</code> + <code>$_POST['table']</code> <code>$_POST['where_clause']</code> - </MixedOperand> + <code>$_POST['where_clause_sign']</code> + <code>$selected_operator</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$_POST['column']</code> + <code>$_POST['where_clause']</code> + <code>$_POST['where_clause_sign']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> + <code>$_POST['where_clause']</code> + </PossiblyInvalidOperand> <RedundantCastGivenDocblockType occurrences="1"> <code>(int) $fields_meta[$i]->length</code> </RedundantCastGivenDocblockType> </file> <file src="libraries/classes/Controllers/Table/SqlController.php"> - <MixedArgument occurrences="4"> - <code>$_GET['sql_query'] ?? true</code> - <code>$_POST['delimiter']</code> + <MixedArgument occurrences="2"> <code>$db</code> <code>$table</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$url_params</code> </MixedArgumentTypeCoercion> + <PossiblyInvalidArgument occurrences="2"> + <code>$_GET['sql_query'] ?? true</code> + <code>$_POST['delimiter']</code> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Table/Structure/AddIndexController.php"> - <MixedArgument occurrences="4"> + <MixedArgument occurrences="3"> <code>$db</code> <code>$field</code> - <code>$selected</code> <code>$table</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$field</code> - <code>$selected</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$selected</code> + </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/Structure/BrowseController.php"> <MixedArgument occurrences="3"> @@ -3524,55 +3782,57 @@ <MixedAssignment occurrences="1"> <code>$sval</code> </MixedAssignment> - <PossiblyInvalidArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="2"> <code>$analyzed_sql_results ?? ''</code> + <code>$sval</code> </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> + <code>$_POST['selected_fld']</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/Structure/CentralColumnsAddController.php"> - <MixedArgument occurrences="1"> - <code>$selected</code> - </MixedArgument> - <MixedAssignment occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$selected</code> - </MixedAssignment> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Table/Structure/CentralColumnsRemoveController.php"> - <MixedArgument occurrences="2"> + <MixedArgument occurrences="1"> <code>$db</code> - <code>$selected</code> </MixedArgument> - <MixedAssignment occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$selected</code> - </MixedAssignment> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Table/Structure/ChangeController.php"> - <MixedArgument occurrences="2"> - <code>$selected</code> + <MixedArgument occurrences="1"> <code>$selected[$i]</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <PossiblyInvalidArgument occurrences="2"> <code>$selected</code> - <code>$selected[]</code> - </MixedAssignment> + <code>$selected[$i]</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$selected[$i]</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/Table/Structure/FulltextController.php"> - <MixedArgument occurrences="4"> + <MixedArgument occurrences="3"> <code>$db</code> <code>$field</code> - <code>$selected</code> <code>$table</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$field</code> - <code>$selected</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$selected</code> + </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/Structure/MoveColumnsController.php"> - <MixedArgument occurrences="16"> - <code>$column</code> - <code>$column</code> - <code>$column</code> - <code>$column</code> + <MixedArgument occurrences="12"> <code>$current_timestamp ? '' : $data['Default']</code> <code>$data['Collation'] ?? ''</code> <code>$data['Expression']</code> @@ -3599,16 +3859,24 @@ <code>$data['Expression']</code> <code>$data['Virtuality']</code> </MixedArrayAssignment> - <MixedArrayOffset occurrences="2"> - <code>$columns[$column]</code> - <code>$expressions[$column]</code> - </MixedArrayOffset> - <MixedAssignment occurrences="3"> - <code>$column</code> + <MixedAssignment occurrences="2"> <code>$data</code> <code>$data['Expression']</code> </MixedAssignment> <PossiblyFalseArgument occurrences="2"/> + <PossiblyInvalidArgument occurrences="3"> + <code>$column</code> + <code>$column</code> + <code>$column</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="2"> + <code>$columns[$column]</code> + <code>$expressions[$column]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="2"> + <code>$column</code> + <code>$column</code> + </PossiblyInvalidCast> <PossiblyNullArgument occurrences="4"> <code>$current_timestamp ? '' : $data['Default']</code> <code>$data['Collation'] ?? ''</code> @@ -3633,62 +3901,54 @@ </RedundantConditionGivenDocblockType> </file> <file src="libraries/classes/Controllers/Table/Structure/PrimaryController.php"> - <MixedArgument occurrences="4"> + <MixedArgument occurrences="3"> <code>$db</code> <code>$field</code> - <code>$selected</code> <code>$table</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$urlParams</code> </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="5"> + <MixedAssignment occurrences="2"> <code>$field</code> <code>$mult_btn</code> + </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> <code>$selected</code> + </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> <code>$selected</code> - <code>$selected_fld</code> - </MixedAssignment> + </PossiblyInvalidIterator> <PossiblyNullOperand occurrences="1"> <code>$row['Column_name']</code> </PossiblyNullOperand> </file> <file src="libraries/classes/Controllers/Table/Structure/ReservedWordCheckController.php"> - <MixedArgument occurrences="1"> + <MixedArgument occurrences="2"> + <code>$column</code> <code>$column</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$column</code> - <code>$columns_names</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="2"> + <code>$column</code> + <code>$column</code> + </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> + <code>$columns_names</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/Structure/SaveController.php"> - <MixedArgument occurrences="42"> - <code>$_POST['field_attribute'][$i]</code> - <code>$_POST['field_attribute_orig'][$i]</code> - <code>$_POST['field_default_type'][$i]</code> - <code>$_POST['field_default_type_orig'][$i]</code> - <code>$_POST['field_default_value'][$i]</code> - <code>$_POST['field_default_value_orig'][$i]</code> + <InvalidArgument occurrences="1"> + <code>$adjust_privileges</code> + </InvalidArgument> + <MixedArgument occurrences="22"> <code>$_POST['field_input_transformation'][$fieldindex]</code> <code>$_POST['field_input_transformation_options'][$fieldindex]</code> - <code>$_POST['field_length'][$i]</code> - <code>$_POST['field_length_orig'][$i]</code> - <code>$_POST['field_name'] ?? []</code> - <code>$_POST['field_name'][$fieldindex]</code> - <code>$_POST['field_name'][$fieldindex]</code> <code>$_POST['field_name'][$fieldindex]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_orig'][$i]</code> - <code>$_POST['field_orig'][$i]</code> - <code>$_POST['field_orig'][$i]</code> <code>$_POST['field_transformation'][$fieldindex]</code> <code>$_POST['field_transformation_options'][$fieldindex]</code> - <code>$_POST['field_type'][$i]</code> - <code>$_POST['field_type_orig'][$i]</code> - <code>$fieldcontent</code> - <code>$mimetype</code> <code>$newCol</code> <code>Util::getValueByKey($_POST, 'field_collation.' . $i, '')</code> <code>Util::getValueByKey($_POST, 'field_collation_orig.' . $i, '')</code> @@ -3707,81 +3967,92 @@ <code>Util::getValueByKey($_POST, 'field_virtuality.' . $i, '')</code> <code>Util::getValueByKey($_POST, 'field_virtuality_orig.' . $i, '')</code> </MixedArgument> - <MixedArrayAccess occurrences="31"> - <code>$_POST[$field . '_orig'][$i]</code> - <code>$_POST[$field][$i]</code> + <MixedAssignment occurrences="2"> + <code>$newCol</code> + <code>$sorted_col</code> + </MixedAssignment> + <PossiblyInvalidArgument occurrences="20"> <code>$_POST['field_attribute'][$i]</code> <code>$_POST['field_attribute_orig'][$i]</code> <code>$_POST['field_default_type'][$i]</code> <code>$_POST['field_default_type_orig'][$i]</code> <code>$_POST['field_default_value'][$i]</code> <code>$_POST['field_default_value_orig'][$i]</code> - <code>$_POST['field_expression'][$i]</code> - <code>$_POST['field_input_transformation'][$fieldindex]</code> - <code>$_POST['field_input_transformation_options'][$fieldindex]</code> <code>$_POST['field_length'][$i]</code> <code>$_POST['field_length_orig'][$i]</code> + <code>$_POST['field_name'] ?? []</code> <code>$_POST['field_name'][$fieldindex]</code> <code>$_POST['field_name'][$fieldindex]</code> <code>$_POST['field_name'][$i]</code> <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_orig'][$i]</code> - <code>$_POST['field_orig'][$i]</code> - <code>$_POST['field_orig'][$i]</code> - <code>$_POST['field_orig'][$i]</code> <code>$_POST['field_orig'][$i]</code> <code>$_POST['field_orig'][$i]</code> <code>$_POST['field_orig'][$i]</code> + <code>$_POST['field_type'][$i]</code> + <code>$_POST['field_type_orig'][$i]</code> + <code>$fieldcontent</code> + <code>$mimetype</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="5"> + <code>$_POST['field_input_transformation'][$fieldindex]</code> + <code>$_POST['field_input_transformation_options'][$fieldindex]</code> + <code>$_POST['field_name'][$fieldindex]</code> <code>$_POST['field_transformation'][$fieldindex]</code> <code>$_POST['field_transformation_options'][$fieldindex]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="15"> + <code>$_POST['field_attribute'][$i]</code> + <code>$_POST['field_attribute_orig'][$i]</code> + <code>$_POST['field_default_type'][$i]</code> + <code>$_POST['field_default_type_orig'][$i]</code> + <code>$_POST['field_default_value'][$i]</code> + <code>$_POST['field_default_value_orig'][$i]</code> + <code>$_POST['field_length'][$i]</code> + <code>$_POST['field_length_orig'][$i]</code> + <code>$_POST['field_name'][$fieldindex]</code> + <code>$_POST['field_name'][$i]</code> + <code>$_POST['field_name'][$i]</code> <code>$_POST['field_type'][$i]</code> <code>$_POST['field_type_orig'][$i]</code> - </MixedArrayAccess> - <MixedArrayAssignment occurrences="2"> - <code>$_POST['field_extra'][$i]</code> - <code>$_POST['field_null'][$i]</code> - </MixedArrayAssignment> - <MixedArrayOffset occurrences="1"> - <code>$adjust_privileges[$_POST['field_orig'][$i]]</code> - </MixedArrayOffset> - <MixedAssignment occurrences="5"> - <code>$adjust_privileges[$_POST['field_orig'][$i]]</code> <code>$fieldcontent</code> <code>$mimetype</code> - <code>$newCol</code> - <code>$sorted_col</code> - </MixedAssignment> - <MixedOperand occurrences="2"> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="2"> <code>$_POST['field_expression'][$i]</code> <code>$_POST['field_virtuality'][$i]</code> - </MixedOperand> + </PossiblyInvalidOperand> </file> <file src="libraries/classes/Controllers/Table/Structure/SpatialController.php"> - <MixedArgument occurrences="4"> + <MixedArgument occurrences="3"> <code>$db</code> <code>$field</code> - <code>$selected</code> <code>$table</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$field</code> - <code>$selected</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$selected</code> + </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/Structure/UniqueController.php"> - <MixedArgument occurrences="4"> + <MixedArgument occurrences="3"> <code>$db</code> <code>$field</code> - <code>$selected</code> <code>$table</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$field</code> - <code>$selected</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$selected</code> + </PossiblyInvalidArgument> + <PossiblyInvalidIterator occurrences="1"> + <code>$selected</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/StructureController.php"> <MixedArgument occurrences="13"> @@ -3855,12 +4126,11 @@ </PossiblyNullArrayAccess> </file> <file src="libraries/classes/Controllers/Table/TrackingController.php"> - <MixedArgument occurrences="26"> + <MixedArgument occurrences="25"> <code>$_POST['date_from']</code> <code>$_POST['date_to']</code> <code>$_POST['users']</code> <code>$_POST['version']</code> - <code>$_POST['version']</code> <code>$data</code> <code>$data</code> <code>$data</code> @@ -3896,6 +4166,19 @@ <code>$data</code> <code>$version</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="3"> + <code>$_POST['date_from']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$_POST['date_from']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$_POST['selected_versions']</code> + </PossiblyInvalidIterator> </file> <file src="libraries/classes/Controllers/Table/TriggersController.php"> <MixedArgument occurrences="4"> @@ -3910,17 +4193,11 @@ </MixedArgumentTypeCoercion> </file> <file src="libraries/classes/Controllers/Table/ZoomSearchController.php"> - <MixedArgument occurrences="17"> - <code>$_POST['db']</code> - <code>$_POST['table']</code> - <code>$_POST['where_clause']</code> - <code>$_POST['where_clause_sign']</code> + <InvalidArrayOffset occurrences="1"/> + <MixedArgument occurrences="10"> <code>$columnName</code> - <code>$dataLabel</code> - <code>$dataLabel</code> <code>$goto</code> <code>$properties['type']</code> - <code>$selected_operator</code> <code>$this->columnNames[$column_index]</code> <code>$this->columnNames[$column_index]</code> <code>$this->columnNullFlags[$column_index]</code> @@ -3933,58 +4210,58 @@ <code>$key</code> <code>$urlParams</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="6"> - <code>$_POST['criteriaColumnNames'][0]</code> - <code>$_POST['criteriaColumnNames'][0]</code> - <code>$_POST['criteriaColumnNames'][0]</code> - <code>$_POST['criteriaColumnNames'][1]</code> - <code>$_POST['criteriaColumnNames'][1]</code> - <code>$_POST['criteriaColumnNames'][1]</code> - </MixedArrayAccess> - <MixedArrayOffset occurrences="5"> + <MixedArrayOffset occurrences="1"> <code>$column_names_hashes[$columnName]</code> - <code>$keys[$criteria_column_names[$i]]</code> - <code>$row[$_POST['criteriaColumnNames'][0]]</code> - <code>$row[$_POST['criteriaColumnNames'][1]]</code> </MixedArrayOffset> - <MixedAssignment occurrences="11"> + <MixedAssignment occurrences="6"> <code>$collation</code> <code>$columnName</code> - <code>$criteria_column_names</code> - <code>$dataLabel</code> - <code>$entered_value</code> - <code>$field</code> <code>$is_unsigned</code> <code>$row['where_clause']</code> - <code>$selected_operator</code> <code>$tmpData[$dataLabel]</code> <code>$type</code> </MixedAssignment> - <MixedOperand occurrences="2"> - <code>$_POST['maxPlotLimit']</code> + <PossiblyFalseArgument occurrences="1"> + <code>$key</code> + </PossiblyFalseArgument> + <PossiblyInvalidArgument occurrences="7"> + <code>$_POST['db']</code> + <code>$_POST['table']</code> <code>$_POST['where_clause']</code> - </MixedOperand> - <PossiblyFalseArgument occurrences="3"> + <code>$_POST['where_clause_sign']</code> <code>$dataLabel</code> <code>$dataLabel</code> - <code>$key</code> - </PossiblyFalseArgument> + <code>$selected_operator</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="2"> + <code>$row[$_POST['criteriaColumnNames'][0]]</code> + <code>$row[$_POST['criteriaColumnNames'][1]]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="3"> + <code>$_POST['where_clause']</code> + <code>$_POST['where_clause_sign']</code> + <code>$dataLabel</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="2"> + <code>$_POST['maxPlotLimit']</code> + <code>$_POST['where_clause']</code> + </PossiblyInvalidOperand> <RedundantCastGivenDocblockType occurrences="1"> <code>(int) $fields_meta[$i]->length</code> </RedundantCastGivenDocblockType> </file> <file src="libraries/classes/Controllers/TableController.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$_POST['db']</code> - </MixedArgument> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['db']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/ThemeSetController.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$_POST['set_theme']</code> - </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$preferences['config_data']['ThemeDefault']</code> - </MixedAssignment> + </PossiblyInvalidArgument> </file> <file src="libraries/classes/Controllers/Transformation/OverviewController.php"> <MixedArgument occurrences="1"> @@ -4004,8 +4281,15 @@ </MixedAssignment> </file> <file src="libraries/classes/Controllers/Transformation/WrapperController.php"> - <MixedArgument occurrences="15"> - <code>$_GET['where_clause_sign'] ?? ''</code> + <InvalidArgument occurrences="2"> + <code>$srcHeight / $ratioWidth</code> + <code>$srcWidth / $ratioHeight</code> + </InvalidArgument> + <InvalidOperand occurrences="2"> + <code>$srcHeight</code> + <code>$srcWidth</code> + </InvalidOperand> + <MixedArgument occurrences="12"> <code>$cn ?? ''</code> <code>$db</code> <code>$db</code> @@ -4014,8 +4298,6 @@ <code>$mime_type ?? ''</code> <code>$mime_type ?? ''</code> <code>$option</code> - <code>$srcHeight / $ratioWidth</code> - <code>$srcWidth / $ratioHeight</code> <code>$table</code> <code>$table</code> <code>$table</code> @@ -4033,42 +4315,51 @@ <code>$row[$transform_key]</code> <code>$row[$transform_key]</code> </MixedArrayOffset> - <MixedAssignment occurrences="5"> - <code>$GLOBALS[$one_request_param]</code> + <MixedAssignment occurrences="2"> <code>$mime_type</code> <code>$option</code> - <code>$ratioHeight</code> - <code>$ratioWidth</code> </MixedAssignment> - <MixedOperand occurrences="6"> - <code>$_REQUEST['newHeight']</code> - <code>$_REQUEST['newWidth']</code> + <MixedOperand occurrences="2"> <code>$mime_options['charset'] ?? ''</code> - <code>$ratioHeight</code> - <code>$ratioWidth</code> <code>$where_clause</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="1"> + <code>$_GET['where_clause_sign'] ?? ''</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_GET['where_clause_sign'] ?? ''</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="4"> + <code>$_REQUEST['newHeight']</code> + <code>$_REQUEST['newWidth']</code> + <code>$srcHeight</code> + <code>$srcWidth</code> + </PossiblyInvalidOperand> <PossiblyNullArgument occurrences="2"> <code>$row[$transform_key]</code> <code>$row[$transform_key]</code> </PossiblyNullArgument> </file> <file src="libraries/classes/Controllers/UserPasswordController.php"> - <MixedArgument occurrences="6"> + <MixedArgument occurrences="5"> <code>$change_password_message['msg']</code> <code>$hostname</code> <code>$msg</code> <code>$msg->getDisplay()</code> - <code>$password</code> <code>$username</code> </MixedArgument> - <MixedAssignment occurrences="2"> + <MixedAssignment occurrences="1"> <code>$msg</code> - <code>$password</code> </MixedAssignment> <MixedMethodCall occurrences="1"> <code>getDisplay</code> </MixedMethodCall> + <PossiblyInvalidArgument occurrences="1"> + <code>$password</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$password</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Controllers/VersionCheckController.php"> <MixedArgument occurrences="1"> @@ -4083,18 +4374,7 @@ <DocblockTypeContradiction occurrences="1"> <code>$view['as']</code> </DocblockTypeContradiction> - <MixedArgument occurrences="14"> - <code>$_GET['db']</code> - <code>$_GET['db']</code> - <code>$_GET['table']</code> - <code>$_GET['table']</code> - <code>$_POST['view']['as']</code> - <code>$_POST['view']['column_names']</code> - <code>$_POST['view']['definer']</code> - <code>$_POST['view']['definer']</code> - <code>$_POST['view']['definer']</code> - <code>$_POST['view']['name']</code> - <code>$_POST['view']['name']</code> + <MixedArgument occurrences="3"> <code>$createView</code> <code>$db</code> <code>$db</code> @@ -4102,38 +4382,54 @@ <MixedArgumentTypeCoercion occurrences="1"> <code>['db' => $db]</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="6"> - <code>$_POST['view']['as']</code> - <code>$_POST['view']['as']</code> - <code>$_POST['view']['column_names']</code> - <code>$_POST['view']['column_names']</code> - <code>$_POST['view']['name']</code> - <code>$_POST['view']['name']</code> - </MixedArrayAccess> <MixedArrayAssignment occurrences="4"> <code>$urlParams['back']</code> <code>$urlParams['db']</code> <code>$urlParams['goto']</code> <code>$urlParams['reload']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="9"> + <MixedAssignment occurrences="7"> <code>$createView</code> - <code>$sql_query</code> <code>$urlParams['db']</code> <code>$view['as']</code> <code>$view['as']</code> <code>$view['definer']</code> - <code>$view['name']</code> <code>$view['sql_security']</code> <code>$view['with']</code> </MixedAssignment> - <MixedOperand occurrences="5"> + <PossiblyInvalidArgument occurrences="11"> + <code>$_GET['db']</code> + <code>$_GET['db']</code> + <code>$_GET['table']</code> + <code>$_GET['table']</code> + <code>$_POST['view']['as']</code> + <code>$_POST['view']['column_names']</code> + <code>$_POST['view']['definer']</code> + <code>$_POST['view']['definer']</code> + <code>$_POST['view']['definer']</code> + <code>$_POST['view']['name']</code> + <code>$_POST['view']['name']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="8"> + <code>$_GET['db']</code> + <code>$_GET['db']</code> + <code>$_GET['table']</code> + <code>$_GET['table']</code> + <code>$_POST['view']['as']</code> + <code>$_POST['view']['column_names']</code> + <code>$_POST['view']['definer']</code> + <code>$_POST['view']['name']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="5"> <code>$_POST['view']['algorithm']</code> <code>$_POST['view']['as']</code> <code>$_POST['view']['column_names']</code> <code>$_POST['view']['sql_security']</code> <code>$_POST['view']['with']</code> - </MixedOperand> + </PossiblyInvalidOperand> + <PossiblyUndefinedArrayOffset occurrences="1"> + <code>$_POST['view']</code> + </PossiblyUndefinedArrayOffset> <RedundantCondition occurrences="2"> <code>empty($view['as']) && is_string($createView)</code> <code>is_string($createView)</code> @@ -4143,13 +4439,18 @@ </RedundantConditionGivenDocblockType> </file> <file src="libraries/classes/Controllers/View/OperationsController.php"> - <MixedArgument occurrences="5"> - <code>$_POST['new_name']</code> + <MixedArgument occurrences="4"> <code>$db</code> <code>$sql_query</code> <code>$table</code> <code>$warning_messages</code> </MixedArgument> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['new_name']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['new_name']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Core.php"> <InvalidOperand occurrences="1"> @@ -4161,23 +4462,21 @@ <InvalidReturnType occurrences="1"> <code>int</code> </InvalidReturnType> + <InvalidScalarArgument occurrences="1"> + <code>$post_key</code> + </InvalidScalarArgument> <LoopInvalidation occurrences="4"> <code>$i</code> <code>$i</code> <code>$i</code> <code>$i</code> </LoopInvalidation> - <MixedArgument occurrences="5"> - <code>$GLOBALS[$post_key]</code> + <MixedArgument occurrences="4"> <code>$GLOBALS['cfg']['TrustedProxies'][$direct_ip]</code> <code>$one_post_pattern</code> <code>$path[$depth + 1]</code> <code>$query</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="2"> - <code>$post_key</code> - <code>$post_key</code> - </MixedArgumentTypeCoercion> <MixedArrayAccess occurrences="4"> <code>$a[$key]</code> <code>$path[$depth - 1][$key]</code> @@ -4188,17 +4487,12 @@ <code>$a[$key]</code> <code>$a[$last_key]</code> </MixedArrayAssignment> - <MixedArrayOffset occurrences="1"> - <code>$GLOBALS['cfg']['TrustedProxies'][$direct_ip]</code> - </MixedArrayOffset> - <MixedAssignment occurrences="16"> - <code>$GLOBALS[$post_key]</code> + <MixedAssignment occurrences="14"> <code>$_GET[$urlQueryParamKey]</code> <code>$_POST[$urlQueryParamKey]</code> <code>$_REQUEST[$urlQueryParamKey]</code> <code>$a</code> <code>$a[$last_key]</code> - <code>$direct_ip</code> <code>$one_post_pattern</code> <code>$parsedBody[$urlQueryParamKey]</code> <code>$path[$depth]</code> @@ -4209,9 +4503,8 @@ <code>$urlQueryParamValue</code> <code>$value</code> </MixedAssignment> - <MixedInferredReturnType occurrences="2"> + <MixedInferredReturnType occurrences="1"> <code>bool</code> - <code>string|bool</code> </MixedInferredReturnType> <MixedMethodCall occurrences="2"> <code>addError</code> @@ -4221,10 +4514,19 @@ <code>$secret</code> <code>$secret</code> </MixedOperand> - <MixedReturnStatement occurrences="2"> - <code>$direct_ip</code> + <MixedReturnStatement occurrences="1"> <code>$empty</code> </MixedReturnStatement> + <PossiblyInvalidArgument occurrences="1"> + <code>$post_key</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_ENV[$var_name]</code> + <code>$_SERVER[$var_name]</code> + </PossiblyInvalidCast> + <PossiblyUndefinedArrayOffset occurrences="1"> + <code>$_SERVER['SERVER_NAME']</code> + </PossiblyUndefinedArrayOffset> <RedundantCast occurrences="1"> <code>(string) gmdate(DATE_RFC1123)</code> </RedundantCast> @@ -4235,33 +4537,9 @@ </file> <file src="libraries/classes/CreateAddField.php"> <LessSpecificReturnStatement occurrences="1"/> - <MixedArgument occurrences="37"> - <code>$_POST['after_field']</code> + <MixedArgument occurrences="13"> <code>$_POST['comment']</code> - <code>$_POST['connection']</code> - <code>$_POST['field_attribute'][$i]</code> - <code>$_POST['field_collation'][$i] ?? ''</code> - <code>$_POST['field_comments'][$i] ?? ''</code> - <code>$_POST['field_default_type'][$i]</code> - <code>$_POST['field_default_value'][$i]</code> - <code>$_POST['field_expression'][$i] ?? ''</code> - <code>$_POST['field_extra'][$i] ?? false</code> - <code>$_POST['field_length'][$i]</code> - <code>$_POST['field_name']</code> <code>$_POST['field_name'][$column['col_index']]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$previousField]</code> - <code>$_POST['field_null'][$i] ?? 'NO'</code> - <code>$_POST['field_type'][$i]</code> - <code>$_POST['field_virtuality'][$i] ?? ''</code> - <code>$_POST['fulltext_indexes']</code> - <code>$_POST['indexes']</code> - <code>$_POST['primary_indexes']</code> - <code>$_POST['spatial_indexes']</code> - <code>$_POST['tbl_collation'] ?? ''</code> - <code>$_POST['tbl_storage_engine']</code> - <code>$_POST['unique_indexes']</code> <code>$fieldPrimary[0]</code> <code>$index</code> <code>$index</code> @@ -4277,16 +4555,7 @@ <MixedArgumentTypeCoercion occurrences="1"> <code>$definitions</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="12"> - <code>$_POST['field_attribute'][$i]</code> - <code>$_POST['field_default_type'][$i]</code> - <code>$_POST['field_default_value'][$i]</code> - <code>$_POST['field_length'][$i]</code> - <code>$_POST['field_name'][$column['col_index']]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$i]</code> - <code>$_POST['field_name'][$previousField]</code> - <code>$_POST['field_type'][$i]</code> + <MixedArrayAccess occurrences="3"> <code>$column['col_index']</code> <code>$column['size']</code> <code>$column['size']</code> @@ -4311,13 +4580,7 @@ <code>$partition</code> <code>$subpartition</code> </MixedAssignment> - <MixedOperand occurrences="19"> - <code>$_POST['partition_by']</code> - <code>$_POST['partition_count']</code> - <code>$_POST['partition_expr']</code> - <code>$_POST['subpartition_by']</code> - <code>$_POST['subpartition_count']</code> - <code>$_POST['subpartition_expr']</code> + <MixedOperand occurrences="13"> <code>$column['size']</code> <code>$index['Index_type']</code> <code>$partition['comment']</code> @@ -4335,9 +4598,68 @@ <MoreSpecificReturnType occurrences="1"> <code>array{int, array, array, array, array, array}</code> </MoreSpecificReturnType> - <PossiblyFalseArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="26"> + <code>$_POST['after_field']</code> + <code>$_POST['comment']</code> + <code>$_POST['connection']</code> + <code>$_POST['field_attribute'][$i]</code> + <code>$_POST['field_collation'][$i] ?? ''</code> + <code>$_POST['field_comments'][$i] ?? ''</code> + <code>$_POST['field_default_type'][$i]</code> + <code>$_POST['field_default_value'][$i]</code> + <code>$_POST['field_expression'][$i] ?? ''</code> <code>$_POST['field_extra'][$i] ?? false</code> - </PossiblyFalseArgument> + <code>$_POST['field_length'][$i]</code> + <code>$_POST['field_name']</code> + <code>$_POST['field_name'][$column['col_index']]</code> + <code>$_POST['field_name'][$i]</code> + <code>$_POST['field_name'][$i]</code> + <code>$_POST['field_name'][$previousField]</code> + <code>$_POST['field_null'][$i] ?? 'NO'</code> + <code>$_POST['field_type'][$i]</code> + <code>$_POST['field_virtuality'][$i] ?? ''</code> + <code>$_POST['fulltext_indexes']</code> + <code>$_POST['indexes']</code> + <code>$_POST['primary_indexes']</code> + <code>$_POST['spatial_indexes']</code> + <code>$_POST['tbl_collation'] ?? ''</code> + <code>$_POST['tbl_storage_engine']</code> + <code>$_POST['unique_indexes']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="21"> + <code>$_POST['comment']</code> + <code>$_POST['connection']</code> + <code>$_POST['field_attribute'][$i]</code> + <code>$_POST['field_collation'][$i] ?? ''</code> + <code>$_POST['field_comments'][$i] ?? ''</code> + <code>$_POST['field_default_type'][$i]</code> + <code>$_POST['field_default_value'][$i]</code> + <code>$_POST['field_expression'][$i] ?? ''</code> + <code>$_POST['field_extra'][$i] ?? false</code> + <code>$_POST['field_length'][$i]</code> + <code>$_POST['field_type'][$i]</code> + <code>$_POST['field_virtuality'][$i] ?? ''</code> + <code>$_POST['field_where']</code> + <code>$_POST['field_where']</code> + <code>$_POST['fulltext_indexes']</code> + <code>$_POST['indexes']</code> + <code>$_POST['primary_indexes']</code> + <code>$_POST['spatial_indexes']</code> + <code>$_POST['tbl_collation'] ?? ''</code> + <code>$_POST['tbl_storage_engine']</code> + <code>$_POST['unique_indexes']</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$_POST['partitions']</code> + </PossiblyInvalidIterator> + <PossiblyInvalidOperand occurrences="6"> + <code>$_POST['partition_by']</code> + <code>$_POST['partition_count']</code> + <code>$_POST['partition_expr']</code> + <code>$_POST['subpartition_by']</code> + <code>$_POST['subpartition_count']</code> + <code>$_POST['subpartition_expr']</code> + </PossiblyInvalidOperand> </file> <file src="libraries/classes/Crypto/Crypto.php"> <MixedAssignment occurrences="2"> @@ -4352,7 +4674,7 @@ <InvalidScalarArgument occurrences="1"> <code>$tn_pageNow</code> </InvalidScalarArgument> - <MixedArgument occurrences="59"> + <MixedArgument occurrences="54"> <code>$centralTable</code> <code>$centralTable</code> <code>$centralTable</code> @@ -4378,10 +4700,6 @@ <code>$column['col_name']</code> <code>$column['col_name']</code> <code>$column['col_type']</code> - <code>$db</code> - <code>$db</code> - <code>$db</code> - <code>$db</code> <code>$def['Type']</code> <code>$default</code> <code>$extracted_columnspec['attribute']</code> @@ -4410,7 +4728,6 @@ <code>$table</code> <code>$table</code> <code>$table</code> - <code>$table</code> <code>$type</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> @@ -4456,7 +4773,7 @@ <code>$fields[$table]</code> <code>$fields[$table]</code> </MixedArrayOffset> - <MixedAssignment occurrences="45"> + <MixedAssignment occurrences="43"> <code>$attribute</code> <code>$centralTable</code> <code>$centralTable</code> @@ -4475,7 +4792,6 @@ <code>$columnDefault</code> <code>$columnDefault[$i]</code> <code>$columnExtra[$i]</code> - <code>$db</code> <code>$default</code> <code>$defaultValue</code> <code>$defaultValues[$row_num]</code> @@ -4500,7 +4816,6 @@ <code>$table</code> <code>$table</code> <code>$table</code> - <code>$table</code> <code>$type</code> </MixedAssignment> <MixedInferredReturnType occurrences="1"> @@ -4516,6 +4831,25 @@ <MixedReturnStatement occurrences="1"> <code>$cfgCentralColumns</code> </MixedReturnStatement> + <PossiblyInvalidArgument occurrences="8"> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$table</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="7"> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$db</code> + <code>$table</code> + </PossiblyInvalidCast> <RedundantCast occurrences="3"> <code>(array) $has_list</code> <code>(bool) $GLOBALS['cfg']['Server']['DisableIS']</code> @@ -4593,6 +4927,9 @@ <MixedReturnStatement occurrences="1"> <code>$params</code> </MixedReturnStatement> + <PossiblyInvalidCast occurrences="1"> + <code>$_GET['export_type']</code> + </PossiblyInvalidCast> <RedundantCastGivenDocblockType occurrences="2"> <code>(int) $displayPage</code> <code>(int) $displayPage</code> @@ -4618,11 +4955,7 @@ <code>$value['foreign_field']</code> <code>is_string($one_table['ENGINE']) ? $one_table['ENGINE'] : ''</code> </MixedArgument> - <MixedArrayAccess occurrences="18"> - <code>$_POST['t_db'][$key]</code> - <code>$_POST['t_tbl'][$key]</code> - <code>$_POST['t_x'][$key]</code> - <code>$_POST['t_y'][$key]</code> + <MixedArrayAccess occurrences="14"> <code>$one_key['constraint']</code> <code>$one_key['index_list']</code> <code>$one_key['ref_db_name']</code> @@ -4641,18 +4974,13 @@ <MixedArrayAssignment occurrences="1"> <code>$orig_data[$index]</code> </MixedArrayAssignment> - <MixedArrayOffset occurrences="5"> - <code>$_POST['t_db'][$key]</code> - <code>$_POST['t_tbl'][$key]</code> - <code>$_POST['t_x'][$key]</code> - <code>$_POST['t_y'][$key]</code> + <MixedArrayOffset occurrences="1"> <code>$one_key['ref_index_list'][$index]</code> </MixedArrayOffset> - <MixedAssignment occurrences="11"> + <MixedAssignment occurrences="10"> <code>$DB</code> <code>$TAB</code> <code>$index</code> - <code>$key</code> <code>$one_field</code> <code>$one_key</code> <code>$one_table</code> @@ -4673,6 +5001,27 @@ <MixedReturnStatement occurrences="1"> <code>$page_name[0] ?? null</code> </MixedReturnStatement> + <PossiblyInvalidArgument occurrences="4"> + <code>$DB</code> + <code>$TAB</code> + <code>$_POST['t_x'][$key]</code> + <code>$_POST['t_y'][$key]</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="4"> + <code>$_POST['t_db'][$key]</code> + <code>$_POST['t_tbl'][$key]</code> + <code>$_POST['t_x'][$key]</code> + <code>$_POST['t_y'][$key]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="4"> + <code>$DB</code> + <code>$TAB</code> + <code>$_POST['t_x'][$key]</code> + <code>$_POST['t_y'][$key]</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$_POST['t_h']</code> + </PossiblyInvalidIterator> <PossiblyNullArrayOffset occurrences="2"> <code>$index_array1</code> <code>$index_array2</code> @@ -4685,22 +5034,7 @@ </PossiblyUndefinedArrayOffset> </file> <file src="libraries/classes/Database/Events.php"> - <MixedArgument occurrences="27"> - <code>$_POST['item_comment']</code> - <code>$_POST['item_definer']</code> - <code>$_POST['item_definer']</code> - <code>$_POST['item_ends']</code> - <code>$_POST['item_execute_at']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_original_name']</code> - <code>$_POST['item_original_name']</code> - <code>$_POST['item_starts']</code> - <code>$_REQUEST['item_name']</code> - <code>$_REQUEST['item_name']</code> + <MixedArgument occurrences="11"> <code>$db</code> <code>$db</code> <code>$db</code> @@ -4711,7 +5045,6 @@ <code>$errors</code> <code>$errors</code> <code>$event['name']</code> - <code>$itemName</code> <code>$message</code> </MixedArgument> <MixedArrayAccess occurrences="1"> @@ -4728,11 +5061,9 @@ <code>$errors[]</code> <code>$errors[]</code> </MixedArrayAssignment> - <MixedAssignment occurrences="16"> + <MixedAssignment occurrences="14"> <code>$event</code> - <code>$itemName</code> <code>$item['item_original_name']</code> - <code>$retval[$index]</code> <code>$retval['item_comment']</code> <code>$retval['item_definer']</code> <code>$retval['item_definition']</code> @@ -4749,11 +5080,44 @@ <MixedMethodCall occurrences="1"> <code>isSuccess</code> </MixedMethodCall> - <MixedOperand occurrences="3"> - <code>$_POST['item_definition']</code> - <code>$_POST['item_interval_field']</code> + <MixedOperand occurrences="1"> <code>$string</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="17"> + <code>$_POST['item_comment']</code> + <code>$_POST['item_definer']</code> + <code>$_POST['item_definer']</code> + <code>$_POST['item_ends']</code> + <code>$_POST['item_execute_at']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_starts']</code> + <code>$_REQUEST['item_name']</code> + <code>$_REQUEST['item_name']</code> + <code>$itemName</code> + <code>$itemName</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="10"> + <code>$_POST['item_comment']</code> + <code>$_POST['item_definer']</code> + <code>$_POST['item_ends']</code> + <code>$_POST['item_execute_at']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_starts']</code> + <code>$_REQUEST['item_name']</code> + <code>$itemName</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="2"> + <code>$_POST['item_definition']</code> + <code>$_POST['item_interval_field']</code> + </PossiblyInvalidOperand> <PossiblyNullArgument occurrences="1"> <code>$create_item</code> </PossiblyNullArgument> @@ -4775,9 +5139,15 @@ <DocblockTypeContradiction occurrences="1"> <code>$this->currentSearch->getCriterias() === null</code> </DocblockTypeContradiction> - <MixedArgument occurrences="35"> - <code>$_POST['criteriaColumn'][$colInd]</code> - <code>$_POST['criteriaColumn'][$columnIndex]</code> + <InvalidArgument occurrences="1"> + <code>$sortOrder</code> + </InvalidArgument> + <InvalidPropertyAssignmentValue occurrences="3"> + <code>$this->criteriaTables</code> + <code>$this->criteriaTables</code> + <code>$this->criteriaTables</code> + </InvalidPropertyAssignmentValue> + <MixedArgument occurrences="29"> <code>$column</code> <code>$columns[$columnIndex]</code> <code>$eachColumn['Field']</code> @@ -4791,8 +5161,6 @@ <code>$oneTable</code> <code>$oneTable</code> <code>$oneTable</code> - <code>$selected</code> - <code>$sortOrder</code> <code>$table</code> <code>$table</code> <code>$table</code> @@ -4802,10 +5170,8 @@ <code>$this->formAndOrCols[$lastOrWhere]</code> <code>$this->formAndOrCols[$lastWhere]</code> <code>$this->formCriterions[$newColumnCount]</code> - <code>$tmpAlias</code> <code>$tmpCriteria</code> <code>$tmpCriteria</code> - <code>$tmpOr</code> <code>$unfinalized</code> <code>$uniqueColumns</code> <code>$value</code> @@ -4817,9 +5183,7 @@ <code>$table</code> <code>$table</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="19"> - <code>$_POST['Or' . $rowIndex][$columnIndex]</code> - <code>$_POST['criteriaColumn'][$columnIndex]</code> + <MixedArrayAccess occurrences="17"> <code>$foreigner['foreign_field']</code> <code>$foreigner['foreign_table']</code> <code>$foreigner['foreign_table']</code> @@ -4838,10 +5202,7 @@ <code>$reference['table_name']</code> <code>$reference['table_schema']</code> </MixedArrayAccess> - <MixedArrayAssignment occurrences="1"> - <code>$_POST['criteriaSort'][$colInd]</code> - </MixedArrayAssignment> - <MixedArrayOffset occurrences="19"> + <MixedArrayOffset occurrences="18"> <code>$checkedTables[$table]</code> <code>$checkedTables[$table]</code> <code>$finalized[$foreignTable]</code> @@ -4856,19 +5217,17 @@ <code>$relations[$masterTable]</code> <code>$relations[$oneTable][$foreigner['foreign_table']]</code> <code>$relations[$oneTable][$oneKey['ref_table_name']]</code> - <code>$this->criteriaTables[$eachTable]</code> <code>$this->formAndOrCols[$lastWhere]</code> <code>$tsize[$table]</code> <code>$tsize[$table]</code> <code>$tsize[$table]</code> </MixedArrayOffset> - <MixedAssignment occurrences="51"> + <MixedAssignment occurrences="40"> <code>$GLOBALS[${'cur' . $or}][$newColumnCount]</code> <code>$clause</code> <code>$clause</code> <code>$column</code> <code>$columnReferences</code> - <code>$eachTable</code> <code>$finalized[$foreignTable]</code> <code>$finalized[$masterTable]</code> <code>$foreignData</code> @@ -4894,21 +5253,11 @@ <code>$result</code> <code>$select</code> <code>$selectClauses[]</code> - <code>$selected</code> - <code>$sortOrder</code> <code>$table</code> <code>$table</code> <code>$table</code> <code>$tempSearchTables[]</code> - <code>$this->criteria</code> - <code>$this->criteriaAndOrColumn</code> - <code>$this->criteriaAndOrRow</code> - <code>$this->criteriaRowDelete</code> - <code>$this->criteriaRowInsert</code> - <code>$this->prevCriteria</code> - <code>$tmpAlias</code> <code>$tmpCriteria</code> - <code>$tmpOr</code> <code>$tsize[$table]</code> <code>$uniqueColumns</code> <code>$value</code> @@ -4919,8 +5268,7 @@ <code>array</code> <code>string</code> </MixedInferredReturnType> - <MixedOperand occurrences="12"> - <code>$_POST['Or' . $rowIndex][$columnIndex]</code> + <MixedOperand occurrences="11"> <code>$clause</code> <code>$columns[$columnIndex]</code> <code>$index['Column_name']</code> @@ -4944,8 +5292,30 @@ <NullArgument occurrences="1"> <code>null</code> </NullArgument> - <PossiblyNullArgument occurrences="2"> - <code>$sortOrder</code> + <PossiblyInvalidArgument occurrences="5"> + <code>$_POST['criteriaColumn'][$colInd]</code> + <code>$_POST['criteriaColumn'][$columnIndex]</code> + <code>$selected</code> + <code>$tmpAlias</code> + <code>$tmpOr</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$_POST['criteriaColumn'][$colInd]</code> + <code>$_POST['criteriaColumn'][$columnIndex]</code> + <code>$selected</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> + <code>$_POST['Or' . $rowIndex][$columnIndex]</code> + </PossiblyInvalidOperand> + <PossiblyInvalidPropertyAssignmentValue occurrences="6"> + <code>$_POST['criteria'] ?? array_fill(0, $criteriaColumnCount, '')</code> + <code>$_POST['criteriaAndOrColumn'] ?? array_fill(0, $criteriaColumnCount, '')</code> + <code>$_POST['criteriaAndOrRow'] ?? array_fill(0, $criteriaColumnCount, '')</code> + <code>$_POST['criteriaRowDelete'] ?? array_fill(0, $criteriaColumnCount, '')</code> + <code>$_POST['criteriaRowInsert'] ?? array_fill(0, $criteriaColumnCount, '')</code> + <code>$_POST['prev_criteria'] ?? []</code> + </PossiblyInvalidPropertyAssignmentValue> + <PossiblyNullArgument occurrences="1"> <code>$table</code> </PossiblyNullArgument> <PossiblyNullPropertyAssignmentValue occurrences="1"> @@ -4970,32 +5340,14 @@ </RedundantPropertyInitializationCheck> </file> <file src="libraries/classes/Database/Routines.php"> - <MixedArgument occurrences="78"> - <code>$_GET['item_name']</code> - <code>$_GET['item_name']</code> - <code>$_GET['item_name']</code> - <code>$_GET['item_name']</code> - <code>$_GET['item_name']</code> - <code>$_GET['item_name']</code> - <code>$_GET['item_type']</code> - <code>$_GET['item_type']</code> - <code>$_POST['item_comment']</code> - <code>$_POST['item_isdeterministic']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_original_name']</code> - <code>$_POST['item_original_name']</code> - <code>$_POST['item_original_type']</code> - <code>$_POST['item_original_type']</code> - <code>$_POST['item_returnopts_num']</code> - <code>$_POST['item_returnopts_text']</code> - <code>$_POST['item_type']</code> - <code>$_POST['item_type']</code> - <code>$_REQUEST['item_name']</code> + <InvalidArgument occurrences="2"> + <code>$itemParamDir</code> + <code>$itemParamName</code> + </InvalidArgument> + <InvalidArrayOffset occurrences="1"> + <code>$retval['item_param_dir'][$key]</code> + </InvalidArrayOffset> + <MixedArgument occurrences="46"> <code>$db</code> <code>$db</code> <code>$db</code> @@ -5004,19 +5356,12 @@ <code>$db</code> <code>$db</code> <code>$errors</code> - <code>$itemDefiner</code> - <code>$itemName</code> <code>$itemParamOpsNum[$i]</code> <code>$itemParamOpsText[$i]</code> <code>$itemParamType[$i]</code> <code>$itemParamType[$i]</code> <code>$itemParamType[$i]</code> <code>$itemParamType[$i]</code> - <code>$itemReturnType</code> - <code>$itemReturnType</code> - <code>$itemReturnType</code> - <code>$itemReturnType</code> - <code>$itemType</code> <code>$message</code> <code>$newErrors</code> <code>$routine</code> @@ -5050,18 +5395,13 @@ <code>Util::getSupportedDatatypes()</code> <code>Util::getSupportedDatatypes()</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="6"> - <code>$itemParamDir</code> - <code>$itemParamName</code> + <MixedArgumentTypeCoercion occurrences="4"> <code>$options</code> <code>$options</code> <code>$stmt->return->parameters</code> <code>$value</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="35"> - <code>$_POST['funcs'][$routine['item_param_name'][$i]]</code> - <code>$_POST['funcs'][$routine['item_param_name'][$i]]</code> - <code>$_POST['params'][$routine['item_param_name'][$i]]</code> + <MixedArrayAccess occurrences="32"> <code>$opt['value']</code> <code>$params['dir'][$i]</code> <code>$priv[0]</code> @@ -5095,7 +5435,7 @@ <code>$routine['item_param_type'][$i]</code> <code>$routine['item_param_type'][$routine['item_num_params'] - 1]</code> </MixedArrayAccess> - <MixedArrayAssignment occurrences="20"> + <MixedArrayAssignment occurrences="19"> <code>$errors[]</code> <code>$errors[]</code> <code>$errors[]</code> @@ -5106,7 +5446,6 @@ <code>$errors[]</code> <code>$errors[]</code> <code>$params[$i]['htmlentities'][]</code> - <code>$retval['item_param_dir'][$key]</code> <code>$routine['item_param_dir'][]</code> <code>$routine['item_param_length'][$i]</code> <code>$routine['item_param_length'][]</code> @@ -5117,13 +5456,12 @@ <code>$routine['item_param_opts_text'][]</code> <code>$routine['item_param_type'][]</code> </MixedArrayAssignment> - <MixedArrayOffset occurrences="18"> + <MixedArrayOffset occurrences="17"> <code>$_POST['funcs'][$routine['item_param_name'][$i]]</code> <code>$_POST['funcs'][$routine['item_param_name'][$i]]</code> <code>$_POST['funcs'][$routine['item_param_name'][$i]]</code> <code>$_POST['params'][$routine['item_param_name'][$i]]</code> <code>$_POST['params'][$routine['item_param_name'][$i]]</code> - <code>$retval['item_param_dir'][$key]</code> <code>$routine['item_param_dir'][$i]</code> <code>$routine['item_param_dir'][$routine['item_num_params'] - 1]</code> <code>$routine['item_param_length'][$i]</code> @@ -5137,36 +5475,22 @@ <code>$routine['item_param_type'][$i]</code> <code>$routine['item_param_type'][$routine['item_num_params'] - 1]</code> </MixedArrayOffset> - <MixedAssignment occurrences="42"> + <MixedAssignment occurrences="27"> <code>$i</code> - <code>$itemDefiner</code> - <code>$itemDefinition</code> - <code>$itemName</code> - <code>$itemParamLength</code> - <code>$itemParamName</code> - <code>$itemParamType</code> - <code>$itemReturnType</code> - <code>$itemSecurityType</code> - <code>$itemSqlDataAccess</code> - <code>$itemType</code> - <code>$key</code> <code>$opt</code> <code>$options[]</code> <code>$priv</code> - <code>$retval[$index]</code> <code>$retval['item_comment']</code> <code>$retval['item_definer']</code> <code>$retval['item_name']</code> <code>$retval['item_num_params']</code> <code>$retval['item_param_dir']</code> - <code>$retval['item_param_dir']</code> <code>$retval['item_param_length']</code> <code>$retval['item_param_length_arr']</code> <code>$retval['item_param_name']</code> <code>$retval['item_param_opts_num']</code> <code>$retval['item_param_opts_text']</code> <code>$retval['item_param_type']</code> - <code>$retval['item_returntype']</code> <code>$retval['item_sqldataaccess']</code> <code>$retval['item_type']</code> <code>$routine</code> @@ -5179,25 +5503,15 @@ <code>$value</code> <code>$value</code> <code>$value</code> - <code>$value</code> </MixedAssignment> <MixedMethodCall occurrences="1"> <code>isSuccess</code> </MixedMethodCall> - <MixedOperand occurrences="28"> + <MixedOperand occurrences="19"> <code>$_POST['funcs'][$routine['item_param_name'][$i]]</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_original_name']</code> - <code>$_POST['item_original_type']</code> - <code>$_POST['item_original_type']</code> - <code>$_POST['item_returnlength']</code> - <code>$_POST['item_type']</code> - <code>$itemDefinition</code> <code>$itemParamLength[$i]</code> <code>$itemParamType[$i]</code> <code>$itemParamType[$i]</code> - <code>$itemReturnType</code> - <code>$itemSqlDataAccess</code> <code>$priv[0]</code> <code>$priv[1]</code> <code>$priv[2]</code> @@ -5214,12 +5528,82 @@ <code>$routine['item_num_params']</code> <code>$string</code> </MixedOperand> - <PossiblyNullArgument occurrences="7"> - <code>$create_routine</code> + <PossiblyInvalidArgument occurrences="34"> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_type']</code> + <code>$_GET['item_type']</code> + <code>$_POST['item_comment']</code> + <code>$_POST['item_isdeterministic']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_original_type']</code> + <code>$_POST['item_original_type']</code> + <code>$_POST['item_returnopts_num']</code> + <code>$_POST['item_returnopts_text']</code> + <code>$_POST['item_type']</code> + <code>$_POST['item_type']</code> + <code>$_REQUEST['item_name']</code> + <code>$itemDefiner</code> + <code>$itemDefiner</code> + <code>$itemName</code> <code>$itemReturnType</code> <code>$itemReturnType</code> <code>$itemReturnType</code> <code>$itemReturnType</code> + <code>$itemType</code> + <code>$itemType</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="22"> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_name']</code> + <code>$_GET['item_type']</code> + <code>$_GET['item_type']</code> + <code>$_POST['item_comment']</code> + <code>$_POST['item_isdeterministic']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_original_type']</code> + <code>$_POST['item_returnopts_num']</code> + <code>$_POST['item_returnopts_text']</code> + <code>$_POST['item_type']</code> + <code>$itemDefiner</code> + <code>$itemReturnType</code> + <code>$itemReturnType</code> + <code>$itemReturnType</code> + <code>$itemReturnType</code> + <code>$itemType</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$retval['item_param_dir']</code> + </PossiblyInvalidIterator> + <PossiblyInvalidOperand occurrences="9"> + <code>$_POST['item_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_original_type']</code> + <code>$_POST['item_original_type']</code> + <code>$_POST['item_returnlength']</code> + <code>$_POST['item_type']</code> + <code>$itemDefinition</code> + <code>$itemReturnType</code> + <code>$itemSqlDataAccess</code> + </PossiblyInvalidOperand> + <PossiblyNullArgument occurrences="3"> + <code>$create_routine</code> <code>$mode</code> <code>$routine['item_name']</code> </PossiblyNullArgument> @@ -5257,17 +5641,7 @@ </RedundantPropertyInitializationCheck> </file> <file src="libraries/classes/Database/Triggers.php"> - <MixedArgument occurrences="30"> - <code>$_POST['item_definer']</code> - <code>$_POST['item_definer']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_name']</code> - <code>$_POST['item_original_name']</code> - <code>$_POST['item_table']</code> - <code>$_REQUEST['item_name']</code> - <code>$_REQUEST['item_name']</code> + <MixedArgument occurrences="18"> <code>$create_item</code> <code>$db</code> <code>$db</code> @@ -5280,8 +5654,6 @@ <code>$errors</code> <code>$errors</code> <code>$exportData</code> - <code>$itemName</code> - <code>$itemName</code> <code>$message</code> <code>$table</code> <code>$table</code> @@ -5315,13 +5687,11 @@ <code>$errors[]</code> <code>$errors[]</code> </MixedArrayAssignment> - <MixedAssignment occurrences="20"> + <MixedAssignment occurrences="18"> <code>$create_item</code> <code>$exportData</code> <code>$item</code> - <code>$itemName</code> <code>$item['item_original_name']</code> - <code>$retval[$index]</code> <code>$retval['create']</code> <code>$retval['drop']</code> <code>$retval['item_action_timing']</code> @@ -5340,13 +5710,35 @@ <MixedMethodCall occurrences="1"> <code>isSuccess</code> </MixedMethodCall> - <MixedOperand occurrences="5"> - <code>$_POST['item_definition']</code> - <code>$_POST['item_event']</code> - <code>$_POST['item_timing']</code> + <MixedOperand occurrences="2"> <code>$string</code> <code>$trigger['drop']</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="12"> + <code>$_POST['item_definer']</code> + <code>$_POST['item_definer']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_POST['item_table']</code> + <code>$_REQUEST['item_name']</code> + <code>$_REQUEST['item_name']</code> + <code>$itemName</code> + <code>$itemName</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="4"> + <code>$_POST['item_definer']</code> + <code>$_POST['item_name']</code> + <code>$_POST['item_original_name']</code> + <code>$_REQUEST['item_name']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="3"> + <code>$_POST['item_definition']</code> + <code>$_POST['item_event']</code> + <code>$_POST['item_timing']</code> + </PossiblyInvalidOperand> <PossiblyNullArgument occurrences="1"> <code>$create_item</code> </PossiblyNullArgument> @@ -5376,8 +5768,7 @@ <InvalidReturnType occurrences="1"> <code>int|bool</code> </InvalidReturnType> - <MixedArgument occurrences="51"> - <code>$_SERVER['SCRIPT_NAME']</code> + <MixedArgument occurrences="50"> <code>$a</code> <code>$arrayKeys</code> <code>$b</code> @@ -5582,7 +5973,8 @@ <code>$row['Max_data_length']</code> <code>$row['Rows']</code> </PossiblyNullOperand> - <PossiblyUndefinedArrayOffset occurrences="7"> + <PossiblyUndefinedArrayOffset occurrences="8"> + <code>$_SERVER['SCRIPT_NAME']</code> <code>$databases[$database_name]['SCHEMA_DATA_FREE']</code> <code>$databases[$database_name]['SCHEMA_DATA_LENGTH']</code> <code>$databases[$database_name]['SCHEMA_INDEX_LENGTH']</code> @@ -5890,7 +6282,7 @@ <code>$row[$sortedColumnIndex]</code> <code>$row[$sortedColumnIndex]</code> </MixedArrayTypeCoercion> - <MixedAssignment occurrences="50"> + <MixedAssignment occurrences="46"> <code>$_SESSION['tmpval']['geoOption']</code> <code>$_SESSION['tmpval']['max_rows']</code> <code>$_SESSION['tmpval']['pftext']</code> @@ -5925,15 +6317,11 @@ <code>$oneField</code> <code>$oneKey</code> <code>$query</code> - <code>$query['geoOption']</code> - <code>$query['pftext']</code> - <code>$query['relational_display']</code> <code>$rel</code> <code>$relationalDisplay</code> <code>$rowCount</code> <code>$rowInfo[mb_strtolower($fieldsMeta[$m]->orgname)]</code> <code>$sessionMaxRows</code> - <code>$sessionMaxRows</code> <code>$sqlQuery</code> <code>$sqlQueryAdd</code> <code>$tableCreateTime</code> @@ -6016,6 +6404,9 @@ <code>(string) $fieldsMeta[$i]->name</code> <code>(string) $fieldsMeta[$i]->name</code> </RedundantCastGivenDocblockType> + <RedundantCondition occurrences="1"> + <code>isset($sessionMaxRows)</code> + </RedundantCondition> <RedundantConditionGivenDocblockType occurrences="2"> <code>$firstStatement->order</code> <code>isset($meta->internalMediaType)</code> @@ -6169,43 +6560,49 @@ </MixedAssignment> </file> <file src="libraries/classes/ErrorReport.php"> - <MixedArgument occurrences="6"> - <code>$_POST['url']</code> - <code>$exception['stack']</code> - <code>$exception['url']</code> + <InvalidArrayOffset occurrences="1"> + <code>$exception['uri']</code> + </InvalidArrayOffset> + <MixedArgument occurrences="3"> <code>$level['url']</code> <code>$line</code> <code>$line</code> </MixedArgument> - <MixedArrayAccess occurrences="6"> - <code>$exception['stack']</code> - <code>$exception['url']</code> - <code>$exception['url']</code> + <MixedArrayAccess occurrences="3"> <code>$level['context']</code> <code>$level['url']</code> <code>$level['url']</code> </MixedArrayAccess> - <MixedArrayAssignment occurrences="5"> - <code>$exception['stack']</code> - <code>$exception['uri']</code> - <code>$exception['uri']</code> + <MixedArrayAssignment occurrences="2"> <code>$level['scriptname']</code> <code>$level['uri']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="12"> + <MixedAssignment occurrences="9"> <code>$errorObj</code> - <code>$exception</code> <code>$exception['uri']</code> <code>$exception['uri']</code> <code>$level</code> <code>$level['scriptname']</code> <code>$level['uri']</code> <code>$line</code> - <code>$report['exception']</code> <code>$report['script_name']</code> <code>$report['script_name']</code> - <code>$report['steps']</code> </MixedAssignment> + <MixedStringOffsetAssignment occurrences="1"> + <code>$exception['uri']</code> + </MixedStringOffsetAssignment> + <PossiblyInvalidArgument occurrences="3"> + <code>$_POST['url']</code> + <code>$exception['stack']</code> + <code>$exception['url']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST['url']</code> + <code>$exception['url']</code> + </PossiblyInvalidCast> + <PossiblyUndefinedArrayOffset occurrences="1"> + <code>$_SERVER['HTTP_USER_AGENT']</code> + </PossiblyUndefinedArrayOffset> </file> <file src="libraries/classes/Export.php"> <DocblockTypeContradiction occurrences="1"> @@ -6217,10 +6614,8 @@ <InvalidReturnType occurrences="1"> <code>int</code> </InvalidReturnType> - <MixedArgument occurrences="17"> + <MixedArgument occurrences="15"> <code>$GLOBALS['xkana'] ?? ''</code> - <code>$_POST['db']</code> - <code>$_POST['db']</code> <code>$currentDb</code> <code>$dbAlias</code> <code>$dbAlias</code> @@ -6250,7 +6645,7 @@ <code>$aliases[$dbName]['tables'][$tableName]</code> <code>$aliases[$dbName]['tables'][$tableName]</code> </MixedArrayOffset> - <MixedAssignment occurrences="23"> + <MixedAssignment occurrences="20"> <code>$aliases[$dbName]['alias']</code> <code>$aliases[$dbName]['tables'][$tableName]['alias']</code> <code>$aliases[$dbName]['tables'][$tableName]['columns'][$col]</code> @@ -6263,15 +6658,12 @@ <code>$table</code> <code>$tableName</code> <code>$tbl</code> - <code>$val</code> <code>$val1</code> <code>$val1</code> <code>$val1</code> <code>$val2</code> <code>$val2</code> <code>$val2</code> - <code>$value</code> - <code>$value</code> <code>$view</code> <code>$views[]</code> </MixedAssignment> @@ -6284,18 +6676,29 @@ <code>$tmpSelect</code> <code>$view</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="2"> + <code>$_POST['db']</code> + <code>$_POST['db']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST['db']</code> + <code>$val</code> + </PossiblyInvalidCast> <PossiblyNullArgument occurrences="3"> <code>$GLOBALS['file_handle']</code> <code>$line</code> <code>$line</code> </PossiblyNullArgument> + <RedundantCast occurrences="2"> + <code>(string) $value</code> + <code>(string) $value</code> + </RedundantCast> <RedundantCondition occurrences="1"> <code>mb_strtolower($userExtension) != $requiredExtension</code> </RedundantCondition> </file> <file src="libraries/classes/Export/Options.php"> - <MixedArgument occurrences="2"> - <code>$_POST['filename_template'] ?? null</code> + <MixedArgument occurrences="1"> <code>$currentDb</code> </MixedArgument> <MixedArrayAccess occurrences="1"> @@ -6311,6 +6714,12 @@ <code>getUserValue</code> <code>getUserValue</code> </MixedMethodCall> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['filename_template'] ?? null</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_GET['what']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Export/Template.php"> <MixedArgument occurrences="5"> @@ -6416,21 +6825,17 @@ </TypeDoesNotContainType> </file> <file src="libraries/classes/Footer.php"> + <InvalidArgument occurrences="1"> + <code>$params</code> + </InvalidArgument> <MixedArgument occurrences="2"> <code>$db</code> <code>$table</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="1"> - <code>$params</code> - </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="8"> + <MixedAssignment occurrences="4"> <code>$info</code> - <code>$params['checkprivsdb']</code> - <code>$params['checkprivstable']</code> <code>$params['route']</code> <code>$params['server']</code> - <code>$params['single_table']</code> - <code>$params['viewing_mode']</code> <code>$subObject</code> </MixedAssignment> <MixedReturnTypeCoercion occurrences="2"> @@ -6440,9 +6845,10 @@ <PropertyNotSetInConstructor occurrences="1"> <code>$isAjax</code> </PropertyNotSetInConstructor> - <RedundantCast occurrences="2"> + <RedundantCast occurrences="3"> <code>(string) $GLOBALS['db']</code> <code>(string) $GLOBALS['table']</code> + <code>(string) $_REQUEST['no_history']</code> </RedundantCast> <RedundantCondition occurrences="4"> <code>is_scalar($GLOBALS['db'])</code> @@ -7274,6 +7680,9 @@ <code>$packOffsets[1]</code> <code>json_decode((string) $is_found)</code> </MixedReturnStatement> + <PossiblyInvalidArrayOffset occurrences="1"> + <code>$_SESSION['PMA_VERSION_COMMITDATA_' . $hash]</code> + </PossiblyInvalidArrayOffset> <PossiblyNullArgument occurrences="1"> <code>$gitFolder</code> </PossiblyNullArgument> @@ -7282,10 +7691,9 @@ </PossiblyNullOperand> </file> <file src="libraries/classes/Header.php"> - <MixedArgument occurrences="6"> + <MixedArgument occurrences="5"> <code>$db</code> <code>$db ?? ''</code> - <code>$message</code> <code>$table</code> <code>$table ?? ''</code> <code>$value</code> @@ -7293,16 +7701,21 @@ <MixedArgumentTypeCoercion occurrences="1"> <code>$params</code> </MixedArgumentTypeCoercion> - <MixedAssignment occurrences="5"> + <MixedAssignment occurrences="4"> <code>$GLOBALS['buffer_message']</code> <code>$bufferMessage</code> - <code>$message</code> <code>$pftext</code> <code>$value</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$message</code> + </PossiblyInvalidArgument> <RedundantCondition occurrences="1"> <code>isset($dbi)</code> </RedundantCondition> + <RedundantFunctionCall occurrences="1"> + <code>strtolower</code> + </RedundantFunctionCall> <TypeDoesNotContainNull occurrences="1"> <code>false</code> </TypeDoesNotContainNull> @@ -7388,6 +7801,11 @@ <RedundantCastGivenDocblockType occurrences="1"> <code>(string) $database</code> </RedundantCastGivenDocblockType> + <RiskyCast occurrences="3"> + <code>$_REQUEST['pos']</code> + <code>$_REQUEST['session_max_rows']</code> + <code>$_REQUEST['unlim_num_rows']</code> + </RiskyCast> </file> <file src="libraries/classes/Image/ImageWrapper.php"> <TooFewArguments occurrences="1"> @@ -7395,7 +7813,7 @@ </TooFewArguments> </file> <file src="libraries/classes/Import.php"> - <MixedArgument occurrences="40"> + <MixedArgument occurrences="38"> <code>$active</code> <code>$additionalSql[$i]</code> <code>$additionalSql[$i]</code> @@ -7414,8 +7832,6 @@ <code>$size</code> <code>$size</code> <code>$size</code> - <code>$sqlDelimiter</code> - <code>$sqlQuery</code> <code>$sql_query</code> <code>$table</code> <code>$table[self::COL_NAMES]</code> @@ -7475,7 +7891,7 @@ <MixedArrayOffset occurrences="1"> <code>$typeArray[$analyses[$i][self::TYPES][$j]]</code> </MixedArrayOffset> - <MixedAssignment occurrences="28"> + <MixedAssignment occurrences="25"> <code>$GLOBALS['offset']</code> <code>$active</code> <code>$cellValue</code> @@ -7490,7 +7906,6 @@ <code>$importPlugin</code> <code>$max_sql_len</code> <code>$queries</code> - <code>$queries</code> <code>$read_multiply</code> <code>$size</code> <code>$size</code> @@ -7499,8 +7914,6 @@ <code>$sqlData['valid_queries']</code> <code>$sqlData['valid_queries']</code> <code>$sqlData['valid_sql'][]</code> - <code>$sqlDelimiter</code> - <code>$sqlQuery</code> <code>$sql_query</code> <code>$table</code> <code>$table</code> @@ -7548,13 +7961,17 @@ <code>strpos($lastCumulativeSize, ',')</code> <code>strpos($lastCumulativeSize, ',')</code> </PossiblyFalseOperand> - <PossiblyInvalidArgument occurrences="5"> + <PossiblyInvalidArgument occurrences="6"> <code>$lastCumulativeSize</code> <code>$lastCumulativeSize</code> <code>$lastCumulativeSize</code> <code>$lastCumulativeSize</code> <code>$lastCumulativeSize</code> + <code>$sqlDelimiter</code> </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$sqlDelimiter</code> + </PossiblyInvalidCast> <PossiblyNullArrayAccess occurrences="1"> <code>$additionalSql[$i]</code> </PossiblyNullArrayAccess> @@ -7575,6 +7992,9 @@ <MixedMethodCall occurrences="1"> <code>$_SESSION[$GLOBALS['SESSION_KEY']]['handler']::getUploadStatus($id)</code> </MixedMethodCall> + <PossiblyInvalidArrayOffset occurrences="1"> + <code>$_SESSION[$GLOBALS['SESSION_KEY']]</code> + </PossiblyInvalidArrayOffset> </file> <file src="libraries/classes/Import/SimulateDml.php"> <MixedArgumentTypeCoercion occurrences="2"> @@ -7672,7 +8092,16 @@ </MixedAssignment> </file> <file src="libraries/classes/InsertEdit.php"> - <MixedArgument occurrences="85"> + <InvalidArgument occurrences="1"> + <code>$urlParams</code> + </InvalidArgument> + <InvalidReturnStatement occurrences="1"> + <code>$_POST['err_url']</code> + </InvalidReturnStatement> + <InvalidReturnType occurrences="1"> + <code>string</code> + </InvalidReturnType> + <MixedArgument occurrences="84"> <code>$_POST['fields']['multi_edit']</code> <code>$_POST['fields']['multi_edit'][$rownumber][$key]</code> <code>$backupField</code> @@ -7756,22 +8185,18 @@ <code>$whereClause</code> <code>$whereClause</code> <code>$whereClause</code> - <code>$whereClause</code> <code>min(max($column['len'], 4), $GLOBALS['cfg']['LimitChars'])</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="8"> + <MixedArgumentTypeCoercion occurrences="7"> <code>$keyId</code> <code>$query</code> <code>$queryFields</code> <code>$thisUrlParams</code> <code>$thisUrlParams</code> <code>$urlParams</code> - <code>$urlParams</code> <code>$valueSets</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="8"> - <code>$_POST['fields']['multi_edit']</code> - <code>$_POST['where_clause'][0]</code> + <MixedArrayAccess occurrences="6"> <code>$_SESSION['tmpval']['relational_display']</code> <code>$currCellEditedValues[$columnName]</code> <code>$enumValue['plain']</code> @@ -7813,11 +8238,8 @@ <code>$mimeMap[$tableColumn['Field']]</code> <code>$protectedRow[$multiEditColumnsName[$key]]</code> </MixedArrayOffset> - <MixedAssignment occurrences="38"> - <code>$GLOBALS['cfg']['ShowFieldTypesInDataEditView']</code> - <code>$GLOBALS['cfg']['ShowFunctionFields']</code> + <MixedAssignment occurrences="31"> <code>$_SESSION['edit_next']</code> - <code>$afterInsert</code> <code>$columnMime</code> <code>$column['pma_type']</code> <code>$currCellEditedValues</code> @@ -7834,7 +8256,6 @@ <code>$enumValue</code> <code>$fieldsize</code> <code>$file</code> - <code>$formParams['clause_is_unique']</code> <code>$isUnsigned</code> <code>$maxlength</code> <code>$maxlength</code> @@ -7844,25 +8265,20 @@ <code>$transformedHtml</code> <code>$trueType</code> <code>$type</code> - <code>$urlParams['sql_query']</code> - <code>$whereClause</code> - <code>$whereClause</code> <code>$whereClause</code> <code>$whereClause</code> <code>$whereClause</code> <code>$whereClause</code> <code>$whereClause</code> </MixedAssignment> - <MixedInferredReturnType occurrences="2"> + <MixedInferredReturnType occurrences="1"> <code>int</code> - <code>string</code> </MixedInferredReturnType> <MixedMethodCall occurrences="2"> <code>new $className()</code> <code>new $className()</code> </MixedMethodCall> - <MixedOperand occurrences="8"> - <code>$_POST['where_clause'][0]</code> + <MixedOperand occurrences="7"> <code>$column['pma_type']</code> <code>$file</code> <code>$maxlength</code> @@ -7871,9 +8287,19 @@ <code>$multiEditFuncs[$key]</code> <code>$whereClause</code> </MixedOperand> - <MixedReturnStatement occurrences="2"> - <code>$_POST['err_url']</code> - </MixedReturnStatement> + <MixedReturnStatement occurrences="1"/> + <PossiblyInvalidArgument occurrences="1"> + <code>$whereClause</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="1"> + <code>$_POST['fields']['multi_edit']</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="1"> + <code>$whereClause</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> + <code>$_POST['where_clause'][0]</code> + </PossiblyInvalidOperand> <PossiblyNullArgument occurrences="2"> <code>$newValue</code> <code>$newValue</code> @@ -7903,11 +8329,9 @@ <MissingConstructor occurrences="1"> <code>$availableLocales</code> </MissingConstructor> - <MixedArgument occurrences="5"> + <MixedArgument occurrences="3"> <code>$GLOBALS['config']->get('Lang')</code> <code>$GLOBALS['config']->getCookie('pma_lang')</code> - <code>$_GET['lang']</code> - <code>$_POST['lang']</code> <code>$lang</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="2"> @@ -7939,6 +8363,14 @@ <code>Language[]</code> <code>Language[]</code> </MixedReturnTypeCoercion> + <PossiblyInvalidArgument occurrences="2"> + <code>$_GET['lang']</code> + <code>$_POST['lang']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_GET['lang']</code> + <code>$_POST['lang']</code> + </PossiblyInvalidCast> <PossiblyNullArgument occurrences="2"> <code>$GLOBALS['config']->get('Lang')</code> <code>$GLOBALS['config']->getCookie('pma_lang')</code> @@ -8084,11 +8516,13 @@ <code>''</code> <code>isset($this->pos)</code> </DocblockTypeContradiction> - <MixedArgument occurrences="34"> - <code>$_POST['aPath']</code> - <code>$_POST['n' . $count . '_aPath']</code> - <code>$_POST['n' . $count . '_vPath']</code> - <code>$_POST['vPath']</code> + <InvalidPropertyAssignmentValue occurrences="4"> + <code>$this->pos2Name</code> + <code>$this->pos2Name</code> + <code>$this->pos3Name</code> + <code>$this->pos3Name</code> + </InvalidPropertyAssignmentValue> + <MixedArgument occurrences="30"> <code>$container->children</code> <code>$container->realName</code> <code>$db</code> @@ -8136,7 +8570,7 @@ <MixedArrayOffset occurrences="1"> <code>$hiddenCounts[$db]</code> </MixedArrayOffset> - <MixedAssignment occurrences="17"> + <MixedAssignment occurrences="15"> <code>$container</code> <code>$db</code> <code>$item</code> @@ -8150,8 +8584,6 @@ <code>$separator</code> <code>$separator</code> <code>$table</code> - <code>$this->searchClause</code> - <code>$this->searchClause2</code> <code>$urlParams['pos3_name']</code> <code>$value</code> </MixedAssignment> @@ -8178,12 +8610,6 @@ <code>$container->realName</code> <code>$container->realName</code> </MixedPropertyFetch> - <MixedPropertyTypeCoercion occurrences="4"> - <code>$this->pos2Name</code> - <code>$this->pos2Name</code> - <code>$this->pos3Name</code> - <code>$this->pos3Name</code> - </MixedPropertyTypeCoercion> <MixedReturnStatement occurrences="2"> <code>$retval</code> <code>$retval</code> @@ -8195,6 +8621,22 @@ <PossiblyFalseReference occurrences="1"> <code>getPresence</code> </PossiblyFalseReference> + <PossiblyInvalidArgument occurrences="4"> + <code>$_POST['aPath']</code> + <code>$_POST['n' . $count . '_aPath']</code> + <code>$_POST['n' . $count . '_vPath']</code> + <code>$_POST['vPath']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="4"> + <code>$_POST['aPath']</code> + <code>$_POST['n' . $count . '_aPath']</code> + <code>$_POST['n' . $count . '_vPath']</code> + <code>$_POST['vPath']</code> + </PossiblyInvalidCast> + <PossiblyInvalidPropertyAssignmentValue occurrences="2"> + <code>$_POST['searchClause']</code> + <code>$_POST['searchClause2']</code> + </PossiblyInvalidPropertyAssignmentValue> <PossiblyNullArgument occurrences="3"> <code>$container->realName</code> <code>$database</code> @@ -8225,6 +8667,14 @@ <RedundantConditionGivenDocblockType occurrences="1"> <code>$node->title</code> </RedundantConditionGivenDocblockType> + <RiskyCast occurrences="6"> + <code>$_GET['pos']</code> + <code>$_POST['n' . $count . '_pos2_value']</code> + <code>$_POST['n' . $count . '_pos3_value']</code> + <code>$_POST['pos']</code> + <code>$_POST['pos2_value'] ?? 0</code> + <code>$_POST['pos3_value']</code> + </RiskyCast> </file> <file src="libraries/classes/Navigation/NodeFactory.php"> <MixedMethodCall occurrences="1"> @@ -8574,23 +9024,7 @@ </InvalidReturnType> </file> <file src="libraries/classes/Operations.php"> - <MixedArgument occurrences="44"> - <code>$_POST['comment']</code> - <code>$_POST['db_collation'] ?? ''</code> - <code>$_POST['new_auto_increment']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['newname']</code> - <code>$_POST['prev_comment']</code> - <code>$_POST['tbl_collation'] ?? ''</code> - <code>$_POST['what']</code> + <MixedArgument occurrences="25"> <code>$arr['foreign_db']</code> <code>$arr['foreign_db']</code> <code>$arr['foreign_db']</code> @@ -8604,8 +9038,6 @@ <code>$foreignTable</code> <code>$foreignTable</code> <code>$function_name</code> - <code>$newRowFormat</code> - <code>$newRowFormat</code> <code>$old_priv</code> <code>$one_query</code> <code>$procedure_name</code> @@ -8615,7 +9047,6 @@ <code>$table</code> <code>$table</code> <code>$table</code> - <code>$this_what ?? 'data'</code> <code>$trigger['create']</code> <code>$view</code> <code>$view</code> @@ -8676,12 +9107,11 @@ <code>$trigger['create']</code> <code>$trigger['create']</code> </MixedArrayAccess> - <MixedAssignment occurrences="16"> + <MixedAssignment occurrences="14"> <code>$arr</code> <code>$event_name</code> <code>$foreignTable</code> <code>$function_name</code> - <code>$newRowFormat</code> <code>$old_priv</code> <code>$old_priv</code> <code>$old_priv</code> @@ -8690,15 +9120,13 @@ <code>$old_priv</code> <code>$one_query</code> <code>$procedure_name</code> - <code>$this_what</code> <code>$trigger</code> <code>$view</code> </MixedAssignment> <MixedMethodCall occurrences="1"> <code>build</code> </MixedMethodCall> - <MixedOperand occurrences="36"> - <code>$_POST['new_pack_keys']</code> + <MixedOperand occurrences="35"> <code>$old_priv[$i]</code> <code>$old_priv[0]</code> <code>$old_priv[0]</code> @@ -8735,15 +9163,63 @@ <code>$table</code> <code>$trigger['create']</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="19"> + <code>$_POST['comment']</code> + <code>$_POST['db_collation'] ?? ''</code> + <code>$_POST['new_auto_increment']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['newname']</code> + <code>$_POST['prev_comment']</code> + <code>$_POST['tbl_collation'] ?? ''</code> + <code>$_POST['what']</code> + <code>$newRowFormat</code> + <code>$newRowFormat</code> + <code>$this_what ?? 'data'</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="9"> + <code>$_POST['comment']</code> + <code>$_POST['db_collation'] ?? ''</code> + <code>$_POST['new_auto_increment']</code> + <code>$_POST['prev_comment']</code> + <code>$_POST['tbl_collation'] ?? ''</code> + <code>$_POST['what']</code> + <code>$newRowFormat</code> + <code>$newRowFormat</code> + <code>$this_what ?? 'data'</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> + <code>$_POST['new_pack_keys']</code> + </PossiblyInvalidOperand> <PossiblyNullArgument occurrences="1"> <code>$tmp_query</code> </PossiblyNullArgument> <PossiblyNullOperand occurrences="1"> <code>$tmp_query</code> </PossiblyNullOperand> + <RedundantCast occurrences="5"> + <code>(string) $_POST['new_name']</code> + <code>(string) $_POST['new_name']</code> + <code>(string) $_POST['new_name']</code> + <code>(string) $_POST['new_name']</code> + <code>(string) $_POST['new_name']</code> + </RedundantCast> <RedundantCastGivenDocblockType occurrences="1"> <code>(string) $pack_keys</code> </RedundantCastGivenDocblockType> + <RedundantCondition occurrences="1"> + <code>$this_what</code> + </RedundantCondition> + <TypeDoesNotContainNull occurrences="1"> + <code>'data'</code> + </TypeDoesNotContainNull> </file> <file src="libraries/classes/OutputBuffering.php"> <DocblockTypeContradiction occurrences="1"> @@ -8838,21 +9314,7 @@ </MixedAssignment> </file> <file src="libraries/classes/Partitioning/TablePartitionDefinition.php"> - <MixedArgument occurrences="4"> - <code>$partitionCount</code> - <code>$partitions</code> - <code>$subpartitionCount</code> - <code>$subpartitions</code> - </MixedArgument> - <MixedArrayAccess occurrences="6"> - <code>$partition['name']</code> - <code>$partition['subpartition_count']</code> - <code>$partition['subpartitions']</code> - <code>$partition['subpartitions']</code> - <code>$partitions[$i]</code> - <code>$subpartitions[$j]</code> - </MixedArrayAccess> - <MixedArrayAssignment occurrences="16"> + <InvalidArrayOffset occurrences="13"> <code>$partition['comment']</code> <code>$partition['data_directory']</code> <code>$partition['engine']</code> @@ -8866,22 +9328,37 @@ <code>$partition['tablespace']</code> <code>$partition['value']</code> <code>$partition['value_type']</code> - <code>$partitions[$i]</code> + </InvalidArrayOffset> + <MixedArgument occurrences="3"> + <code>$partitionCount</code> + <code>$subpartitionCount</code> + <code>$subpartitions</code> + </MixedArgument> + <MixedArrayAccess occurrences="1"> + <code>$subpartitions[$j]</code> + </MixedArrayAccess> + <MixedArrayAssignment occurrences="2"> <code>$subpartitions[$j]</code> <code>$subpartitions[$j]</code> </MixedArrayAssignment> - <MixedAssignment occurrences="7"> - <code>$partition</code> + <MixedAssignment occurrences="4"> <code>$partitionCount</code> - <code>$partitionDetails['partitions']</code> <code>$partition['subpartition_count']</code> - <code>$partitions</code> <code>$subpartitionCount</code> <code>$subpartitions</code> </MixedAssignment> <MixedOperand occurrences="1"> <code>$partition['name']</code> </MixedOperand> + <MixedStringOffsetAssignment occurrences="1"> + <code>$partition['subpartition_count']</code> + </MixedStringOffsetAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$partitions</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="1"> + <code>$partition['name']</code> + </PossiblyInvalidArrayOffset> </file> <file src="libraries/classes/Pdf.php"> <MixedArgument occurrences="4"> @@ -8922,9 +9399,7 @@ <code>self::getPlugins('Import')</code> <code>self::getPlugins('Schema')</code> </LessSpecificReturnStatement> - <MixedArgument occurrences="14"> - <code>$_GET[$opt]</code> - <code>$_REQUEST[$opt]</code> + <MixedArgument occurrences="12"> <code>$doc</code> <code>$doc</code> <code>$doc[0]</code> @@ -8963,7 +9438,9 @@ <code>ImportPlugin[]</code> <code>SchemaPlugin[]</code> </MoreSpecificReturnType> - <PossiblyInvalidArgument occurrences="2"> + <PossiblyInvalidArgument occurrences="4"> + <code>$_GET[$opt]</code> + <code>$_REQUEST[$opt]</code> <code>$val</code> <code>$val</code> </PossiblyInvalidArgument> @@ -9016,22 +9493,15 @@ <InvalidScalarArgument occurrences="1"> <code>Core::getIp()</code> </InvalidScalarArgument> - <MixedArgument occurrences="15"> + <MixedArgument occurrences="8"> <code>$GLOBALS['cfg']['CaptchaLoginPrivateKey']</code> <code>$GLOBALS['cfg']['CaptchaLoginPrivateKey']</code> <code>$GLOBALS['cfg']['CaptchaLoginPrivateKey']</code> - <code>$_POST[$GLOBALS['cfg']['CaptchaResponseParam']]</code> - <code>$_POST['pma_username']</code> - <code>$_POST['pma_username']</code> - <code>$_REQUEST['pma_servername']</code> - <code>$_REQUEST['pma_servername']</code> <code>$captchaSiteVerifyURL</code> <code>$captchaSiteVerifyURL</code> <code>$captchaSiteVerifyURL</code> - <code>$password</code> <code>$serverCookie</code> <code>$serverCookie</code> - <code>$tmp_host</code> </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$url_params</code> @@ -9042,17 +9512,15 @@ <MixedArrayOffset occurrences="1"> <code>$_SESSION['browser_access_time'][$key]</code> </MixedArrayOffset> - <MixedAssignment occurrences="12"> + <MixedAssignment occurrences="10"> <code>$GLOBALS['pma_auth_server']</code> <code>$_form_params['route']</code> <code>$captchaSiteVerifyURL</code> <code>$captchaSiteVerifyURL</code> <code>$key</code> - <code>$password</code> <code>$serverCookie</code> <code>$serverCookie</code> <code>$this->password</code> - <code>$tmp_host</code> <code>$url_params['route']</code> <code>$value</code> </MixedAssignment> @@ -9064,31 +9532,52 @@ <code>removeCookie</code> <code>removeCookie</code> </MixedMethodCall> + <PossiblyInvalidArgument occurrences="7"> + <code>$_POST[$GLOBALS['cfg']['CaptchaResponseParam']]</code> + <code>$_POST['pma_username']</code> + <code>$_POST['pma_username']</code> + <code>$_REQUEST['pma_servername']</code> + <code>$_REQUEST['pma_servername']</code> + <code>$password</code> + <code>$tmp_host</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="5"> + <code>$_POST[$GLOBALS['cfg']['CaptchaResponseParam']]</code> + <code>$_POST['pma_username']</code> + <code>$_REQUEST['pma_servername']</code> + <code>$_REQUEST['pma_servername']</code> + <code>$tmp_host</code> + </PossiblyInvalidCast> + <PossiblyInvalidPropertyAssignmentValue occurrences="1"> + <code>$password</code> + </PossiblyInvalidPropertyAssignmentValue> <RedundantCast occurrences="2"> <code>(int) $GLOBALS['cfg']['LoginCookieStore']</code> <code>(string) $conn_error</code> </RedundantCast> </file> <file src="libraries/classes/Plugins/Auth/AuthenticationHttp.php"> - <MixedArgument occurrences="3"> - <code>$old_usr</code> + <MixedArgument occurrences="2"> <code>$realm_message</code> <code>$this->user</code> </MixedArgument> - <MixedAssignment occurrences="4"> - <code>$old_usr</code> + <MixedAssignment occurrences="3"> <code>$realm_message</code> <code>$this->password</code> <code>$this->user</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$old_usr</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$old_usr</code> + </PossiblyInvalidCast> <RedundantCondition occurrences="1"> <code>isset($this->user)</code> </RedundantCondition> </file> <file src="libraries/classes/Plugins/Auth/AuthenticationSignon.php"> - <MixedArgument occurrences="8"> - <code>$_COOKIE[$session_name]</code> - <code>$_COOKIE[$session_name]</code> + <MixedArgument occurrences="6"> <code>$sessionCookieParams['domain']</code> <code>$sessionCookieParams['httponly']</code> <code>$sessionCookieParams['lifetime']</code> @@ -9128,6 +9617,9 @@ <MixedMethodCall occurrences="1"> <code>issetCookie</code> </MixedMethodCall> + <PossiblyInvalidCast occurrences="1"> + <code>$_REQUEST['guid']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Plugins/Export/ExportCodegen.php"> <PossiblyNullArgument occurrences="4"> @@ -9461,14 +9953,14 @@ <MixedArgument occurrences="1"> <code>$pdf->getPDFData()</code> </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$this->pdfReportTitle</code> - </MixedAssignment> <ParamNameMismatch occurrences="3"> <code>$do_comments</code> <code>$do_mime</code> <code>$do_relation</code> </ParamNameMismatch> + <PossiblyInvalidPropertyAssignmentValue occurrences="1"> + <code>$_POST['pdf_report_title']</code> + </PossiblyInvalidPropertyAssignmentValue> <PropertyNotSetInConstructor occurrences="1"> <code>$pdf</code> </PropertyNotSetInConstructor> @@ -10197,9 +10689,13 @@ <code>$nameArray === false</code> <code>$nameArray === false</code> </DocblockTypeContradiction> - <MixedArgument occurrences="17"> - <code>$_REQUEST['csv_new_db_name']</code> + <InvalidReturnStatement occurrences="1"> <code>$_REQUEST['csv_new_tbl_name']</code> + </InvalidReturnStatement> + <InvalidReturnType occurrences="1"> + <code>string</code> + </InvalidReturnType> + <MixedArgument occurrences="14"> <code>$col_name</code> <code>$columnNames</code> <code>$csv_columns</code> @@ -10212,7 +10708,6 @@ <code>$field['Field']</code> <code>$import_file_name</code> <code>$message->getMessage()</code> - <code>$newDb</code> <code>$options</code> <code>$table</code> </MixedArgument> @@ -10230,37 +10725,42 @@ <MixedArrayOffset occurrences="1"> <code>$columnNames[$key]</code> </MixedArrayOffset> - <MixedAssignment occurrences="10"> + <MixedAssignment occurrences="6"> <code>$col_name</code> <code>$columnNames</code> <code>$field</code> <code>$fields[]</code> <code>$key</code> - <code>$max_lines</code> - <code>$max_lines_constraint</code> - <code>$max_lines_constraint</code> - <code>$newDb</code> <code>$sql</code> </MixedAssignment> - <MixedInferredReturnType occurrences="2"> + <MixedInferredReturnType occurrences="1"> <code>array</code> - <code>string</code> </MixedInferredReturnType> <MixedMethodCall occurrences="1"> <code>getMessage</code> </MixedMethodCall> - <MixedOperand occurrences="6"> - <code>$max_lines</code> - <code>$max_lines_constraint</code> + <MixedOperand occurrences="4"> <code>$sql</code> <code>$sql</code> <code>$sql</code> <code>$sql</code> </MixedOperand> - <MixedReturnStatement occurrences="2"> - <code>$_REQUEST['csv_new_tbl_name']</code> + <MixedReturnStatement occurrences="1"> <code>$columnNames</code> </MixedReturnStatement> + <PossiblyInvalidArgument occurrences="3"> + <code>$_REQUEST['csv_new_db_name']</code> + <code>$_REQUEST['csv_new_tbl_name']</code> + <code>$newDb</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$newDb</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="3"> + <code>$max_lines</code> + <code>$max_lines_constraint++</code> + <code>1</code> + </PossiblyInvalidOperand> <PossiblyNullOperand occurrences="1"> <code>$ch</code> </PossiblyNullOperand> @@ -10429,9 +10929,6 @@ </UnusedVariable> </file> <file src="libraries/classes/Plugins/Import/ImportSql.php"> - <MixedArgument occurrences="1"> - <code>$_POST['sql_delimiter']</code> - </MixedArgument> <MixedArgumentTypeCoercion occurrences="1"> <code>$sql_modes</code> </MixedArgumentTypeCoercion> @@ -10443,6 +10940,12 @@ <code>$val</code> <code>$values[$val]</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['sql_delimiter']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['sql_delimiter']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Plugins/Import/ImportXml.php"> <MixedArgument occurrences="3"> @@ -10616,6 +11119,10 @@ <code>$this->diagram</code> <code>$this->diagram</code> </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_REQUEST['dia_orientation']</code> + <code>$_REQUEST['dia_paper']</code> + </PossiblyInvalidCast> <PossiblyNullReference occurrences="2"> <code>endDiaDoc</code> <code>startDiaDoc</code> @@ -10703,6 +11210,9 @@ <code>$this->diagram</code> <code>$this->diagram</code> </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_REQUEST['eps_orientation']</code> + </PossiblyInvalidCast> <PossiblyNullReference occurrences="12"> <code>endEpsDoc</code> <code>getFont</code> @@ -10781,9 +11291,21 @@ <MixedAssignment occurrences="1"> <code>$table</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$table</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$table</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="1"> + <code>$_POST['t_tbl']</code> + </PossiblyInvalidIterator> <PossiblyNullOperand occurrences="1"> <code>$_name_row[0]</code> </PossiblyNullOperand> + <RiskyCast occurrences="1"> + <code>$_REQUEST['page_number']</code> + </RiskyCast> </file> <file src="libraries/classes/Plugins/Schema/Pdf/Pdf.php"> <MixedArgument occurrences="12"> @@ -10843,8 +11365,7 @@ <code>$this->diagram->PageNo()</code> <code>$this->diagram->PageNo()</code> </InvalidScalarArgument> - <MixedArgument occurrences="25"> - <code>$_REQUEST['pdf_table_order']</code> + <MixedArgument occurrences="24"> <code>$field_name</code> <code>$field_name</code> <code>$mime_map[$field_name]['mimetype']</code> @@ -10951,12 +11472,18 @@ <code>null</code> <code>null</code> </NullArgument> - <PossiblyInvalidArgument occurrences="4"> + <PossiblyInvalidArgument occurrences="5"> + <code>$_REQUEST['pdf_table_order']</code> <code>$this->diagram</code> <code>$this->diagram</code> <code>$this->diagram</code> <code>$this->diagram</code> </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="3"> + <code>$_REQUEST['pdf_orientation']</code> + <code>$_REQUEST['pdf_paper']</code> + <code>$_REQUEST['pdf_table_order']</code> + </PossiblyInvalidCast> <PossiblyNullArgument occurrences="1"> <code>$this->diagram->customLinks['RT']['-']</code> </PossiblyNullArgument> @@ -11284,12 +11811,12 @@ <code>$_POST['t_db'][$key]</code> <code>$_POST['t_tbl'][$key]</code> </MixedArgument> - <MixedArrayAccess occurrences="4"> + <PossiblyInvalidArrayOffset occurrences="4"> <code>$_POST['t_db'][$key]</code> <code>$_POST['t_tbl'][$key]</code> <code>$_POST['t_x'][$key]</code> <code>$_POST['t_y'][$key]</code> - </MixedArrayAccess> + </PossiblyInvalidArrayOffset> </file> <file src="libraries/classes/Plugins/Transformations/Abs/Bool2TextTransformationsPlugin.php"> <MixedArgumentTypeCoercion occurrences="1"> @@ -11483,8 +12010,7 @@ </InvalidArgument> </file> <file src="libraries/classes/Plugins/TwoFactor/Application.php"> - <MixedArgument occurrences="3"> - <code>$_POST['2fa_code']</code> + <MixedArgument occurrences="2"> <code>$secret</code> <code>$this->twofactor->config['settings']['secret']</code> </MixedArgument> @@ -11499,11 +12025,15 @@ <MixedAssignment occurrences="1"> <code>$secret</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['2fa_code']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> + <code>$_POST['2fa_code']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Plugins/TwoFactor/Key.php"> - <MixedArgument occurrences="4"> - <code>$_POST['u2f_authentication_response']</code> - <code>$_POST['u2f_registration_response']</code> + <MixedArgument occurrences="2"> <code>$_SESSION['authenticationRequest']</code> <code>$_SESSION['registrationRequest']</code> </MixedArgument> @@ -11531,6 +12061,14 @@ <code>$data</code> <code>$index</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="2"> + <code>$_POST['u2f_authentication_response']</code> + <code>$_POST['u2f_registration_response']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST['u2f_authentication_response']</code> + <code>$_POST['u2f_registration_response']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Plugins/TwoFactorPlugin.php"> <MixedArgument occurrences="1"> @@ -11775,15 +12313,7 @@ </PossiblyNullArgument> </file> <file src="libraries/classes/ReplicationGui.php"> - <MixedArgument occurrences="14"> - <code>$_POST['hostname']</code> - <code>$_POST['hostname']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['primary_connection'] ?? null</code> - <code>$_POST['sr_replica_action']</code> - <code>$_POST['text_port']</code> - <code>$_POST['username']</code> - <code>$_POST['username']</code> + <MixedArgument occurrences="6"> <code>$database</code> <code>$errorMessage</code> <code>$serverReplicationVariable</code> @@ -11825,8 +12355,7 @@ <code>$_SESSION['replication']['sr_action_status']</code> <code>$_SESSION['replication']['sr_action_status']</code> </MixedArrayAssignment> - <MixedAssignment occurrences="7"> - <code>$count</code> + <MixedAssignment occurrences="6"> <code>$database</code> <code>$errorMessage</code> <code>$linkToPrimary</code> @@ -11834,13 +12363,31 @@ <code>$successMessage</code> <code>$username</code> </MixedAssignment> - <MixedOperand occurrences="2"> - <code>$_POST['sr_skip_errors_count']</code> - <code>$count</code> - </MixedOperand> <PossiblyFalseOperand occurrences="1"> <code>mb_strrpos($currentUser, '@')</code> </PossiblyFalseOperand> + <PossiblyInvalidArgument occurrences="8"> + <code>$_POST['hostname']</code> + <code>$_POST['hostname']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['primary_connection'] ?? null</code> + <code>$_POST['sr_replica_action']</code> + <code>$_POST['text_port']</code> + <code>$_POST['username']</code> + <code>$_POST['username']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="6"> + <code>$_POST['hostname']</code> + <code>$_POST['hostname']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['sr_replica_action']</code> + <code>$_POST['text_port']</code> + <code>$_POST['username']</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="2"> + <code>$_POST['sr_skip_errors_count']</code> + <code>1</code> + </PossiblyInvalidOperand> <UnusedFunctionCall occurrences="2"> <code>strtok</code> <code>strtok</code> @@ -11914,6 +12461,9 @@ <RedundantCondition occurrences="1"> <code>$GLOBALS['config'] !== null</code> </RedundantCondition> + <TypeDoesNotContainType occurrences="1"> + <code>isset($_COOKIE[$key]) && ! is_string($_COOKIE[$key])</code> + </TypeDoesNotContainType> </file> <file src="libraries/classes/SavedSearches.php"> <MixedArgument occurrences="1"> @@ -11978,46 +12528,18 @@ <InvalidReturnType occurrences="1"> <code>array</code> </InvalidReturnType> - <MixedArgument occurrences="70"> + <MixedArgument occurrences="42"> <code>$GLOBALS['dbname']</code> - <code>$_GET['initial']</code> - <code>$_GET['initial']</code> - <code>$_GET['username']</code> - <code>$_POST['authentication_plugin']</code> - <code>$_POST['authentication_plugin']</code> - <code>$_POST['authentication_plugin']</code> - <code>$_POST['old_hostname']</code> - <code>$_POST['old_hostname']</code> - <code>$_POST['old_username']</code> - <code>$_POST['old_username']</code> - <code>$_POST['old_username']</code> - <code>$_POST['old_username']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['userGroup']</code> - <code>$_POST['username']</code> <code>$alterRealSqlQuery</code> <code>$alterSqlQuery</code> - <code>$arr['ssl_cipher']</code> - <code>$arr['x509_issuer']</code> - <code>$arr['x509_subject']</code> <code>$createUserReal</code> <code>$currentDb</code> - <code>$eachUser</code> <code>$exportUser</code> <code>$exportUser</code> <code>$exportUser</code> <code>$exportUser</code> - <code>$hashedPassword</code> <code>$hostname</code> <code>$hostname</code> - <code>$oldUserGroup</code> <code>$paramDbName</code> <code>$paramDbName</code> <code>$paramRoutineName</code> @@ -12133,28 +12655,24 @@ <code>$specificPrivileges[$grant[0]]</code> <code>$specificPrivileges[$grant[0]]</code> </MixedArrayOffset> - <MixedAssignment occurrences="60"> + <MixedAssignment occurrences="54"> <code>$GLOBALS[$key]</code> <code>$account</code> <code>$authenticationPlugin</code> <code>$authenticationPlugin</code> <code>$authenticationPlugin</code> - <code>$authenticationPlugin</code> <code>$currentDb</code> <code>$currentGrant</code> <code>$databases[]</code> - <code>$eachUser</code> <code>$exportUser</code> <code>$extraData['db_wildcard_privs']</code> <code>$foundRows[]</code> <code>$grant</code> - <code>$hashedPassword</code> <code>$host</code> <code>$hostnameLength</code> <code>$name</code> <code>$name</code> <code>$name</code> - <code>$oldUserGroup</code> <code>$oneGrant</code> <code>$onePrivilege['name']</code> <code>$origValue</code> @@ -12163,7 +12681,6 @@ <code>$paramTableName</code> <code>$password</code> <code>$predDbArray</code> - <code>$predUsername</code> <code>$privilege</code> <code>$privilege['routine']</code> <code>$privilege['table']</code> @@ -12186,7 +12703,6 @@ <code>$row['password']</code> <code>$row['password']</code> <code>$row['password']</code> - <code>$selectedUsr</code> <code>$sqlQuery</code> <code>$sqlQuery</code> <code>$user</code> @@ -12200,14 +12716,7 @@ <code>string</code> <code>string</code> </MixedInferredReturnType> - <MixedOperand occurrences="21"> - <code>$_POST['authentication_plugin']</code> - <code>$_POST['authentication_plugin']</code> - <code>$_POST['old_hostname']</code> - <code>$_POST['old_username']</code> - <code>$authenticationPlugin</code> - <code>$authenticationPlugin</code> - <code>$authenticationPlugin</code> + <MixedOperand occurrences="13"> <code>$createUserShow</code> <code>$currentGrant[0]</code> <code>$currentGrant[0]</code> @@ -12216,7 +12725,6 @@ <code>$currentGrant[1]</code> <code>$currentGrant[2]</code> <code>$currentGrant[2]</code> - <code>$dbAndTable[$key]</code> <code>$oneGrant</code> <code>$origValue</code> <code>$privilege['Host']</code> @@ -12244,19 +12752,82 @@ <code>mb_strrpos($currentUserName, '@')</code> <code>mb_strrpos($exportUser, ';')</code> </PossiblyFalseOperand> - <PossiblyInvalidArgument occurrences="5"> + <PossiblyInvalidArgument occurrences="33"> <code>$GLOBALS[$currentGrant[0]]</code> <code>$GLOBALS[$currentGrant[0]]</code> + <code>$_GET['initial']</code> + <code>$_GET['initial']</code> + <code>$_GET['username']</code> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['old_hostname']</code> + <code>$_POST['old_hostname']</code> + <code>$_POST['old_username']</code> + <code>$_POST['old_username']</code> + <code>$_POST['old_username']</code> + <code>$_POST['old_username']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['userGroup']</code> + <code>$_POST['username']</code> + <code>$arr['ssl_cipher']</code> + <code>$arr['x509_issuer']</code> + <code>$arr['x509_subject']</code> <code>$dbRightsRow['Db']</code> <code>$dbname</code> + <code>$eachUser</code> + <code>$hashedPassword</code> + <code>$oldUserGroup</code> <code>$user</code> </PossiblyInvalidArgument> - <PossiblyInvalidCast occurrences="2"> + <PossiblyInvalidCast occurrences="28"> + <code>$_GET['username']</code> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['old_hostname']</code> + <code>$_POST['old_hostname']</code> + <code>$_POST['old_username']</code> + <code>$_POST['old_username']</code> + <code>$_POST['old_username']</code> + <code>$_POST['old_username']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['userGroup']</code> + <code>$_POST['username']</code> + <code>$_REQUEST['hostname']</code> + <code>$_REQUEST['username']</code> + <code>$arr['ssl_cipher']</code> + <code>$arr['x509_issuer']</code> + <code>$arr['x509_subject']</code> <code>$dbRightsRow['Db']</code> <code>$dbname</code> - </PossiblyInvalidCast> - <PossiblyNullArgument occurrences="14"> + <code>$dbname[0]</code> + <code>$eachUser</code> <code>$oldUserGroup</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="8"> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['authentication_plugin']</code> + <code>$_POST['old_hostname']</code> + <code>$_POST['old_username']</code> + <code>$authenticationPlugin</code> + <code>$authenticationPlugin</code> + <code>$authenticationPlugin</code> + <code>$dbAndTable[$key]</code> + </PossiblyInvalidOperand> + <PossiblyNullArgument occurrences="13"> <code>$privileges</code> <code>$row1['Type']</code> <code>$row1['Type']</code> @@ -12300,9 +12871,18 @@ <RedundantCastGivenDocblockType occurrences="1"> <code>(string) $privs</code> </RedundantCastGivenDocblockType> + <RedundantCondition occurrences="1"> + <code>is_string($_REQUEST['dbname'])</code> + </RedundantCondition> <RedundantConditionGivenDocblockType occurrences="1"> <code>$userGroup</code> </RedundantConditionGivenDocblockType> + <RiskyCast occurrences="4"> + <code>$_POST['max_connections']</code> + <code>$_POST['max_questions']</code> + <code>$_POST['max_updates']</code> + <code>$_POST['max_user_connections']</code> + </RiskyCast> </file> <file src="libraries/classes/Server/Select.php"> <MixedArgumentTypeCoercion occurrences="1"> @@ -12326,9 +12906,6 @@ </RedundantCast> </file> <file src="libraries/classes/Server/Status/Data.php"> - <MixedArgument occurrences="1"> - <code>$_POST['primary_connection'] ?? null</code> - </MixedArgument> <MixedArgumentTypeCoercion occurrences="2"> <code>$filter</code> <code>$name</code> @@ -12366,6 +12943,9 @@ <code>100 * $key_reads</code> <code>100 * $key_writes</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="1"> + <code>$_POST['primary_connection'] ?? null</code> + </PossiblyInvalidArgument> <RedundantCast occurrences="1"> <code>(string) $GLOBALS['cfg']['Server']['host']</code> </RedundantCast> @@ -12649,11 +13229,7 @@ <LessSpecificReturnStatement occurrences="1"> <code>$unlimNumRows</code> </LessSpecificReturnStatement> - <MixedArgument occurrences="47"> - <code>$_POST[$requestIndex]</code> - <code>$_POST['bkm_label']</code> - <code>$_POST['dropped_column'] ?? null</code> - <code>$_POST['table_create_time'] ?? null</code> + <MixedArgument occurrences="43"> <code>$analyzedSqlResults</code> <code>$analyzedSqlResults['is_affected']</code> <code>$analyzedSqlResults['is_analyse']</code> @@ -12792,12 +13368,23 @@ <NullableReturnStatement occurrences="1"> <code>$unlimNumRows</code> </NullableReturnStatement> - <PossiblyInvalidArgument occurrences="4"> + <PossiblyInvalidArgument occurrences="8"> + <code>$_POST[$requestIndex]</code> + <code>$_POST['bkm_label']</code> + <code>$_POST['dropped_column'] ?? null</code> + <code>$_POST['table_create_time'] ?? null</code> <code>$numRows</code> <code>$numRows</code> <code>$numRows</code> <code>$numRows</code> </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="1"> + <code>$_POST[$requestIndex]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST[$requestIndex]</code> + <code>$_POST['bkm_label']</code> + </PossiblyInvalidCast> <PossiblyInvalidOperand occurrences="1"> <code>$numRows</code> </PossiblyInvalidOperand> @@ -12811,15 +13398,13 @@ </RedundantCast> </file> <file src="libraries/classes/SqlQueryForm.php"> - <MixedArgument occurrences="2"> - <code>$query</code> - </MixedArgument> - <MixedAssignment occurrences="1"> + <MixedArgument occurrences="1"/> + <PossiblyInvalidArgument occurrences="1"> <code>$query</code> - </MixedAssignment> - <PossiblyFalseArgument occurrences="1"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> <code>$query</code> - </PossiblyFalseArgument> + </PossiblyInvalidCast> </file> <file src="libraries/classes/StorageEngine.php"> <MixedArgument occurrences="7"> @@ -12915,7 +13500,7 @@ <InvalidReturnStatement occurrences="1"> <code>$tableAutoIncrement ?? ''</code> </InvalidReturnStatement> - <MixedArgument occurrences="51"> + <MixedArgument occurrences="50"> <code>$GLOBALS['sql_auto_increments']</code> <code>$GLOBALS['sql_indexes']</code> <code>$_POST['constraint_name'][$masterFieldMd5]</code> @@ -12952,7 +13537,6 @@ <code>$masterField</code> <code>$masterField</code> <code>$masterField</code> - <code>$oldIndex</code> <code>$oneField</code> <code>$oneField</code> <code>$optionsArray[$_POST['on_delete'][$masterFieldMd5]]</code> @@ -12979,13 +13563,7 @@ <code>$where</code> <code>$where</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="39"> - <code>$_POST['constraint_name'][$masterFieldMd5]</code> - <code>$_POST['constraint_name'][$masterFieldMd5]</code> - <code>$_POST['on_delete'][$masterFieldMd5]</code> - <code>$_POST['on_delete'][$masterFieldMd5]</code> - <code>$_POST['on_update'][$masterFieldMd5]</code> - <code>$_POST['on_update'][$masterFieldMd5]</code> + <MixedArrayAccess occurrences="33"> <code>$_SESSION['tmpval']['table_uiprefs'][$serverId][$this->dbName][$this->name]</code> <code>$column['Extra']</code> <code>$column['Extra']</code> @@ -13043,8 +13621,7 @@ <code>$optionsArray[$existrelForeign[$masterFieldMd5]['on_delete'] ?? '']</code> <code>$optionsArray[$existrelForeign[$masterFieldMd5]['on_update'] ?? '']</code> </MixedArrayTypeCoercion> - <MixedAssignment occurrences="49"> - <code>$GLOBALS['sql_auto_increment']</code> + <MixedAssignment occurrences="47"> <code>$cachedResult</code> <code>$cachedResult</code> <code>$column</code> @@ -13067,7 +13644,6 @@ <code>$key</code> <code>$masterField</code> <code>$masterField</code> - <code>$oldIndex</code> <code>$onDelete</code> <code>$onUpdate</code> <code>$oneField</code> @@ -13124,6 +13700,18 @@ <code>end($this->messages)</code> <code>json_decode($value, true)</code> </MixedReturnStatement> + <PossiblyInvalidArgument occurrences="2"> + <code>$_POST['constraint_name'][$masterFieldMd5]</code> + <code>$oldIndex</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="6"> + <code>$_POST['constraint_name'][$masterFieldMd5]</code> + <code>$_POST['constraint_name'][$masterFieldMd5]</code> + <code>$_POST['on_delete'][$masterFieldMd5]</code> + <code>$_POST['on_delete'][$masterFieldMd5]</code> + <code>$_POST['on_update'][$masterFieldMd5]</code> + <code>$_POST['on_update'][$masterFieldMd5]</code> + </PossiblyInvalidArrayOffset> <PossiblyNullArgument occurrences="10"> <code>$GLOBALS['showtable']['Name']</code> <code>$commentsCopyRow['column_name']</code> @@ -13258,7 +13846,7 @@ <code>$mime_map[$columnMeta['Field']]</code> <code>$mime_map[$columnMeta['Field']]</code> </MixedArrayOffset> - <MixedAssignment occurrences="20"> + <MixedAssignment occurrences="19"> <code>$columnMeta</code> <code>$columnMeta['Default']</code> <code>$columnMeta['Default']</code> @@ -13268,7 +13856,6 @@ <code>$columnMeta['Key']</code> <code>$comments_map[$columnMeta['Field']]</code> <code>$default_value</code> - <code>$form_params['after_field']</code> <code>$form_params['field_length_orig[' . $columnNumber . ']']</code> <code>$form_params['field_name[' . $columnNumber . ']']</code> <code>$form_params['field_orig[' . $columnNumber . ']']</code> @@ -13280,22 +13867,27 @@ <code>$submit_attribute</code> <code>$type</code> </MixedAssignment> + <PossiblyInvalidArgument occurrences="2"> + <code>$form_params['db']</code> + <code>$form_params['table']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$form_params['db']</code> + <code>$form_params['table']</code> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Table/Indexes.php"> - <MixedArgument occurrences="1"> + <PossiblyInvalidArgument occurrences="1"> <code>$oldIndexName</code> - </MixedArgument> - <MixedAssignment occurrences="1"> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="1"> <code>$oldIndexName</code> - </MixedAssignment> + </PossiblyInvalidCast> </file> <file src="libraries/classes/Table/Search.php"> - <MixedArgument occurrences="19"> + <MixedArgument occurrences="16"> <code>$_POST['criteriaColumnNames'][$column_index]</code> <code>$_POST['criteriaColumnTypes'][$column_index]</code> - <code>$_POST['customWhereClause']</code> - <code>$_POST['orderByColumn']</code> - <code>$_POST['table']</code> <code>$column</code> <code>$criteriaValues</code> <code>$criteriaValues</code> @@ -13314,35 +13906,49 @@ <MixedArgumentTypeCoercion occurrences="1"> <code>$values</code> </MixedArgumentTypeCoercion> - <MixedArrayAccess occurrences="4"> - <code>$_POST['criteriaColumnNames'][$column_index]</code> - <code>$_POST['criteriaColumnTypes'][$column_index]</code> - <code>$_POST['criteriaValues'][$column_index]</code> - <code>$_POST['geom_func'][$column_index]</code> - </MixedArrayAccess> - <MixedArrayOffset occurrences="4"> - <code>$_POST['criteriaColumnNames'][$column_index]</code> - <code>$_POST['criteriaColumnTypes'][$column_index]</code> - <code>$_POST['criteriaValues'][$column_index]</code> - <code>$_POST['geom_func'][$column_index]</code> - </MixedArrayOffset> - <MixedAssignment occurrences="6"> + <MixedAssignment occurrences="4"> <code>$column</code> - <code>$column_index</code> - <code>$columnsToDisplay</code> <code>$operator</code> <code>$tmp_geom_func</code> <code>$value</code> </MixedAssignment> - <MixedOperand occurrences="7"> - <code>$_POST['customWhereClause']</code> - <code>$_POST['order']</code> + <MixedOperand occurrences="5"> <code>$criteriaValues</code> <code>$criteriaValues</code> <code>$criteriaValues</code> <code>$values[0] ?? ''</code> <code>$values[1] ?? ''</code> </MixedOperand> + <PossiblyInvalidArgument occurrences="8"> + <code>$_POST['criteriaColumnNames'][$column_index]</code> + <code>$_POST['criteriaColumnTypes'][$column_index]</code> + <code>$_POST['customWhereClause']</code> + <code>$_POST['orderByColumn']</code> + <code>$_POST['table']</code> + <code>$operator</code> + <code>$operator</code> + <code>$tmp_geom_func</code> + </PossiblyInvalidArgument> + <PossiblyInvalidArrayOffset occurrences="4"> + <code>$_POST['criteriaColumnNames'][$column_index]</code> + <code>$_POST['criteriaColumnTypes'][$column_index]</code> + <code>$_POST['criteriaValues'][$column_index]</code> + <code>$_POST['geom_func'][$column_index]</code> + </PossiblyInvalidArrayOffset> + <PossiblyInvalidCast occurrences="4"> + <code>$_POST['criteriaColumnNames'][$column_index]</code> + <code>$_POST['criteriaColumnTypes'][$column_index]</code> + <code>$operator</code> + <code>$operator</code> + </PossiblyInvalidCast> + <PossiblyInvalidIterator occurrences="2"> + <code>$_POST['criteriaColumnOperators']</code> + <code>$columnsToDisplay</code> + </PossiblyInvalidIterator> + <PossiblyInvalidOperand occurrences="2"> + <code>$_POST['customWhereClause']</code> + <code>$_POST['order']</code> + </PossiblyInvalidOperand> <PossiblyNullArrayOffset occurrences="1"> <code>$geom_funcs</code> </PossiblyNullArrayOffset> @@ -13477,22 +14083,8 @@ </RedundantConditionGivenDocblockType> </file> <file src="libraries/classes/Tracking.php"> - <MixedArgument occurrences="47"> - <code>$_POST['date_from']</code> - <code>$_POST['date_to']</code> - <code>$_POST['db']</code> - <code>$_POST['table']</code> - <code>$_POST['table']</code> - <code>$_POST['users']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> - <code>$_POST['version']</code> + <InvalidArgument occurrences="1"/> + <MixedArgument occurrences="32"> <code>$columns</code> <code>$data[$which_log]</code> <code>$data['ddlog']</code> @@ -13526,7 +14118,6 @@ <code>$str5</code> <code>$value['Name']</code> </MixedArgument> - <MixedArgumentTypeCoercion occurrences="1"/> <MixedArrayAccess occurrences="22"> <code>$data[$which_log][$delete_id]</code> <code>$data['ddlog']</code> @@ -13556,13 +14147,9 @@ <code>$entry['line_number']</code> <code>$entry['url_params']</code> </MixedArrayAssignment> - <MixedArrayOffset occurrences="1"> - <code>$data[$which_log][$delete_id]</code> - </MixedArrayOffset> - <MixedAssignment occurrences="20"> + <MixedAssignment occurrences="19"> <code>$columns</code> <code>$data</code> - <code>$delete_id</code> <code>$drop_create_statements</code> <code>$entries[]</code> <code>$entry</code> @@ -13598,6 +14185,33 @@ <code>$sep</code> <code>$sep</code> </PossiblyFalseOperand> + <PossiblyInvalidArgument occurrences="15"> + <code>$_POST['date_from']</code> + <code>$_POST['date_to']</code> + <code>$_POST['db']</code> + <code>$_POST['table']</code> + <code>$_POST['table']</code> + <code>$_POST['users']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="8"> + <code>$_POST['db']</code> + <code>$_POST['table']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + <code>$_POST['version']</code> + </PossiblyInvalidCast> <PossiblyInvalidOperand occurrences="2"> <code>$sep</code> <code>$sep</code> @@ -13610,6 +14224,9 @@ <PossiblyNullOperand occurrences="1"> <code>$versionNumber</code> </PossiblyNullOperand> + <RiskyCast occurrences="1"> + <code>$delete_id</code> + </RiskyCast> </file> <file src="libraries/classes/Transformations.php"> <MixedArgument occurrences="4"> @@ -13723,29 +14340,40 @@ <code>(string) $table</code> </RedundantCastGivenDocblockType> </file> + <file src="libraries/classes/UrlRedirector.php"> + <RedundantCast occurrences="4"> + <code>(string) $_GET['url']</code> + <code>(string) $_GET['url']</code> + <code>(string) $_GET['url']</code> + <code>(string) $_GET['url']</code> + </RedundantCast> + </file> <file src="libraries/classes/UserPassword.php"> - <MixedArgument occurrences="11"> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw']</code> - <code>$_POST['pma_pw2']</code> + <MixedArgument occurrences="6"> <code>$hostname</code> <code>$hostname</code> <code>$hostname</code> - <code>$orig_auth_plugin</code> <code>$username</code> <code>$username</code> <code>$username</code> </MixedArgument> - <MixedAssignment occurrences="1"> - <code>$orig_auth_plugin</code> - </MixedAssignment> <MixedMethodCall occurrences="1"> <code>handlePasswordChange</code> </MixedMethodCall> - <MixedOperand occurrences="1"> + <PossiblyInvalidArgument occurrences="5"> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw']</code> + <code>$_POST['pma_pw2']</code> <code>$orig_auth_plugin</code> - </MixedOperand> + </PossiblyInvalidArgument> + <PossiblyInvalidCast occurrences="2"> + <code>$_POST['pma_pw']</code> + <code>$orig_auth_plugin</code> + </PossiblyInvalidCast> + <PossiblyInvalidOperand occurrences="1"> + <code>$orig_auth_plugin</code> + </PossiblyInvalidOperand> </file> <file src="libraries/classes/UserPreferences.php"> <MixedArgumentTypeCoercion occurrences="2"> @@ -13778,16 +14406,13 @@ <code>$table['disp_name']</code> <code>$units[$d]</code> </InvalidArrayOffset> - <MixedArgument occurrences="11"> + <MixedArgument occurrences="8"> <code>$host</code> <code>$limitOffset</code> <code>$maxSize</code> <code>$maxUnit</code> <code>$row[$i] ?? null</code> <code>$table</code> - <code>$tableGroup</code> - <code>$tableType</code> - <code>$tableType</code> <code>$table['Name']</code> <code>$user</code> </MixedArgument> @@ -13826,7 +14451,7 @@ <code>$_SESSION['tmpval']['table_limit_offset']</code> <code>$_SESSION['tmpval']['table_limit_offset_db']</code> </MixedArrayAssignment> - <MixedArrayOffset occurrences="10"> + <MixedArrayOffset occurrences="8"> <code>$array[$p]</code> <code>$indexesData[$row['Key_name']]</code> <code>$indexesData[$row['Key_name']]</code> @@ -13835,13 +14460,11 @@ <code>$indexesInfo[$row['Key_name']]</code> <code>$indexesInfo[$row['Key_name']]</code> <code>$pkArray[$row['Column_name']]</code> - <code>$sortableNameMappings[$_REQUEST['sort']]</code> - <code>$sortableNameMappings[$_REQUEST['sort']]</code> </MixedArrayOffset> <MixedArrayTypeCoercion occurrences="1"> <code>$array[$p]</code> </MixedArrayTypeCoercion> - <MixedAssignment occurrences="37"> + <MixedAssignment occurrences="31"> <code>$array</code> <code>$columnNames[]</code> <code>$columnNames[]</code> @@ -13861,20 +14484,14 @@ <code>$pos</code> <code>$replace[$key]</code> <code>$replace[$key]</code> - <code>$requestedSort</code> - <code>$requestedSortOrder</code> <code>$retval[]</code> <code>$retval[]</code> <code>$row</code> <code>$rowCount</code> <code>$subvalue</code> <code>$table</code> - <code>$tableGroup</code> - <code>$tableType</code> <code>$table['disp_name']</code> <code>$unit</code> - <code>$urlParams['tbl_group']</code> - <code>$urlParams['tbl_type']</code> <code>$val</code> <code>$value</code> <code>$value</code> @@ -13887,10 +14504,9 @@ <code>$escapeMethod</code> <code>new $escape[1]()</code> </MixedMethodCall> - <MixedOperand occurrences="5"> + <MixedOperand occurrences="4"> <code>$group[$groupName]['tab' . $sep . 'count']</code> <code>$row['Column_name']</code> - <code>$tableGroup</code> <code>$unit</code> <code>$unit</code> </MixedOperand> @@ -13901,16 +14517,19 @@ <code>$group[$groupName]['tab' . $sep . 'count']</code> <code>$table['disp_name']</code> </MixedStringOffsetAssignment> - <PossiblyFalseOperand occurrences="3"> + <PossiblyFalseOperand occurrences="4"> + <code>$GLOBALS['cfg']['NavigationTreeTableSeparator']</code> <code>$GLOBALS['cfg']['NavigationTreeTableSeparator']</code> <code>mb_strpos($value, '.')</code> <code>mb_strrpos($columnSpecification, ')')</code> </PossiblyFalseOperand> - <PossiblyInvalidArgument occurrences="4"> + <PossiblyInvalidArgument occurrences="6"> <code>$row</code> <code>$sep</code> <code>$sep</code> <code>$table</code> + <code>$tableType</code> + <code>$tableType</code> </PossiblyInvalidArgument> <PossiblyInvalidArrayAccess occurrences="2"> <code>$group[$groupName]['tab' . $sep . 'count']</code> @@ -13928,7 +14547,8 @@ <code>$sep</code> <code>$sep</code> </PossiblyInvalidCast> - <PossiblyInvalidOperand occurrences="10"> + <PossiblyInvalidOperand occurrences="12"> + <code>$GLOBALS['cfg']['NavigationTreeTableSeparator']</code> <code>$GLOBALS['cfg']['NavigationTreeTableSeparator']</code> <code>$sep</code> <code>$sep</code> @@ -13939,6 +14559,7 @@ <code>$sep</code> <code>$sep</code> <code>$sep</code> + <code>$tableGroup</code> </PossiblyInvalidOperand> <PossiblyNullArgument occurrences="2"> <code>$maxSize</code> @@ -13952,9 +14573,11 @@ <code>$sotCache</code> <code>$tables</code> </PossiblyNullArrayOffset> - <RedundantCast occurrences="2"> + <RedundantCast occurrences="4"> <code>(int) $GLOBALS['cfg']['ExecTimeLimit']</code> <code>(int) $GLOBALS['cfg']['LimitChars']</code> + <code>(string) $_REQUEST['tbl_group']</code> + <code>(string) $_REQUEST['tbl_group']</code> </RedundantCast> <RedundantCastGivenDocblockType occurrences="6"> <code>(int) $meta->length</code> @@ -13968,6 +14591,9 @@ <code>$columnsList !== null</code> <code>isset($dbi)</code> </RedundantCondition> + <RiskyCast occurrences="1"> + <code>$_REQUEST['pos']</code> + </RiskyCast> </file> <file src="libraries/classes/Utils/ForeignKey.php"> <RedundantCastGivenDocblockType occurrences="1"> @@ -14128,12 +14754,25 @@ <MixedAssignment occurrences="1"> <code>$values</code> </MixedAssignment> + <RedundantCast occurrences="2"> + <code>(string) $_POST['id']</code> + <code>(string) $_POST['values']</code> + </RedundantCast> </file> <file src="test/classes/AbstractNetworkTestCase.php"> <MixedAssignment occurrences="1"> <code>$http_response_code_param</code> </MixedAssignment> </file> + <file src="test/classes/AbstractTestCase.php"> + <PossiblyUndefinedArrayOffset occurrences="5"> + <code>$_SERVER['PHP_SELF']</code> + <code>$_SERVER['REQUEST_TIME']</code> + <code>$_SERVER['REQUEST_TIME_FLOAT']</code> + <code>$_SERVER['SCRIPT_NAME']</code> + <code>$_SERVER['argv']</code> + </PossiblyUndefinedArrayOffset> + </file> <file src="test/classes/AdvisorTest.php"> <MixedInferredReturnType occurrences="2"> <code>array</code> @@ -14827,6 +15466,12 @@ <PossiblyInvalidArgument occurrences="1"> <code>testSanitizeUrl</code> </PossiblyInvalidArgument> + <PossiblyUndefinedArrayOffset occurrences="4"> + <code>$_SERVER['HTTP_USER_AGENT']</code> + <code>$_SERVER['HTTP_USER_AGENT']</code> + <code>$_SERVER['SERVER_SOFTWARE']</code> + <code>$_SERVER['SERVER_SOFTWARE']</code> + </PossiblyUndefinedArrayOffset> </file> <file src="test/classes/ErrorTest.php"> <MixedInferredReturnType occurrences="1"> @@ -15052,6 +15697,11 @@ </MixedArrayAssignment> </file> <file src="test/classes/InsertEditTest.php"> + <InvalidArrayOffset occurrences="3"> + <code>$_POST['fields']['multi_edit']</code> + <code>$_POST['fields']['multi_edit']</code> + <code>$_POST['fields']['multi_edit']</code> + </InvalidArrayOffset> <MixedArgument occurrences="7"> <code>$actual</code> <code>$actual</code> @@ -15073,10 +15723,9 @@ <code>$result['pma_type']</code> <code>$result['wrap']</code> </MixedArrayAccess> - <MixedArrayAssignment occurrences="5"> - <code>$_POST['fields']['multi_edit']</code> - <code>$_POST['fields']['multi_edit']</code> - <code>$_POST['fields']['multi_edit']</code> + <MixedArrayAssignment occurrences="4"> + <code>$_POST['fields']['multi_edit'][0]</code> + <code>$_POST['fields']['multi_edit'][0]</code> <code>$_SESSION['tmpval']['relational_display']</code> <code>$_SESSION['tmpval']['relational_display']</code> </MixedArrayAssignment> @@ -15324,6 +15973,9 @@ <code>array</code> <code>array</code> </MixedInferredReturnType> + <RedundantCondition occurrences="1"> + <code>assertIsString</code> + </RedundantCondition> </file> <file src="test/classes/Plugins/Auth/AuthenticationHttpTest.php"> <InvalidArgument occurrences="3"> @@ -15878,9 +16530,9 @@ </UndefinedMethod> </file> <file src="test/classes/TableTest.php"> - <MixedArrayAssignment occurrences="1"> + <InvalidArrayOffset occurrences="1"> <code>$_POST['old_index']['Key_name']</code> - </MixedArrayAssignment> + </InvalidArrayOffset> <MixedAssignment occurrences="3"> <code>$is_define_property</code> <code>$sql</code> |