Improve globalization code

1 files changed, 25 insertions, 56 deletions

diff --git a/server_replication.php b/server_replication.php
index 77e63e64dd..dc209d232b 100644
--- a/server_replication.php
+++ b/server_replication.php
@@ -37,62 +37,31 @@ if (! $is_superuser) {
 /**
  * Sets globals from $_REQUEST
  */
-if (isset($_REQUEST['hostname'])) {
-    $GLOBALS['hostname'] = $_REQUEST['hostname'];
-}
-if (isset($_REQUEST['mr_adduser'])) {
-    $GLOBALS['mr_adduser'] = $_REQUEST['mr_adduser'];
-}
-if (isset($_REQUEST['mr_configure'])) {
-    $GLOBALS['mr_configure'] = $_REQUEST['mr_configure'];
-}
-if (isset($_REQUEST['pma_pw'])) {
-    $GLOBALS['pma_pw'] = $_REQUEST['pma_pw'];
-}
-if (isset($_REQUEST['port'])) {
-    $GLOBALS['port'] = $_REQUEST['port'];
-}
-if (isset($_REQUEST['repl_clear_scr'])) {
-    $GLOBALS['repl_clear_scr'] = $_REQUEST['repl_clear_scr'];
-}
-if (isset($_REQUEST['repl_data'])) {
-    $GLOBALS['repl_data'] = $_REQUEST['repl_data'];
-}
-if (isset($_REQUEST['sl_configure'])) {
-    $GLOBALS['sl_configure'] = $_REQUEST['sl_configure'];
-}
-if (isset($_REQUEST['sl_sync'])) {
-    $GLOBALS['sl_sync'] = $_REQUEST['sl_sync'];
-}
-if (isset($_REQUEST['slave_changemaster'])) {
-    $GLOBALS['slave_changemaster'] = $_REQUEST['slave_changemaster'];
-}
-if (isset($_REQUEST['sr_skip_errors_count'])) {
-    $GLOBALS['sr_skip_errors_count'] = $_REQUEST['sr_skip_errors_count'];
-}
-if (isset($_REQUEST['sr_slave_action'])) {
-    $GLOBALS['sr_slave_action'] = $_REQUEST['sr_slave_action'];
-}
-if (isset($_REQUEST['sr_slave_control_parm'])) {
-    $GLOBALS['sr_slave_control_parm'] = $_REQUEST['sr_slave_control_parm'];
-}
-if (isset($_REQUEST['sr_slave_server_control'])) {
-    $GLOBALS['sr_slave_server_control'] = $_REQUEST['sr_slave_server_control'];
-}
-if (isset($_REQUEST['sr_slave_skip_error'])) {
-    $GLOBALS['sr_slave_skip_error'] = $_REQUEST['sr_slave_skip_error'];
-}
-if (isset($_REQUEST['sr_take_action'])) {
-    $GLOBALS['sr_take_action'] = $_REQUEST['sr_take_action'];
-}
-if (isset($_REQUEST['url_params'])) {
-    $GLOBALS['url_params'] = $_REQUEST['url_params'];
-}
-if (isset($_REQUEST['username'])) {
-    $GLOBALS['username'] = $_REQUEST['username'];
-}
-if (isset($_REQUEST[''])) {
-    $GLOBALS[''] = $_REQUEST[''];
+$request_params = array(
+    'hostname',
+    'mr_adduser',
+    'mr_configure',
+    'pma_pw',
+    'port',
+    'repl_clear_scr',
+    'repl_data',
+    'sl_configure',
+    'sl_sync',
+    'slave_changemaster',
+    'sr_skip_errors_count',
+    'sr_slave_action',
+    'sr_slave_control_parm',
+    'sr_slave_server_control',
+    'sr_slave_skip_error',
+    'sr_take_action',
+    'url_params',
+    'username'
+);
+
+foreach ($request_params as $one_request_param) {
+    if (isset($_REQUEST[$one_request_param])) {
+        $GLOBALS[$one_request_param] = $_REQUEST[$one_request_param];
+    }
 }
 
 /**