#16418 - Make MariaDBMySQLKBS optional

Signed-off-by: William Desportes <williamdes@wdes.fr>

1 files changed, 89 insertions, 6 deletions

diff --git a/test/classes/Controllers/Server/VariablesControllerTest.php b/test/classes/Controllers/Server/VariablesControllerTest.php
index 8457853eac..d6ea504a5f 100644
--- a/test/classes/Controllers/Server/VariablesControllerTest.php
+++ b/test/classes/Controllers/Server/VariablesControllerTest.php
@@ -7,12 +7,13 @@ namespace PhpMyAdmin\Tests\Controllers\Server;
 use PhpMyAdmin\Controllers\Server\VariablesController;
 use PhpMyAdmin\DatabaseInterface;
 use PhpMyAdmin\Html\Generator;
+use PhpMyAdmin\Providers\ServerVariables\ServerVariablesProvider;
+use PhpMyAdmin\Providers\ServerVariables\VoidProvider as ServerVariablesVoidProvider;
 use PhpMyAdmin\Response;
 use PhpMyAdmin\Template;
 use PhpMyAdmin\Tests\AbstractTestCase;
 use PhpMyAdmin\Tests\Stubs\Response as ResponseStub;
-use Williamdes\MariaDBMySQLKBS\Search as KBSearch;
-use Williamdes\MariaDBMySQLKBS\SlimData as KBSlimData;
+use ReflectionProperty;
 use function htmlspecialchars;
 use function str_replace;
 
@@ -135,22 +136,104 @@ class VariablesControllerTest extends AbstractTestCase
         $nameForValueByte = 'byte_variable';
         $nameForValueNotByte = 'not_a_byte_variable';
 
-        $slimData = new KBSlimData();
-        $slimData->addVariable($nameForValueByte, 'byte', null);
-        $slimData->addVariable($nameForValueNotByte, 'string', null);
-        KBSearch::loadTestData($slimData);
+        //name is_numeric and the value type is byte
+        $args = [
+            $nameForValueByte,
+            '3',
+        ];
+        $voidProviderMock = $this->getMockBuilder(ServerVariablesVoidProvider::class)->getMock();
+
+        $voidProviderMock
+            ->expects($this->exactly(2))
+            ->method('getVariableType')
+            ->willReturnOnConsecutiveCalls(
+                'byte',
+                'string'
+            );
+
+        $response = new ReflectionProperty(ServerVariablesProvider::class, 'instance');
+        $response->setAccessible(true);
+        $response->setValue($voidProviderMock);
+
+        [$formattedValue, $isHtmlFormatted] = $this->callFunction(
+            $controller,
+            VariablesController::class,
+            'formatVariable',
+            $args
+        );
+
+        $this->assertEquals(
+            '<abbr title="3">3 B</abbr>',
+            $formattedValue
+        );
+        $this->assertTrue($isHtmlFormatted);
+
+        //name is_numeric and the value type is not byte
+        $args = [
+            $nameForValueNotByte,
+            '3',
+        ];
+        [$formattedValue, $isHtmlFormatted] = $this->callFunction(
+            $controller,
+            VariablesController::class,
+            'formatVariable',
+            $args
+        );
+        $this->assertEquals(
+            '3',
+            $formattedValue
+        );
+        $this->assertFalse($isHtmlFormatted);
+
+        //value is not a number
+        $args = [
+            $nameForValueNotByte,
+            'value',
+        ];
+        [$formattedValue, $isHtmlFormatted] = $this->callFunction(
+            $controller,
+            VariablesController::class,
+            'formatVariable',
+            $args
+        );
+        $this->assertEquals(
+            'value',
+            $formattedValue
+        );
+        $this->assertFalse($isHtmlFormatted);
+    }
+
+    /**
+     * Test for formatVariable()
+     */
+    public function testFormatVariableMariaDbMySqlKbs(): void
+    {
+        if (! ServerVariablesProvider::mariaDbMySqlKbsExists()) {
+            $this->markTestSkipped('MariaDbMySqlKbs is missing');
+        }
+
+        $response = new ReflectionProperty(ServerVariablesProvider::class, 'instance');
+        $response->setAccessible(true);
+        $response->setValue(null);
+
+        $controller = new VariablesController(Response::getInstance(), new Template(), $GLOBALS['dbi']);
+
+        $nameForValueByte = 'wsrep_replicated_bytes';
+        $nameForValueNotByte = 'wsrep_thread_count';
 
         //name is_numeric and the value type is byte
         $args = [
             $nameForValueByte,
             '3',
         ];
+
         [$formattedValue, $isHtmlFormatted] = $this->callFunction(
             $controller,
             VariablesController::class,
             'formatVariable',
             $args
         );
+
         $this->assertEquals(
             '<abbr title="3">3 B</abbr>',
             $formattedValue