1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
|
<?php
/**
* tests for Advisor class
*
* @package PhpMyAdmin-test
*/
declare(strict_types=1);
namespace PhpMyAdmin\Tests;
use PhpMyAdmin\Advisor;
use PhpMyAdmin\Config;
use PhpMyAdmin\Tests\PmaTestCase;
use PhpMyAdmin\Theme;
use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
/**
* Tests behaviour of PMA_Advisor class
*
* @package PhpMyAdmin-test
*/
class AdvisorTest extends PmaTestCase
{
/**
* Sets up the fixture, for example, opens a network connection.
* This method is called before a test is executed.
*
* @return void
*/
protected function setUp(): void
{
$GLOBALS['PMA_Config'] = new Config();
$GLOBALS['server'] = 1;
}
/**
* Tests string escaping
*
* @param string $text Text to escape
* @param string $expected Expected output
*
* @return void
*
* @dataProvider escapeStrings
*/
public function testEscape($text, $expected): void
{
$this->assertEquals(Advisor::escapePercent($text), $expected);
}
/**
* return of escape Strings
*
* @return array
*/
public function escapeStrings()
{
return [
[
'80%',
'80%%',
],
[
'%s%',
'%s%%',
],
[
'80% foo',
'80%% foo',
],
[
'%s% foo',
'%s%% foo',
],
];
}
/**
* test for parseRulesFile
*
* @return void
*/
public function testParse()
{
$advisor = new Advisor($GLOBALS['dbi'], new ExpressionLanguage());
$parseResult = $advisor->parseRulesFile(Advisor::GENERIC_RULES_FILE);
$this->assertEquals($parseResult['errors'], []);
}
/**
* test for Advisor::byTime
*
* @param float $time time
* @param string $expected expected result
*
* @return void
*
* @dataProvider advisorTimes
*/
public function testAdvisorBytime($time, $expected): void
{
$result = Advisor::byTime($time, 2);
$this->assertEquals($expected, $result);
}
/**
* @return array
*/
public function advisorTimes()
{
return [
[
10,
'10 per second',
],
[
0.02,
'1.2 per minute',
],
[
0.003,
'10.8 per hour',
],
[
0.00003,
'2.59 per day',
],
[
0.0000000003,
'<0.01 per day',
],
];
}
/**
* test for Advisor::timespanFormat
*
* @return void
*/
public function testAdvisorTimespanFormat()
{
$result = Advisor::timespanFormat(1200);
$this->assertEquals('0 days, 0 hours, 20 minutes and 0 seconds', $result);
$result = Advisor::timespanFormat(100);
$this->assertEquals('0 days, 0 hours, 1 minutes and 40 seconds', $result);
}
/**
* Test for adding rule
*
* @param array $rule Rule to test
* @param array $expected Expected rendered rule in fired/errors list
* @param string $error Expected error string (null if none error expected)
*
* @return void
*
* @depends testParse
* @dataProvider rulesProvider
*/
public function testAddRule($rule, $expected, $error): void
{
$advisor = new Advisor($GLOBALS['dbi'], new ExpressionLanguage());
$parseResult = $advisor->parseRulesFile(Advisor::GENERIC_RULES_FILE);
$this->assertEquals($parseResult['errors'], []);
$advisor->setVariable('value', 0);
$advisor->addRule('fired', $rule);
$runResult = $advisor->getRunResult();
if (isset($runResult['errors']) || $error !== null) {
$this->assertEquals([$error], $runResult['errors']);
}
if (isset($runResult['fired']) || $expected != []) {
$this->assertEquals([$expected], $runResult['fired']);
}
}
/**
* rules Provider
*
* @return array
*/
public function rulesProvider()
{
return [
[
[
'justification' => 'foo',
'name' => 'Basic',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
[
'justification' => 'foo',
'id' => 'Basic',
'name' => 'Basic',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
null,
],
[
[
'justification' => 'foo',
'name' => 'Variable',
'issue' => 'issue',
'recommendation' => 'Recommend {status_var}',
],
[
'justification' => 'foo',
'id' => 'Variable',
'name' => 'Variable',
'issue' => 'issue',
'recommendation' => 'Recommend <a href="index.php?route=/server/variables&' .
'filter=status_var&lang=en">status_var</a>',
],
null,
],
[
[
'justification' => '%s foo | value',
'name' => 'Format',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
[
'justification' => '0 foo',
'id' => 'Format',
'name' => 'Format',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
null,
],
[
[
'justification' => '%s% foo | value',
'name' => 'Percent',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
[
'justification' => '0% foo',
'id' => 'Percent',
'name' => 'Percent',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
null,
],
[
[
'justification' => '%s% %d foo | value, value',
'name' => 'Double',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
[
'justification' => '0% 0 foo',
'id' => 'Double',
'name' => 'Double',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
null,
],
[
[
'justification' => '"\'foo',
'name' => 'Quotes',
'issue' => 'issue',
'recommendation' => 'Recommend"\'',
],
[
'justification' => '"\'foo',
'id' => 'Quotes',
'name' => 'Quotes',
'issue' => 'issue',
'recommendation' => 'Recommend"\'',
],
null,
],
[
[
'justification' => 'foo | fsafdsa',
'name' => 'Failure',
'issue' => 'issue',
'recommendation' => 'Recommend',
],
[],
'Failed formatting string for rule \'Failure\'. ' .
'Error when evaluating: Variable "fsafdsa" is not ' .
'valid around position 2 for expression `[fsafdsa]`.',
],
[
[
'justification' => 'Version string (%s) | value',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="https://example.com/">web</a>',
],
[
'justification' => 'Version string (0)',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="./url.php?url=https%3A%2F%2F' .
'example.com%2F" target="_blank" rel="noopener noreferrer">web</a>',
'id' => 'Distribution',
],
null,
],
[
[
'justification' => 'Timestamp (%s) | ADVISOR_timespanFormat(1377027)',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="https://example.com/">web</a>',
],
[
'justification' => 'Timestamp (15 days, 22 hours, 30 minutes and 27 seconds)',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="./url.php?url=https%3A%2F%2F' .
'example.com%2F" target="_blank" rel="noopener noreferrer">web</a>',
'id' => 'Distribution',
],
null,
],
[
[
'justification' => 'Memory: %s | ADVISOR_formatByteDown(1000000, 2, 2)',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="https://example.com/">web</a>',
],
[
'justification' => 'Memory: 0.95 MiB',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="./url.php?url=https%3A%2F%2F' .
'example.com%2F" target="_blank" rel="noopener noreferrer">web</a>',
'id' => 'Distribution',
],
null,
],
[
[
'justification' => 'Time: %s | ADVISOR_bytime(0.02, 2)',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="https://example.com/">web</a>',
],
[
'justification' => 'Time: 1.2 per minute',
'name' => 'Distribution',
'issue' => 'official MySQL binaries.',
'recommendation' => 'See <a href="./url.php?url=https%3A%2F%2F' .
'example.com%2F" target="_blank" rel="noopener noreferrer">web</a>',
'id' => 'Distribution',
],
null,
],
[
[
'justification' => 'Current version: %s | value',
'name' => 'Minor Version',
'precondition' => '! fired(\'Release Series\')',
'issue' => 'Version less than 5.1.30',
'recommendation' => 'You should upgrade',
'formula' => 'version',
'test' => "substr(value,0,2) <= '5.' && substr(value,2,1) <= 1 && substr(value,4,2) < 30",
],
[
'justification' => 'Current version: 0',
'name' => 'Minor Version',
'issue' => 'Version less than 5.1.30',
'recommendation' => 'You should upgrade',
'id' => 'Minor Version',
'precondition' => '! fired(\'Release Series\')',
'formula' => 'version',
'test' => "substr(value,0,2) <= '5.' && substr(value,2,1) <= 1 && substr(value,4,2) < 30",
],
null,
],
];
}
}
|
