diff options
author | Aleš Matěj <amatej@redhat.com> | 2022-02-22 13:10:54 +0300 |
---|---|---|
committer | Neal Gompa (ニール・ゴンパ) <ngompa13@gmail.com> | 2022-03-07 17:55:06 +0300 |
commit | 0932975c5079e8ef650d2f10847ee474d906879f (patch) | |
tree | c5d536eddfef7ca28538f6a46986309dc062dc1c | |
parent | 427e303cbc8bf76215e19755245811ab3d2b5125 (diff) |
Fix a memory leak when removing the first link in a list
If we just move the HEAD of the list to the next link we lose a
reference to the first link forever. We need to free it.
-rw-r--r-- | src/xml_parser_main_metadata_together.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/xml_parser_main_metadata_together.c b/src/xml_parser_main_metadata_together.c index d8619a5..af2aa58 100644 --- a/src/xml_parser_main_metadata_together.c +++ b/src/xml_parser_main_metadata_together.c @@ -48,7 +48,7 @@ call_user_callback_if_package_finished(cr_Package *pkg, cr_CbData *cb_data, GErr (pkg->loadingflags & CR_PACKAGE_LOADED_FIL)) { //remove first element in the list - cb_data->in_progress_pkgs_list = cb_data->in_progress_pkgs_list->next; + cb_data->in_progress_pkgs_list = g_slist_delete_link(cb_data->in_progress_pkgs_list, cb_data->in_progress_pkgs_list); // One package was fully finished cb_data->in_progress_count_primary--; |