diff options
| author | Sanchayan Maity <sanchayan@sanchayanmaity.net> | 2022-06-06 16:27:50 +0300 |
|---|---|---|
| committer | Sebastian Dröge <slomo@coaxion.net> | 2022-06-14 11:03:49 +0300 |
| commit | 19f69614a21e0e50d735c310e2ee7577f105d7bb (patch) | |
| tree | 53c05e892dd9e20cf5dc1eb505b7f39f73699f70 | |
| parent | 511ee766df22c1b33e0967f9c389f9c47bbbda8c (diff) | |
aws: s3sink: Add a deprecation warning for retry duration properties
Keeping the upload-part-retry-duration & complete-upload-retry-duration
properties changes the semantics in comparison to their usage in
rusotos3sink. Deprecate these two properties and add a warning while
making them noop.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/759>
| -rw-r--r-- | net/aws/src/s3sink/imp.rs | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/aws/src/s3sink/imp.rs b/net/aws/src/s3sink/imp.rs index b6b0e501..6277204f 100644 --- a/net/aws/src/s3sink/imp.rs +++ b/net/aws/src/s3sink/imp.rs @@ -834,7 +834,7 @@ impl ObjectImpl for S3Sink { settings.request_timeout = duration_from_millis(value.get::<i64>().expect("type checked upstream")); } - "retry-duration" | "upload-part-retry-duration" | "complete-upload-retry-duration" => { + "retry-duration" => { /* * To maintain backwards compatibility calculate retry attempts * by dividing the provided duration from request timeout. @@ -848,6 +848,9 @@ impl ObjectImpl for S3Sink { }; settings.retry_attempts = retry_attempts as u32; } + "upload-part-retry-duration" | "complete-upload-retry-duration" => { + gst::warning!(CAT, "Use retry-attempts. retry/upload-part/complete-upload-retry duration are deprecated."); + } _ => unimplemented!(), } } |