diff options
author | Stefan Niedermann <info@niedermann.it> | 2020-11-09 20:14:56 +0300 |
---|---|---|
committer | Stefan Niedermann <info@niedermann.it> | 2020-11-09 20:14:56 +0300 |
commit | bb8246a890f0e5b8a80cc275d8276e1cdcc6025b (patch) | |
tree | 89475fb34701ff739a1f5b82d66f17a50c38904d /app/src/main/java | |
parent | 9774d0ccbdf4635cd3343445a2d01ae0dbab853c (diff) |
Small code optimizations
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Diffstat (limited to 'app/src/main/java')
3 files changed, 2 insertions, 7 deletions
diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java index 5e0d376d6..bb42f27ef 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java @@ -308,7 +308,7 @@ public class CardAttachmentsFragment extends BrandedFragment implements Attachme // // TODO Only usable with Scoped Storage // pickerAdapter = new FileAdapter(requireContext(), uri -> onActivityResult(REQUEST_CODE_PICK_FILE, RESULT_OK, new Intent().setData(uri)), this::openNativeFilePicker); // } else { - pickerAdapter = new FileAdapterLegacy(requireContext(), (uri, pair) -> { + pickerAdapter = new FileAdapterLegacy((uri, pair) -> { previewViewModel.prepareDialog(pair.first, pair.second); PreviewDialog.newInstance().show(getChildFragmentManager(), PreviewDialog.class.getSimpleName()); observeOnce(previewViewModel.getResult(), getViewLifecycleOwner(), (submitPositive) -> { diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/ContactAdapter.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/ContactAdapter.java index 8ff11546c..79c65a560 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/ContactAdapter.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/ContactAdapter.java @@ -36,7 +36,6 @@ import static android.provider.ContactsContract.Contacts._ID; public class ContactAdapter extends AbstractCursorPickerAdapter<RecyclerView.ViewHolder> { - private final int lookupKeyColumnIndex; private final int displayNameColumnIndex; diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/FileAdapterLegacy.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/FileAdapterLegacy.java index 5688ab15b..1ac14361a 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/FileAdapterLegacy.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/picker/FileAdapterLegacy.java @@ -1,6 +1,5 @@ package it.niedermann.nextcloud.deck.ui.card.attachments.picker; -import android.content.Context; import android.net.Uri; import android.os.Environment; import android.util.Pair; @@ -30,17 +29,14 @@ import static java.util.stream.Collectors.toList; public class FileAdapterLegacy extends AbstractPickerAdapter<RecyclerView.ViewHolder> { @NonNull - private final Context context; - @NonNull private final List<File> files; @NonNull protected final BiConsumer<Uri, Pair<String, RequestBuilder<?>>> onSelect; @NonNull protected final Runnable openNativePicker; - public FileAdapterLegacy(@NonNull Context context, @NonNull BiConsumer<Uri, Pair<String, RequestBuilder<?>>> onSelect, @NonNull Runnable openNativePicker) { + public FileAdapterLegacy(@NonNull BiConsumer<Uri, Pair<String, RequestBuilder<?>>> onSelect, @NonNull Runnable openNativePicker) { // TODO run in separate thread? - this.context = context; this.onSelect = onSelect; this.openNativePicker = openNativePicker; this.files = Arrays.stream(requireNonNull(requireNonNull(Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS)).listFiles())) |