Welcome to mirror list, hosted at ThFree Co, Russian Federation.

SyncRepositoryTest.java « repository « deck « nextcloud « niedermann « it « java « test « src « app - github.com/stefan-niedermann/nextcloud-deck.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
blob: 54bc2dc4a1d9132c49a6eda0e4cc2bd93f86bf32 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
package it.niedermann.nextcloud.deck.repository;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.argThat;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.reset;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import android.accounts.NetworkErrorException;
import android.content.Context;

import androidx.annotation.NonNull;
import androidx.arch.core.executor.testing.InstantTaskExecutorRule;
import androidx.lifecycle.MutableLiveData;
import androidx.test.core.app.ApplicationProvider;

import com.google.common.util.concurrent.MoreExecutors;
import com.nextcloud.android.sso.api.ParsedResponse;
import com.nextcloud.android.sso.exceptions.NextcloudHttpRequestFailedException;

import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;

import java.time.Instant;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ExecutionException;

import it.niedermann.nextcloud.deck.TestUtil;
import it.niedermann.nextcloud.deck.database.DataBaseAdapter;
import it.niedermann.nextcloud.deck.exceptions.OfflineException;
import it.niedermann.nextcloud.deck.model.Account;
import it.niedermann.nextcloud.deck.model.Board;
import it.niedermann.nextcloud.deck.model.Card;
import it.niedermann.nextcloud.deck.model.Stack;
import it.niedermann.nextcloud.deck.model.full.FullBoard;
import it.niedermann.nextcloud.deck.model.full.FullStack;
import it.niedermann.nextcloud.deck.model.interfaces.IRemoteEntity;
import it.niedermann.nextcloud.deck.model.ocs.Capabilities;
import it.niedermann.nextcloud.deck.model.ocs.Version;
import it.niedermann.nextcloud.deck.remote.adapters.ServerAdapter;
import it.niedermann.nextcloud.deck.remote.api.IResponseCallback;
import it.niedermann.nextcloud.deck.remote.api.LastSyncUtil;
import it.niedermann.nextcloud.deck.remote.api.ResponseCallback;
import it.niedermann.nextcloud.deck.remote.helpers.SyncHelper;
import it.niedermann.nextcloud.deck.remote.helpers.providers.AbstractSyncDataProvider;
import it.niedermann.nextcloud.deck.remote.helpers.providers.CardDataProvider;
import it.niedermann.nextcloud.deck.remote.helpers.providers.StackDataProvider;
import it.niedermann.nextcloud.deck.remote.helpers.util.ConnectivityUtil;

@RunWith(RobolectricTestRunner.class)
public class SyncRepositoryTest {

    @Rule
    public InstantTaskExecutorRule instantTaskExecutorRule = new InstantTaskExecutorRule();

    private final Context context = ApplicationProvider.getApplicationContext();
    private final ServerAdapter serverAdapter = mock(ServerAdapter.class);
    private final DataBaseAdapter dataBaseAdapter = mock(DataBaseAdapter.class);
    private final SyncHelper.Factory syncHelperFactory = mock(SyncHelper.Factory.class);
    private final ConnectivityUtil connectivityUtil = mock(ConnectivityUtil.class);

    private SyncRepository syncRepository;

    @Before
    public void setup() {
        when(dataBaseAdapter.getCurrentAccountId$()).thenReturn(new MutableLiveData<>());
        syncRepository = new SyncRepository(context, serverAdapter, connectivityUtil, syncHelperFactory, dataBaseAdapter, MoreExecutors.newDirectExecutorService());
    }

    @Test
    public void testHasAccounts() throws InterruptedException {
        when(dataBaseAdapter.hasAccounts()).thenReturn(new MutableLiveData<>(true));
        final var hasAccountsPositive = syncRepository.hasAccounts();
        assertTrue(TestUtil.getOrAwaitValue(hasAccountsPositive));
        verify(dataBaseAdapter, times(1)).hasAccounts();

        reset(dataBaseAdapter);

        when(dataBaseAdapter.hasAccounts()).thenReturn(new MutableLiveData<>(false));
        final var hasAccountsNegative = syncRepository.hasAccounts();
        assertFalse(TestUtil.getOrAwaitValue(hasAccountsNegative));
        verify(dataBaseAdapter, times(1)).hasAccounts();
    }

    @Test
    public void testReadAccount() throws InterruptedException {
        final var account = new Account();
        account.setId(5L);
        account.setName("text@example.com");

        when(dataBaseAdapter.readAccount(5)).thenReturn(new MutableLiveData<>(account));
        assertEquals(account, TestUtil.getOrAwaitValue(syncRepository.readAccount(5)));
        verify(dataBaseAdapter, times(1)).readAccount(5);

        reset(dataBaseAdapter);

        when(dataBaseAdapter.readAccount("test@example.com")).thenReturn(new MutableLiveData<>(account));
        assertEquals(account, TestUtil.getOrAwaitValue(syncRepository.readAccount("test@example.com")));
        verify(dataBaseAdapter, times(1)).readAccount("test@example.com");

        reset(dataBaseAdapter);

        when(dataBaseAdapter.readAccount(5)).thenReturn(new MutableLiveData<>(null));
        assertNull(TestUtil.getOrAwaitValue(syncRepository.readAccount(5)));
        verify(dataBaseAdapter, times(1)).readAccount(5);

        reset(dataBaseAdapter);

        when(dataBaseAdapter.readAccount("test@example.com")).thenReturn(new MutableLiveData<>(null));
        assertNull(TestUtil.getOrAwaitValue(syncRepository.readAccount("test@example.com")));
        verify(dataBaseAdapter, times(1)).readAccount("test@example.com");
    }

    @Test
    public void testDeleteAccount() {
        doNothing().when(dataBaseAdapter).deleteAccount(anyLong());
        syncRepository.deleteAccount(1337L);
        verify(dataBaseAdapter, times(1)).deleteAccount(1337L);
    }

    /**
     * When {@link SyncRepository#synchronizeBoard(long, ResponseCallback)} is triggered, it should
     * pass the given {@link ResponseCallback} to the {@link SyncHelper} and trigger a
     * {@link SyncHelper#doSyncFor(AbstractSyncDataProvider)}.
     * {@link OfflineException} should be caught and passed to the {@link ResponseCallback}
     */
    @Test
    public void testSynchronizeBoard() {
        final var syncHelper = mock(SyncHelper.class);

        when(dataBaseAdapter.getFullBoardByLocalIdDirectly(anyLong(), anyLong())).thenReturn(new FullBoard());
        when(syncHelper.setResponseCallback(any())).thenReturn(syncHelper);
        doNothing().when(syncHelper).doSyncFor(any());
        when(syncHelperFactory.create(any(), any(), any())).thenReturn(syncHelper);

        final var responseCallback = spy(new ResponseCallback<Boolean>(new Account(1L)) {
            @Override
            public void onResponse(Boolean response) {

            }
        });

        syncRepository.synchronizeBoard(1L, responseCallback);

        verify(syncHelper, times(1)).setResponseCallback(responseCallback);
        verify(syncHelper, times(1)).doSyncFor(any(StackDataProvider.class));

        doThrow(OfflineException.class).when(syncHelper).doSyncFor(any());

        syncRepository.synchronizeBoard(1L, responseCallback);

        verify(responseCallback, times(1)).onError(any(OfflineException.class));
    }

    @Test
    public void testSynchronizeCard() {
        final var syncHelper = mock(SyncHelper.class);
        final var fullStack = new FullStack();
        fullStack.setStack(new Stack("Test", 1L));

        when(dataBaseAdapter.getFullStackByLocalIdDirectly(anyLong())).thenReturn(fullStack);
        when(dataBaseAdapter.getBoardByLocalIdDirectly(anyLong())).thenReturn(new Board());
        when(syncHelper.setResponseCallback(any())).thenReturn(syncHelper);
        doNothing().when(syncHelper).doSyncFor(any());
        when(syncHelperFactory.create(any(), any(), any())).thenReturn(syncHelper);

        final var responseCallback = spy(new ResponseCallback<Boolean>(new Account(1L)) {
            @Override
            public void onResponse(Boolean response) {

            }
        });

        final var card = new Card();
        card.setStackId(5000L);

        syncRepository.synchronizeCard(responseCallback, card);

        verify(syncHelper, times(1)).setResponseCallback(responseCallback);
        verify(syncHelper, times(1)).doSyncFor(any(CardDataProvider.class));

        doThrow(OfflineException.class).when(syncHelper).doSyncFor(any());

        syncRepository.synchronizeCard(responseCallback, card);

        verify(responseCallback, times(1)).onError(any(OfflineException.class));
    }

    @Test
    @SuppressWarnings("unchecked")
    public void testCreateAccountWithSuccessfulFirstBoardCall() {
        final var account = new Account(1337L, "Test", "Peter", "example.com");
        final var callback = mock(IResponseCallback.class);
        when(dataBaseAdapter.createAccountDirectly(any(Account.class))).thenReturn(account);
        doAnswer(invocation -> {
            ((ResponseCallback<ParsedResponse<List<FullBoard>>>) invocation.getArgument(0))
                    .onResponse(ParsedResponse.of(Collections.emptyList()));
            return null;
        }).when(serverAdapter).getBoards(any());

        syncRepository.createAccount(account, callback);
        verify(dataBaseAdapter, times(1)).createAccountDirectly(account);
        verify(callback, times(1)).onResponse(account);
    }

    @Test
    @SuppressWarnings("unchecked")
    public void testCreateAccountWithFailingFirstBoardCall() {
        final var account = new Account(1337L, "Test", "Peter", "example.com");
        final var callback = mock(IResponseCallback.class);
        when(dataBaseAdapter.createAccountDirectly(any(Account.class))).thenReturn(account);
        doAnswer(invocation -> {
            ((ResponseCallback<ParsedResponse<Capabilities>>) invocation.getArgument(0))
                    .onError(new NextcloudHttpRequestFailedException(404, new RuntimeException()));
            return null;
        }).when(serverAdapter).getBoards(any());

        syncRepository.createAccount(account, callback);
        verify(dataBaseAdapter, times(1)).createAccountDirectly(account);
        verify(callback, times(1)).onResponse(account);
    }

    @Test
    public void testReadAccountDirectly() {
        final var account = new Account(1337L, "Test", "Peter", "example.com");
        when(dataBaseAdapter.readAccountDirectly(1337L)).thenReturn(account);
        assertEquals(account, syncRepository.readAccountDirectly(1337L));
    }

    @Test
    public void testReadAccounts() throws InterruptedException {
        final var accounts = Collections.singletonList(new Account(1337L, "Test", "Peter", "example.com"));
        final var wrappedAccounts = new MutableLiveData<List<Account>>();
        wrappedAccounts.setValue(accounts);
        when(dataBaseAdapter.readAccounts()).thenReturn(wrappedAccounts);

        final var result = TestUtil.getOrAwaitValue(syncRepository.readAccounts());

        verify(dataBaseAdapter, times(1)).readAccounts();
        assertEquals(1, result.size());
    }

    @Test
    public void testReadAccountsDirectly() {
        final var accounts = Collections.singletonList(new Account(1337L, "Test", "Peter", "example.com"));
        when(dataBaseAdapter.getAllAccountsDirectly()).thenReturn(accounts);
        assertEquals(1, syncRepository.readAccountsDirectly().size());
    }

    @Test
    public void testRefreshCapabilities() throws ExecutionException, InterruptedException {
        final var account = new Account(1337L, "Test", "Peter", "example.com");
        account.setEtag("This-Is-The-Old_ETag");
        //noinspection unchecked
        final var mockedResponse = mock(ParsedResponse.class);
        final var serverResponse = new Capabilities();
        serverResponse.setDeckVersion(Version.of("1.0.0"));
        when(mockedResponse.getResponse()).thenReturn(serverResponse);
        when(mockedResponse.getHeaders()).thenReturn(Map.of("ETag", "New-ETag"));
        when(dataBaseAdapter.getAccountByIdDirectly(anyLong())).thenReturn(account);

        // Happy path

        doAnswer(invocation -> {
            assertEquals("The old eTag must be passed to the " + ServerAdapter.class.getSimpleName(),
                    "This-Is-The-Old_ETag", invocation.getArgument(0));
            //noinspection unchecked
            ((ResponseCallback<ParsedResponse<Capabilities>>) invocation.getArgument(1))
                    .onResponse(mockedResponse);
            return null;
        }).when(serverAdapter).getCapabilities(anyString(), any());

        syncRepository.refreshCapabilities(new ResponseCallback<>(account) {
            @Override
            public void onResponse(Capabilities response) {
                assertEquals("Capabilities from server must be returned to the original callback",
                        Version.of("1.0.0"), response.getDeckVersion());
                verify(dataBaseAdapter).updateAccount(argThat(account -> "New-ETag".equals(account.getEtag())));
            }

            @Override
            public void onError(Throwable throwable) {
                fail(throwable.getMessage());
            }
        }).get();


        // HTTP 304 - Not modified

        account.setMaintenanceEnabled(true);
        doAnswer(invocation -> {
            //noinspection unchecked
            ((ResponseCallback<ParsedResponse<Capabilities>>) invocation.getArgument(1))
                    .onError(new NextcloudHttpRequestFailedException(304, new RuntimeException()));
            return null;
        }).when(serverAdapter).getCapabilities(anyString(), any());

        syncRepository.refreshCapabilities(new ResponseCallback<>(account) {
            @Override
            public void onResponse(Capabilities response) {
                assertEquals("Capabilities from server must be returned to the original callback",
                        Version.of("1.0.0"), response.getDeckVersion());
                assertFalse("The maintenance mode must be turned off after a HTTP 304 to avoid stucking \"offline\" and start a real request the next time - the maintenance mode might be off the next time.",
                        account.isMaintenanceEnabled());
                verify(dataBaseAdapter).updateAccount(argThat(account -> "This-Is-The-Old_ETag".equals(account.getEtag())));
            }

            @Override
            public void onError(Throwable throwable) {
                fail("HTTP 304 means nothing has been modified - This is not an error.");
            }
        }).get();


        // HTTP 500 - Server error

        doAnswer(invocation -> {
            //noinspection unchecked
            ((ResponseCallback<ParsedResponse<Capabilities>>) invocation.getArgument(1))
                    .onError(new NextcloudHttpRequestFailedException(500, new RuntimeException()));
            return null;
        }).when(serverAdapter).getCapabilities(anyString(), any());

        syncRepository.refreshCapabilities(new ResponseCallback<>(account) {
            @Override
            public void onResponse(Capabilities response) {
                fail("In case of an HTTP 500 the callback must not be responded successfully.");
            }

            @Override
            public void onError(Throwable throwable) {
                assertEquals(NextcloudHttpRequestFailedException.class, throwable.getClass());
                assertEquals(500, ((NextcloudHttpRequestFailedException) throwable).getStatusCode());
            }
        }).get();


        // HTTP 503 - Maintenance mode

        doAnswer(invocation -> {
            //noinspection unchecked
            ((ResponseCallback<ParsedResponse<Capabilities>>) invocation.getArgument(1))
                    .onError(new NextcloudHttpRequestFailedException(503, new RuntimeException("{\"ocs\": {\"meta\": {\"statuscode\": 503}, \"data\": {\"version\": {\"major\": 20, \"minor\": 0, \"patch\": 1}}}}")));
            return null;
        }).when(serverAdapter).getCapabilities(anyString(), any());

        syncRepository.refreshCapabilities(new ResponseCallback<>(account) {
            @Override
            public void onResponse(Capabilities response) {
                assertEquals(Version.of("20.0.1"), response.getNextcloudVersion());
            }

            @Override
            public void onError(Throwable throwable) {
                fail("Enabled maintenance mode should still return the capabilities");
            }
        }).get();


        // Anything else went wrong during the request

        doAnswer(invocation -> {
            //noinspection unchecked
            ((ResponseCallback<ParsedResponse<Capabilities>>) invocation.getArgument(1))
                    .onError(new NetworkErrorException());
            return null;
        }).when(serverAdapter).getCapabilities(anyString(), any());

        syncRepository.refreshCapabilities(new ResponseCallback<>(account) {
            @Override
            public void onResponse(Capabilities response) {
                fail("In case of any other exception the callback must not be responded successfully.");
            }

            @Override
            public void onError(Throwable throwable) {
                assertEquals(NetworkErrorException.class, throwable.getClass());
            }
        }).get();


        // No network available

        doThrow(new OfflineException()).when(serverAdapter).getCapabilities(anyString(), any());

        syncRepository.refreshCapabilities(new ResponseCallback<>(account) {
            @Override
            public void onResponse(Capabilities response) {
                fail("In case of an " + OfflineException.class.getSimpleName() + " the callback must not be responded successfully.");
            }

            @Override
            public void onError(Throwable throwable) {
                assertEquals(OfflineException.class, throwable.getClass());
            }
        }).get();
    }

    @Test
    public void testSynchronize() {
        final var syncManagerSpy = spy(syncRepository);

        LastSyncUtil.init(ApplicationProvider.getApplicationContext());
        final var account = new Account(1337L, "Test", "Peter", "example.com");
        final var capabilities = new Capabilities();
        capabilities.setDeckVersion(Version.minimumSupported());
        // Act as if refreshing capabilities is always successful
        doAnswer((invocation -> {
            //noinspection unchecked
            ((IResponseCallback<Capabilities>) invocation.getArgument(0)).onResponse(capabilities);
            return null;
        })).when(syncManagerSpy).refreshCapabilities(any());

        // Actual method invocation
        final var finalCallback = spy(new ResponseCallback<Boolean>(account) {
            @Override
            public void onResponse(Boolean response) {
            }
        });


        // Happy path

        final var syncHelper_positive = new SyncHelperMock(true);
        when(syncHelperFactory.create(any(), any(), any())).thenReturn(syncHelper_positive);

        syncManagerSpy.synchronize(finalCallback);

        verify(finalCallback, times(1)).onResponse(any());


        // Bad paths

        final var syncHelper_negative = new SyncHelperMock(false);
        when(syncHelperFactory.create(any(), any(), any())).thenReturn(syncHelper_negative);

        syncManagerSpy.synchronize(finalCallback);

        verify(finalCallback, times(1)).onError(any());
    }

    /**
     * A simple {@link SyncHelper} implementation which directly responds to sync requests
     */
    private class SyncHelperMock extends SyncHelper {
        private IResponseCallback<Boolean> cb;
        private final boolean success;

        private SyncHelperMock(boolean success) {
            super(serverAdapter, dataBaseAdapter, Instant.now());
            this.success = success;
        }

        @Override
        public SyncHelper setResponseCallback(@NonNull ResponseCallback<Boolean> callback) {
            this.cb = callback;
            return this;
        }

        @Override
        public <T extends IRemoteEntity> void doSyncFor(@NonNull AbstractSyncDataProvider<T> provider) {
            if (success) {
                cb.onResponse(true);
            } else {
                cb.onError(new RuntimeException("Bad path mocking"));
            }
        }

        @Override
        public <T extends IRemoteEntity> void doUpSyncFor(@NonNull AbstractSyncDataProvider<T> provider) {
            if (success) {
                cb.onResponse(true);
            } else {
                cb.onError(new RuntimeException("Bad path mocking"));
            }
        }
    }
}