diff options
| author | bubnikv <bubnikv@gmail.com> | 2016-11-04 17:03:51 +0300 |
|---|---|---|
| committer | bubnikv <bubnikv@gmail.com> | 2016-11-04 17:03:51 +0300 |
| commit | 6217622865eac20a00b0a1a55dfddd2dffd51ceb (patch) | |
| tree | 48e83b41785a5db90105645f9b2b1b357414f9b6 /lib | |
| parent | 3fc57ba8d85bef0ea6419cffe884e3ee151531ba (diff) | |
Hopefully a fix of https://github.com/prusa3d/Slic3r/issues/11
Replaced eval { die } construct with a bool return value indicating
success or failure of an automatic arrangement of parts on the print bed.
Don't know exactly what is happening here, but throwing a "die" inside
a XS function and then catching it inside an eval {} block is suspcious.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/Slic3r/GUI/Plater.pm | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/Slic3r/GUI/Plater.pm b/lib/Slic3r/GUI/Plater.pm index 5069f3e4a..54f66e221 100644 --- a/lib/Slic3r/GUI/Plater.pm +++ b/lib/Slic3r/GUI/Plater.pm @@ -965,9 +965,7 @@ sub arrange { $self->pause_background_process; my $bb = Slic3r::Geometry::BoundingBoxf->new_from_points($self->{config}->bed_shape); - eval { - $self->{model}->arrange_objects($self->GetFrame->config->min_object_distance, $bb); - }; + my $success = $self->{model}->arrange_objects($self->GetFrame->config->min_object_distance, $bb); # ignore arrange failures on purpose: user has visual feedback and we don't need to warn him # when parts don't fit in print bed |