diff options
| author | jnew-gh <github@hazelden.ca> | 2021-04-14 21:11:08 +0300 |
|---|---|---|
| committer | jnew-gh <github@hazelden.ca> | 2021-04-14 21:11:08 +0300 |
| commit | ccfb11927e260f85a8efa26e906b5e9702b24152 (patch) | |
| tree | 9cc5981c3b444193da070fbaa7ef6361f145fbd0 /dmarcts-report-viewer-report-data.php | |
| parent | 4c10b11f2ace0c22591679c036e7112ffa889510 (diff) | |
Use $dmarc_select[] array names when evaluating $dmarc_result
When evaluating $dmarc_result, use dmarc_select[] array names (like DMARC_FAIL and DMARC_PASS) instead of numbers, to make it easier to follow the code logic.
Diffstat (limited to 'dmarcts-report-viewer-report-data.php')
| -rw-r--r-- | dmarcts-report-viewer-report-data.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/dmarcts-report-viewer-report-data.php b/dmarcts-report-viewer-report-data.php index 0977a05..dca93ca 100644 --- a/dmarcts-report-viewer-report-data.php +++ b/dmarcts-report-viewer-report-data.php @@ -270,16 +270,16 @@ if( $sortorder ) { // dkimresult spfresult // -------------------------------------------------------------------------- switch ($dmarc_select) { - case 1: // DKIM and SPF Pass: Green + case "DMARC_PASS": // DKIM and SPF Pass: Green $dmarc_where = "(rptrecord.dkimresult='pass' AND rptrecord.spfresult='pass')"; break; - case 3: // DKIM or SPF Fail: Orange + case "DMARC_PASS_AND_FAIL": // DKIM or SPF Fail: Orange $dmarc_where = "(rptrecord.dkimresult='fail' OR rptrecord.spfresult='fail')"; break; - case 4: // DKIM and SPF Fail: Red + case "DMARC_FAIL": // DKIM and SPF Fail: Red $dmarc_where = "(rptrecord.dkimresult='fail' AND rptrecord.spfresult='fail')"; break; - case 2: // Other condition: Yellow + case "DMARC_OTHER_CONDITION": // Other condition: Yellow $dmarc_where = "NOT ((rptrecord.dkimresult='pass' AND rptrecord.spfresult='pass') OR (rptrecord.dkimresult='fail' OR rptrecord.spfresult='fail') OR (rptrecord.dkimresult='fail' AND rptrecord.spfresult='fail'))"; // In other words, "NOT" all three other conditions break; default: |