diff options
author | Michael Chan <michael.chan@broadcom.com> | 2021-09-20 09:51:52 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-09-20 12:08:36 +0300 |
commit | 5bed8b0704c9ecccc8f4a2c377d7c8e21090a82e (patch) | |
tree | 74c0cc38540b582e05f546fa92e620941b1a4d35 /drivers/ptp | |
parent | 563f23b002534176f49524b5ca0e1d94d8906c40 (diff) |
bnxt_en: Fix TX timeout when TX ring size is set to the smallest
The smallest TX ring size we support must fit a TX SKB with MAX_SKB_FRAGS
+ 1. Because the first TX BD for a packet is always a long TX BD, we
need an extra TX BD to fit this packet. Define BNXT_MIN_TX_DESC_CNT with
this value to make this more clear. The current code uses a minimum
that is off by 1. Fix it using this constant.
The tx_wake_thresh to determine when to wake up the TX queue is half the
ring size but we must have at least BNXT_MIN_TX_DESC_CNT for the next
packet which may have maximum fragments. So the comparison of the
available TX BDs with tx_wake_thresh should be >= instead of > in the
current code. Otherwise, at the smallest ring size, we will never wake
up the TX queue and will cause TX timeout.
Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadocm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp')
0 files changed, 0 insertions, 0 deletions