diff options
author | Rohit Sharma <rohit2sharma95@gmail.com> | 2021-01-13 23:13:30 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-01-13 23:13:30 +0300 |
commit | c9cd741aff6acedaedfd2cf96df06a8b46b4826a (patch) | |
tree | 01d31a107078fe4f30879e162df8e45336d5f4ef /js/src/util | |
parent | e34481b6eb5c7b9db35911f428cb96af6947741e (diff) |
Throw a `TypeError` instead of the generic `Error` (#32585)
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Diffstat (limited to 'js/src/util')
-rw-r--r-- | js/src/util/index.js | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/js/src/util/index.js b/js/src/util/index.js index 9ccad1cbb1..22d0a578b8 100644 --- a/js/src/util/index.js +++ b/js/src/util/index.js @@ -111,15 +111,14 @@ const typeCheckConfig = (componentName, config, configTypes) => { Object.keys(configTypes).forEach(property => { const expectedTypes = configTypes[property] const value = config[property] - const valueType = value && isElement(value) ? - 'element' : - toType(value) + const valueType = value && isElement(value) ? 'element' : toType(value) if (!new RegExp(expectedTypes).test(valueType)) { - throw new Error( + throw new TypeError( `${componentName.toUpperCase()}: ` + `Option "${property}" provided type "${valueType}" ` + - `but expected type "${expectedTypes}".`) + `but expected type "${expectedTypes}".` + ) } }) } |