diff options
| author | Patrick H. Lauke <redux@splintered.co.uk> | 2022-10-02 13:02:36 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-02 13:02:36 +0300 |
| commit | 0a5f6e078c9cb9ecca9ab90b3984c5f792a11bae (patch) | |
| tree | 30b35ef7f40ce7e3bf0cee59e602dfc2734c8d05 /js | |
| parent | 812f891bfca0697cb2ec628700b7bbadbd8bf93a (diff) | |
Use `<h1>` for all `modal-title` examples/uses (#37210)
* Use `fs-` font sizing classes where needed
* Also add info callout about heading hierarchy in modals
Diffstat (limited to 'js')
| -rw-r--r-- | js/tests/visual/modal.html | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index fd93c068ac..b738d9e81b 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -38,7 +38,7 @@ <div class="modal-dialog"> <div class="modal-content"> <div class="modal-header"> - <h4 class="modal-title" id="myModalLabel">Modal title</h4> + <h1 class="modal-title fs-4" id="myModalLabel">Modal title</h1> <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> </div> <div class="modal-body"> @@ -123,7 +123,7 @@ <div class="modal-dialog"> <div class="modal-content"> <div class="modal-header"> - <h4 class="modal-title" id="firefoxModalLabel">Firefox Bug Test</h4> + <h1 class="modal-title fs-4" id="firefoxModalLabel">Firefox Bug Test</h1> <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> </div> <div class="modal-body"> @@ -147,7 +147,7 @@ <div class="modal-dialog" style="transition-duration: inherit;"> <div class="modal-content"> <div class="modal-header"> - <h4 class="modal-title" id="slowModalLabel">Lorem slowly</h4> + <h1 class="modal-title fs-4" id="slowModalLabel">Lorem slowly</h1> <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> </div> <div class="modal-body"> @@ -188,7 +188,7 @@ Tall body content to force the page to have a scrollbar. </div> - <button type="button" class="btn btn-secondary btn-lg" data-bs-toggle="modal" data-bs-target="<div class="modal fade the-bad" tabindex="-1"><div class="modal-dialog"><div class="modal-content"><div class="modal-header"><button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button><h4 class="modal-title">The Bad Modal</h4></div><div class="modal-body">This modal's HTTML source code is declared inline, inside the data-bs-target attribute of it's show-button</div></div></div></div>"> + <button type="button" class="btn btn-secondary btn-lg" data-bs-toggle="modal" data-bs-target="<div class="modal fade the-bad" tabindex="-1"><div class="modal-dialog"><div class="modal-content"><div class="modal-header"><button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button><h1 class="modal-title fs-4">The Bad Modal</h1></div><div class="modal-body">This modal's HTTML source code is declared inline, inside the data-bs-target attribute of it's show-button</div></div></div></div>"> Modal with an XSS inside the data-bs-target </button> |