diff options
| author | Patrick H. Lauke <redux@splintered.co.uk> | 2021-01-27 18:31:16 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-27 18:31:16 +0300 |
| commit | 3aa3fda730ddb4d0231f4d2c83b255315f9f3684 (patch) | |
| tree | 183850f61f50db2cec25436b454fedbd6755f466 /scss | |
| parent | 61391c4ee2f000685f39be9f0c7369142d54dd35 (diff) | |
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next
- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links
* Clarify that controls can be button or link
* Update site/content/docs/5.0/components/carousel.md
Co-authored-by: Mark Otto <markd.otto@gmail.com>
* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Diffstat (limited to 'scss')
| -rw-r--r-- | scss/_carousel.scss | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/scss/_carousel.scss b/scss/_carousel.scss index d2e42bc10b..d9ff7e5352 100644 --- a/scss/_carousel.scss +++ b/scss/_carousel.scss @@ -98,8 +98,11 @@ align-items: center; // 2. vertically center contents justify-content: center; // 3. horizontally center contents width: $carousel-control-width; + padding: 0; color: $carousel-control-color; text-align: center; + background: none; + border: 0; opacity: $carousel-control-opacity; @include transition($carousel-control-transition); |