Rework how path_view::c_str's constructors are implemented to work around this weird bug only seen on clang with libstdc++ where the c_str() constructor never delegates. Now no c_str() constructor delegates to any other, which surely will fix this bug.

2 files changed, 1 insertions, 49 deletions

diff --git a/.github/workflows/unittests_macos.yml b/.github/workflows/unittests_macos.yml
index 14691592..7279a13f 100644
--- a/.github/workflows/unittests_macos.yml
+++ b/.github/workflows/unittests_macos.yml
@@ -61,51 +61,3 @@ jobs:
           check_name: Unit Test Results
           github_token: ${{ secrets.GITHUB_TOKEN }}
           files: '**/merged_junit_results.xml'
-
-  publish-binaries:
-    name: "Publish Prebuilt Binaries"
-    needs: [MacOS]
-    runs-on: ubuntu-latest
-    if: success()
-
-    steps:
-      - uses: actions/checkout@v2
-      
-      - name: Download Artifacts
-        uses: actions/download-artifact@v2
-        with:
-          path: artifacts
-
-      - name: Create Release
-        id: create_release
-        uses: actions/create-release@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          tag_name: ${{ github.ref }}
-          release_name: Commit ${{ github.sha }}
-          body: ${{ github.event.head_commit.message }}
-          draft: false
-          prerelease: true
-          
-      - name: Upload Release Asset 1
-        id: upload-release-asset-1
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ steps.create_release.outputs.upload_url }}
-          asset_path: artifacts/Mac OS error_code prebuilt binaries/llfio-v2.0-binaries-darwin-x64.tgz
-          asset_name: llfio-v2.0-binaries-darwin-x64-error_code.tgz
-          asset_content_type: application/gzip
-          
-      - name: Upload Release Asset 2
-        id: upload-release-asset-2
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ steps.create_release.outputs.upload_url }}
-          asset_path: artifacts/Mac OS status_code prebuilt binaries/llfio-v2.0-binaries-darwin-x64.tgz
-          asset_name: llfio-v2.0-binaries-darwin-x64-status_code.tgz
-          asset_content_type: application/gzip
diff --git a/.github/workflows/unittests_windows.yml b/.github/workflows/unittests_windows.yml
index 86e07c80..1582bb47 100644
--- a/.github/workflows/unittests_windows.yml
+++ b/.github/workflows/unittests_windows.yml
@@ -28,7 +28,7 @@ jobs:
        if [ "${{ matrix.configuration }}" = "status_code" ]; then
          export CMAKE_CONFIGURE_OPTIONS="-DLLFIO_USE_EXPERIMENTAL_SG14_STATUS_CODE=ON"
        fi
-       ctest -S .ci.cmake -VV --timeout 900 "-DCTEST_CONFIGURE_OPTIONS=$CMAKE_CONFIGURE_OPTIONS"
+       ctest -S .ci.cmake -VV --timeout 900 "-DCTEST_CONFIGURE_OPTIONS=$CMAKE_CONFIGURE_OPTIONS" -DCTEST_SITE=$NAME
       
     - name: Upload Prebuilt Binaries
       uses: actions/upload-artifact@v2