traversal: more robust error handling

This fixes a bug in walkdir that happened on Windows when following
symlinks. It was triggered when opening a handle to the symlink failed.
In particular, this resulted in the two stacks in the walkdir iterator
getting out of sync. At some point, this tripped a panic when popping
from one stack would be fine but popping from the other failed because
it was empty.

We fix this by only pushing to both stacks if and only if both pushes
would succeed.

This bug was found via ripgrep. See:
https://github.com/BurntSushi/ripgrep/issues/633#issuecomment-339076246

1 files changed, 3 insertions, 1 deletions

diff --git a/src/lib.rs b/src/lib.rs
index 8808692..07f7b7a 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -851,13 +851,15 @@ impl IntoIter {
             });
             list = DirList::Closed(entries.into_iter());
         }
-        self.stack_list.push(list);
         if self.opts.follow_links {
             let ancestor = Ancestor::new(&dent).map_err(|err| {
                 Error::from_io(self.depth, err)
             })?;
             self.stack_path.push(ancestor);
         }
+        // We push this after stack_path since creating the Ancestor can fail.
+        // If it fails, then we return the error and won't descend.
+        self.stack_list.push(list);
         Ok(())
     }