Welcome to mirror list, hosted at ThFree Co, Russian Federation.

nfd_win.cpp « nfd - github.com/wolfpld/tracy.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
blob: 991e507171f3e5c6069a51ecffa0efa4f92bd3ba (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
/*
  Native File Dialog Extended
  Repository: https://github.com/btzy/nativefiledialog-extended
  License: Zlib
  Author: Bernard Teo
 */

/* only locally define UNICODE in this compilation unit */
#ifndef UNICODE
#define UNICODE
#endif

#ifdef __MINGW32__
// Explicitly setting NTDDI version, this is necessary for the MinGW compiler
#define NTDDI_VERSION NTDDI_VISTA
#define _WIN32_WINNT _WIN32_WINNT_VISTA
#endif

#if _MSC_VER
// see
// https://developercommunity.visualstudio.com/content/problem/185399/error-c2760-in-combaseapih-with-windows-sdk-81-and.html
struct IUnknown;  // Workaround for "combaseapi.h(229): error C2187: syntax error: 'identifier' was
                  // unexpected here" when using /permissive-
#endif

#include <assert.h>
#include <shobjidl.h>
#include <stdio.h>
#include <wchar.h>
#include <windows.h>
#include "nfd.h"

namespace {

/* current error */
const char* g_errorstr = nullptr;

void NFDi_SetError(const char* msg) {
    g_errorstr = msg;
}

template <typename T = void>
T* NFDi_Malloc(size_t bytes) {
    void* ptr = malloc(bytes);
    if (!ptr) NFDi_SetError("NFDi_Malloc failed.");

    return static_cast<T*>(ptr);
}

template <typename T>
void NFDi_Free(T* ptr) {
    assert(ptr);
    free(static_cast<void*>(ptr));
}

/* guard objects */
template <typename T>
struct Release_Guard {
    T* data;
    Release_Guard(T* releasable) noexcept : data(releasable) {}
    ~Release_Guard() { data->Release(); }
};

template <typename T>
struct Free_Guard {
    T* data;
    Free_Guard(T* freeable) noexcept : data(freeable) {}
    ~Free_Guard() { NFDi_Free(data); }
};

template <typename T>
struct FreeCheck_Guard {
    T* data;
    FreeCheck_Guard(T* freeable = nullptr) noexcept : data(freeable) {}
    ~FreeCheck_Guard() {
        if (data) NFDi_Free(data);
    }
};

/* helper functions */
nfdresult_t AddFiltersToDialog(::IFileDialog* fileOpenDialog,
                               const nfdnfilteritem_t* filterList,
                               nfdfiltersize_t filterCount) {
    /* filterCount plus 1 because we hardcode the *.* wildcard after the while loop */
    COMDLG_FILTERSPEC* specList =
        NFDi_Malloc<COMDLG_FILTERSPEC>(sizeof(COMDLG_FILTERSPEC) * (filterCount + 1));
    if (!specList) {
        return NFD_ERROR;
    }

    /* ad-hoc RAII object to free memory when destructing */
    struct COMDLG_FILTERSPEC_Guard {
        COMDLG_FILTERSPEC* _specList;
        nfdfiltersize_t index;
        COMDLG_FILTERSPEC_Guard(COMDLG_FILTERSPEC* specList) noexcept
            : _specList(specList), index(0) {}
        ~COMDLG_FILTERSPEC_Guard() {
            for (--index; index != static_cast<nfdfiltersize_t>(-1); --index) {
                NFDi_Free(const_cast<nfdnchar_t*>(_specList[index].pszSpec));
            }
            NFDi_Free(_specList);
        }
    };

    COMDLG_FILTERSPEC_Guard specListGuard(specList);

    if (filterCount) {
        assert(filterList);

        // we have filters to add ... format and add them

        // use the index that comes from the RAII object (instead of making a copy), so the RAII
        // object will know which memory to free
        nfdfiltersize_t& index = specListGuard.index;

        for (; index != filterCount; ++index) {
            // set the friendly name of this filter
            specList[index].pszName = filterList[index].name;

            // set the specification of this filter...

            // count number of file extensions
            size_t sep = 1;
            for (const nfdnchar_t* p_spec = filterList[index].spec; *p_spec; ++p_spec) {
                if (*p_spec == L',') {
                    ++sep;
                }
            }

            // calculate space needed (including the trailing '\0')
            size_t specSize = sep * 2 + wcslen(filterList[index].spec) + 1;

            // malloc the required memory and populate it
            nfdnchar_t* specBuf = NFDi_Malloc<nfdnchar_t>(sizeof(nfdnchar_t) * specSize);

            if (!specBuf) {
                // automatic freeing of memory via COMDLG_FILTERSPEC_Guard
                return NFD_ERROR;
            }

            // convert "png,jpg" to "*.png;*.jpg" as required by Windows ...
            nfdnchar_t* p_specBuf = specBuf;
            *p_specBuf++ = L'*';
            *p_specBuf++ = L'.';
            for (const nfdnchar_t* p_spec = filterList[index].spec; *p_spec; ++p_spec) {
                if (*p_spec == L',') {
                    *p_specBuf++ = L';';
                    *p_specBuf++ = L'*';
                    *p_specBuf++ = L'.';
                } else {
                    *p_specBuf++ = *p_spec;
                }
            }
            *p_specBuf++ = L'\0';

            // assert that we had allocated exactly the correct amount of memory that we used
            assert(static_cast<size_t>(p_specBuf - specBuf) == specSize);

            // save the buffer to the guard object
            specList[index].pszSpec = specBuf;
        }
    }

    /* Add wildcard */
    specList[filterCount].pszName = L"All files";
    specList[filterCount].pszSpec = L"*.*";

    // add the filter to the dialog
    if (!SUCCEEDED(fileOpenDialog->SetFileTypes(filterCount + 1, specList))) {
        NFDi_SetError("Failed to set the allowable file types for the drop-down menu.");
        return NFD_ERROR;
    }

    // automatic freeing of memory via COMDLG_FILTERSPEC_Guard
    return NFD_OKAY;
}

/* call after AddFiltersToDialog */
nfdresult_t SetDefaultExtension(::IFileDialog* fileOpenDialog,
                                const nfdnfilteritem_t* filterList,
                                nfdfiltersize_t filterCount) {
    // if there are no filters, then don't set default extensions
    if (!filterCount) {
        return NFD_OKAY;
    }

    assert(filterList);

    // set the first item as the default index, and set the default extension
    if (!SUCCEEDED(fileOpenDialog->SetFileTypeIndex(1))) {
        NFDi_SetError("Failed to set the selected file type index.");
        return NFD_ERROR;
    }

    // set the first item as the default file extension
    const nfdnchar_t* p_spec = filterList[0].spec;
    for (; *p_spec; ++p_spec) {
        if (*p_spec == ',') {
            break;
        }
    }
    if (*p_spec) {
        // multiple file extensions for this type (need to allocate memory)
        size_t numChars = p_spec - filterList[0].spec;
        // allocate one more char space for the '\0'
        nfdnchar_t* extnBuf = NFDi_Malloc<nfdnchar_t>(sizeof(nfdnchar_t) * (numChars + 1));
        if (!extnBuf) {
            return NFD_ERROR;
        }
        Free_Guard<nfdnchar_t> extnBufGuard(extnBuf);

        // copy the extension
        for (size_t i = 0; i != numChars; ++i) {
            extnBuf[i] = filterList[0].spec[i];
        }
        // pad with trailing '\0'
        extnBuf[numChars] = L'\0';

        if (!SUCCEEDED(fileOpenDialog->SetDefaultExtension(extnBuf))) {
            NFDi_SetError("Failed to set default extension.");
            return NFD_ERROR;
        }
    } else {
        // single file extension for this type (no need to allocate memory)
        if (!SUCCEEDED(fileOpenDialog->SetDefaultExtension(filterList[0].spec))) {
            NFDi_SetError("Failed to set default extension.");
            return NFD_ERROR;
        }
    }

    return NFD_OKAY;
}

nfdresult_t SetDefaultPath(IFileDialog* dialog, const nfdnchar_t* defaultPath) {
    if (!defaultPath || !*defaultPath) return NFD_OKAY;

    IShellItem* folder;
    HRESULT result = SHCreateItemFromParsingName(defaultPath, nullptr, IID_PPV_ARGS(&folder));

    // Valid non results.
    if (result == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) ||
        result == HRESULT_FROM_WIN32(ERROR_INVALID_DRIVE)) {
        return NFD_OKAY;
    }

    if (!SUCCEEDED(result)) {
        NFDi_SetError("Failed to create ShellItem for setting the default path.");
        return NFD_ERROR;
    }

    Release_Guard<IShellItem> folderGuard(folder);

    // SetDefaultFolder() might use another recently used folder if available, so the user doesn't
    // need to keep navigating back to the default folder (recommended by Windows). change to
    // SetFolder() if you always want to use the default folder
    if (!SUCCEEDED(dialog->SetDefaultFolder(folder))) {
        NFDi_SetError("Failed to set default path.");
        return NFD_ERROR;
    }

    return NFD_OKAY;
}

nfdresult_t SetDefaultName(IFileDialog* dialog, const nfdnchar_t* defaultName) {
    if (!defaultName || !*defaultName) return NFD_OKAY;

    if (!SUCCEEDED(dialog->SetFileName(defaultName))) {
        NFDi_SetError("Failed to set default file name.");
        return NFD_ERROR;
    }

    return NFD_OKAY;
}

nfdresult_t AddOptions(IFileDialog* dialog, FILEOPENDIALOGOPTIONS options) {
    FILEOPENDIALOGOPTIONS existingOptions;
    if (!SUCCEEDED(dialog->GetOptions(&existingOptions))) {
        NFDi_SetError("Failed to get options.");
        return NFD_ERROR;
    }
    if (!SUCCEEDED(dialog->SetOptions(existingOptions | options))) {
        NFDi_SetError("Failed to set options.");
        return NFD_ERROR;
    }
    return NFD_OKAY;
}
}  // namespace

const char* NFD_GetError(void) {
    return g_errorstr;
}

void NFD_ClearError(void) {
    NFDi_SetError(nullptr);
}

/* public */

namespace {
// The user might have initialized with COINIT_MULTITHREADED before,
// in which case we will fail to do CoInitializeEx(), but file dialogs will still work.
// See https://github.com/mlabbe/nativefiledialog/issues/72 for more information.
bool needs_uninitialize;
}  // namespace

nfdresult_t NFD_Init(void) {
    // Init COM library.
    HRESULT result =
        ::CoInitializeEx(nullptr, ::COINIT_APARTMENTTHREADED | ::COINIT_DISABLE_OLE1DDE);

    if (SUCCEEDED(result)) {
        needs_uninitialize = true;
        return NFD_OKAY;
    } else if (result == RPC_E_CHANGED_MODE) {
        // If this happens, the user already initialized COM using COINIT_MULTITHREADED,
        // so COM will still work, but we shouldn't uninitialize it later.
        needs_uninitialize = false;
        return NFD_OKAY;
    } else {
        NFDi_SetError("Failed to initialize COM.");
        return NFD_ERROR;
    }
}
void NFD_Quit(void) {
    if (needs_uninitialize) ::CoUninitialize();
}

void NFD_FreePathN(nfdnchar_t* filePath) {
    assert(filePath);
    ::CoTaskMemFree(filePath);
}

nfdresult_t NFD_OpenDialogN(nfdnchar_t** outPath,
                            const nfdnfilteritem_t* filterList,
                            nfdfiltersize_t filterCount,
                            const nfdnchar_t* defaultPath) {
    ::IFileOpenDialog* fileOpenDialog;

    // Create dialog
    HRESULT result = ::CoCreateInstance(::CLSID_FileOpenDialog,
                                        nullptr,
                                        CLSCTX_ALL,
                                        ::IID_IFileOpenDialog,
                                        reinterpret_cast<void**>(&fileOpenDialog));

    if (!SUCCEEDED(result)) {
        NFDi_SetError("Could not create dialog.");
        return NFD_ERROR;
    }

    // make sure we remember to free the dialog
    Release_Guard<::IFileOpenDialog> fileOpenDialogGuard(fileOpenDialog);

    // Build the filter list
    if (!AddFiltersToDialog(fileOpenDialog, filterList, filterCount)) {
        return NFD_ERROR;
    }

    // Set auto-completed default extension
    if (!SetDefaultExtension(fileOpenDialog, filterList, filterCount)) {
        return NFD_ERROR;
    }

    // Set the default path
    if (!SetDefaultPath(fileOpenDialog, defaultPath)) {
        return NFD_ERROR;
    }

    // Only show file system items
    if (!AddOptions(fileOpenDialog, ::FOS_FORCEFILESYSTEM)) {
        return NFD_ERROR;
    }

    // Show the dialog.
    result = fileOpenDialog->Show(nullptr);
    if (SUCCEEDED(result)) {
        // Get the file name
        ::IShellItem* psiResult;
        result = fileOpenDialog->GetResult(&psiResult);
        if (!SUCCEEDED(result)) {
            NFDi_SetError("Could not get shell item from dialog.");
            return NFD_ERROR;
        }
        Release_Guard<::IShellItem> psiResultGuard(psiResult);

        nfdnchar_t* filePath;
        result = psiResult->GetDisplayName(::SIGDN_FILESYSPATH, &filePath);
        if (!SUCCEEDED(result)) {
            NFDi_SetError("Could not get file path from shell item returned by dialog.");
            return NFD_ERROR;
        }

        *outPath = filePath;

        return NFD_OKAY;
    } else if (result == HRESULT_FROM_WIN32(ERROR_CANCELLED)) {
        return NFD_CANCEL;
    } else {
        NFDi_SetError("File dialog box show failed.");
        return NFD_ERROR;
    }
}

nfdresult_t NFD_OpenDialogMultipleN(const nfdpathset_t** outPaths,
                                    const nfdnfilteritem_t* filterList,
                                    nfdfiltersize_t filterCount,
                                    const nfdnchar_t* defaultPath) {
    ::IFileOpenDialog* fileOpenDialog(nullptr);

    // Create dialog
    HRESULT result = ::CoCreateInstance(::CLSID_FileOpenDialog,
                                        nullptr,
                                        CLSCTX_ALL,
                                        ::IID_IFileOpenDialog,
                                        reinterpret_cast<void**>(&fileOpenDialog));

    if (!SUCCEEDED(result)) {
        NFDi_SetError("Could not create dialog.");
        return NFD_ERROR;
    }

    // make sure we remember to free the dialog
    Release_Guard<::IFileOpenDialog> fileOpenDialogGuard(fileOpenDialog);

    // Build the filter list
    if (!AddFiltersToDialog(fileOpenDialog, filterList, filterCount)) {
        return NFD_ERROR;
    }

    // Set auto-completed default extension
    if (!SetDefaultExtension(fileOpenDialog, filterList, filterCount)) {
        return NFD_ERROR;
    }

    // Set the default path
    if (!SetDefaultPath(fileOpenDialog, defaultPath)) {
        return NFD_ERROR;
    }

    // Set a flag for multiple options and file system items only
    if (!AddOptions(fileOpenDialog, ::FOS_FORCEFILESYSTEM | ::FOS_ALLOWMULTISELECT)) {
        return NFD_ERROR;
    }

    // Show the dialog.
    result = fileOpenDialog->Show(nullptr);
    if (SUCCEEDED(result)) {
        ::IShellItemArray* shellItems;
        result = fileOpenDialog->GetResults(&shellItems);
        if (!SUCCEEDED(result)) {
            NFDi_SetError("Could not get shell items.");
            return NFD_ERROR;
        }

        // save the path set to the output
        *outPaths = static_cast<void*>(shellItems);

        return NFD_OKAY;
    } else if (result == HRESULT_FROM_WIN32(ERROR_CANCELLED)) {
        return NFD_CANCEL;
    } else {
        NFDi_SetError("File dialog box show failed.");
        return NFD_ERROR;
    }
}

nfdresult_t NFD_SaveDialogN(nfdnchar_t** outPath,
                            const nfdnfilteritem_t* filterList,
                            nfdfiltersize_t filterCount,
                            const nfdnchar_t* defaultPath,
                            const nfdnchar_t* defaultName) {
    ::IFileSaveDialog* fileSaveDialog;

    // Create dialog
    HRESULT result = ::CoCreateInstance(::CLSID_FileSaveDialog,
                                        nullptr,
                                        CLSCTX_ALL,
                                        ::IID_IFileSaveDialog,
                                        reinterpret_cast<void**>(&fileSaveDialog));

    if (!SUCCEEDED(result)) {
        NFDi_SetError("Could not create dialog.");
        return NFD_ERROR;
    }

    // make sure we remember to free the dialog
    Release_Guard<::IFileSaveDialog> fileSaveDialogGuard(fileSaveDialog);

    // Build the filter list
    if (!AddFiltersToDialog(fileSaveDialog, filterList, filterCount)) {
        return NFD_ERROR;
    }

    // Set default extension
    if (!SetDefaultExtension(fileSaveDialog, filterList, filterCount)) {
        return NFD_ERROR;
    }

    // Set the default path
    if (!SetDefaultPath(fileSaveDialog, defaultPath)) {
        return NFD_ERROR;
    }

    // Set the default name
    if (!SetDefaultName(fileSaveDialog, defaultName)) {
        return NFD_ERROR;
    }

    // Only show file system items
    if (!AddOptions(fileSaveDialog, ::FOS_FORCEFILESYSTEM)) {
        return NFD_ERROR;
    }

    // Show the dialog.
    result = fileSaveDialog->Show(nullptr);
    if (SUCCEEDED(result)) {
        // Get the file name
        ::IShellItem* psiResult;
        result = fileSaveDialog->GetResult(&psiResult);
        if (!SUCCEEDED(result)) {
            NFDi_SetError("Could not get shell item from dialog.");
            return NFD_ERROR;
        }
        Release_Guard<::IShellItem> psiResultGuard(psiResult);

        nfdnchar_t* filePath;
        result = psiResult->GetDisplayName(::SIGDN_FILESYSPATH, &filePath);
        if (!SUCCEEDED(result)) {
            NFDi_SetError("Could not get file path from shell item returned by dialog.");
            return NFD_ERROR;
        }

        *outPath = filePath;

        return NFD_OKAY;
    } else if (result == HRESULT_FROM_WIN32(ERROR_CANCELLED)) {
        return NFD_CANCEL;
    } else {
        NFDi_SetError("File dialog box show failed.");
        return NFD_ERROR;
    }
}

nfdresult_t NFD_PickFolderN(nfdnchar_t** outPath, const nfdnchar_t* defaultPath) {
    ::IFileOpenDialog* fileOpenDialog;

    // Create dialog
    if (!SUCCEEDED(::CoCreateInstance(::CLSID_FileOpenDialog,
                                      nullptr,
                                      CLSCTX_ALL,
                                      ::IID_IFileOpenDialog,
                                      reinterpret_cast<void**>(&fileOpenDialog)))) {
        NFDi_SetError("Could not create dialog.");
        return NFD_ERROR;
    }

    Release_Guard<::IFileOpenDialog> fileOpenDialogGuard(fileOpenDialog);

    // Set the default path
    if (!SetDefaultPath(fileOpenDialog, defaultPath)) {
        return NFD_ERROR;
    }

    // Only show items that are folders and on the file system
    if (!AddOptions(fileOpenDialog, ::FOS_FORCEFILESYSTEM | ::FOS_PICKFOLDERS)) {
        return NFD_ERROR;
    }

    // Show the dialog to the user
    const HRESULT result = fileOpenDialog->Show(nullptr);
    if (result == HRESULT_FROM_WIN32(ERROR_CANCELLED)) {
        return NFD_CANCEL;
    } else if (!SUCCEEDED(result)) {
        NFDi_SetError("File dialog box show failed.");
        return NFD_ERROR;
    }

    // Get the shell item result
    ::IShellItem* psiResult;
    if (!SUCCEEDED(fileOpenDialog->GetResult(&psiResult))) {
        return NFD_ERROR;
    }

    Release_Guard<::IShellItem> psiResultGuard(psiResult);

    // Finally get the path
    nfdnchar_t* filePath;
    // Why are we not using SIGDN_FILESYSPATH?
    if (!SUCCEEDED(psiResult->GetDisplayName(::SIGDN_DESKTOPABSOLUTEPARSING, &filePath))) {
        NFDi_SetError("Could not get file path from shell item returned by dialog.");
        return NFD_ERROR;
    }

    *outPath = filePath;

    return NFD_OKAY;
}

nfdresult_t NFD_PathSet_GetCount(const nfdpathset_t* pathSet, nfdpathsetsize_t* count) {
    assert(pathSet);
    // const_cast because methods on IShellItemArray aren't const, but it should act like const to
    // the caller
    ::IShellItemArray* psiaPathSet =
        const_cast<::IShellItemArray*>(static_cast<const ::IShellItemArray*>(pathSet));

    DWORD numPaths;
    if (!SUCCEEDED(psiaPathSet->GetCount(&numPaths))) {
        NFDi_SetError("Could not get path count.");
        return NFD_ERROR;
    }
    *count = numPaths;
    return NFD_OKAY;
}

nfdresult_t NFD_PathSet_GetPathN(const nfdpathset_t* pathSet,
                                 nfdpathsetsize_t index,
                                 nfdnchar_t** outPath) {
    assert(pathSet);
    // const_cast because methods on IShellItemArray aren't const, but it should act like const to
    // the caller
    ::IShellItemArray* psiaPathSet =
        const_cast<::IShellItemArray*>(static_cast<const ::IShellItemArray*>(pathSet));

    ::IShellItem* psiPath;
    if (!SUCCEEDED(psiaPathSet->GetItemAt(index, &psiPath))) {
        NFDi_SetError("Could not get shell item.");
        return NFD_ERROR;
    }

    Release_Guard<::IShellItem> psiPathGuard(psiPath);

    nfdnchar_t* name;
    if (!SUCCEEDED(psiPath->GetDisplayName(::SIGDN_FILESYSPATH, &name))) {
        NFDi_SetError("Could not get file path from shell item.");
        return NFD_ERROR;
    }

    *outPath = name;
    return NFD_OKAY;
}

nfdresult_t NFD_PathSet_GetEnum(const nfdpathset_t* pathSet, nfdpathsetenum_t* outEnumerator) {
    assert(pathSet);
    // const_cast because methods on IShellItemArray aren't const, but it should act like const to
    // the caller
    ::IShellItemArray* psiaPathSet =
        const_cast<::IShellItemArray*>(static_cast<const ::IShellItemArray*>(pathSet));

    ::IEnumShellItems* pesiPaths;
    if (!SUCCEEDED(psiaPathSet->EnumItems(&pesiPaths))) {
        NFDi_SetError("Could not get enumerator.");
        return NFD_ERROR;
    }

    outEnumerator->ptr = static_cast<void*>(pesiPaths);
    return NFD_OKAY;
}

void NFD_PathSet_FreeEnum(nfdpathsetenum_t* enumerator) {
    assert(enumerator->ptr);

    ::IEnumShellItems* pesiPaths = static_cast<::IEnumShellItems*>(enumerator->ptr);

    // free the enumerator memory
    pesiPaths->Release();
}

nfdresult_t NFD_PathSet_EnumNextN(nfdpathsetenum_t* enumerator, nfdnchar_t** outPath) {
    assert(enumerator->ptr);

    ::IEnumShellItems* pesiPaths = static_cast<::IEnumShellItems*>(enumerator->ptr);

    ::IShellItem* psiPath;
    HRESULT res = pesiPaths->Next(1, &psiPath, NULL);
    if (!SUCCEEDED(res)) {
        NFDi_SetError("Could not get next item of enumerator.");
        return NFD_ERROR;
    }
    if (res != S_OK) {
        *outPath = nullptr;
        return NFD_OKAY;
    }

    Release_Guard<::IShellItem> psiPathGuard(psiPath);

    nfdnchar_t* name;
    if (!SUCCEEDED(psiPath->GetDisplayName(::SIGDN_FILESYSPATH, &name))) {
        NFDi_SetError("Could not get file path from shell item.");
        return NFD_ERROR;
    }

    *outPath = name;
    return NFD_OKAY;
}

void NFD_PathSet_Free(const nfdpathset_t* pathSet) {
    assert(pathSet);
    // const_cast because methods on IShellItemArray aren't const, but it should act like const to
    // the caller
    ::IShellItemArray* psiaPathSet =
        const_cast<::IShellItemArray*>(static_cast<const ::IShellItemArray*>(pathSet));

    // free the path set memory
    psiaPathSet->Release();
}

namespace {
// allocs the space in outStr -- call NFDi_Free()
nfdresult_t CopyCharToWChar(const nfdu8char_t* inStr, nfdnchar_t*& outStr) {
    int charsNeeded = MultiByteToWideChar(CP_UTF8, 0, inStr, -1, nullptr, 0);
    assert(charsNeeded);

    nfdnchar_t* tmp_outStr = NFDi_Malloc<nfdnchar_t>(sizeof(nfdnchar_t) * charsNeeded);
    if (!tmp_outStr) {
        return NFD_ERROR;
    }

    int ret = MultiByteToWideChar(CP_UTF8, 0, inStr, -1, tmp_outStr, charsNeeded);
    assert(ret && ret == charsNeeded);
    (void)ret;  // prevent warning in release build
    outStr = tmp_outStr;
    return NFD_OKAY;
}

// allocs the space in outPath -- call NFDi_Free()
nfdresult_t CopyWCharToNFDChar(const nfdnchar_t* inStr, nfdu8char_t*& outStr) {
    int bytesNeeded = WideCharToMultiByte(CP_UTF8, 0, inStr, -1, nullptr, 0, nullptr, nullptr);
    assert(bytesNeeded);

    nfdu8char_t* tmp_outStr = NFDi_Malloc<nfdu8char_t>(sizeof(nfdu8char_t) * bytesNeeded);
    if (!tmp_outStr) {
        return NFD_ERROR;
    }

    int ret = WideCharToMultiByte(CP_UTF8, 0, inStr, -1, tmp_outStr, bytesNeeded, nullptr, nullptr);
    assert(ret && ret == bytesNeeded);
    (void)ret;  // prevent warning in release build
    outStr = tmp_outStr;
    return NFD_OKAY;
}

struct FilterItem_Guard {
    nfdnfilteritem_t* data;
    nfdfiltersize_t index;
    FilterItem_Guard() noexcept : data(nullptr), index(0) {}
    ~FilterItem_Guard() {
        assert(data || index == 0);
        for (--index; index != static_cast<nfdfiltersize_t>(-1); --index) {
            NFDi_Free(const_cast<nfdnchar_t*>(data[index].spec));
            NFDi_Free(const_cast<nfdnchar_t*>(data[index].name));
        }
        if (data) NFDi_Free(data);
    }
};

nfdresult_t CopyFilterItem(const nfdu8filteritem_t* filterList,
                           nfdfiltersize_t count,
                           FilterItem_Guard& filterItemsNGuard) {
    if (count) {
        nfdnfilteritem_t*& filterItemsN = filterItemsNGuard.data;
        filterItemsN = NFDi_Malloc<nfdnfilteritem_t>(sizeof(nfdnfilteritem_t) * count);
        if (!filterItemsN) {
            return NFD_ERROR;
        }

        nfdfiltersize_t& index = filterItemsNGuard.index;
        for (; index != count; ++index) {
            nfdresult_t res = CopyCharToWChar(filterList[index].name,
                                              const_cast<nfdnchar_t*&>(filterItemsN[index].name));
            if (!res) {
                return NFD_ERROR;
            }
            res = CopyCharToWChar(filterList[index].spec,
                                  const_cast<nfdnchar_t*&>(filterItemsN[index].spec));
            if (!res) {
                // remember to free the name, because we also created it (and it won't be protected
                // by the guard, because we have not incremented the index)
                NFDi_Free(const_cast<nfdnchar_t*>(filterItemsN[index].name));
                return NFD_ERROR;
            }
        }
    }
    return NFD_OKAY;
}
nfdresult_t ConvertU8ToNative(const nfdu8char_t* u8Text, FreeCheck_Guard<nfdnchar_t>& nativeText) {
    if (u8Text) {
        nfdresult_t res = CopyCharToWChar(u8Text, nativeText.data);
        if (!res) {
            return NFD_ERROR;
        }
    }
    return NFD_OKAY;
}
void NormalizePathSeparator(nfdnchar_t* path) {
    if (path) {
        for (; *path; ++path) {
            if (*path == L'/') *path = L'\\';
        }
    }
}
}  // namespace

void NFD_FreePathU8(nfdu8char_t* outPath) {
    NFDi_Free(outPath);
}

nfdresult_t NFD_OpenDialogU8(nfdu8char_t** outPath,
                             const nfdu8filteritem_t* filterList,
                             nfdfiltersize_t count,
                             const nfdu8char_t* defaultPath) {
    // populate the real nfdnfilteritem_t
    FilterItem_Guard filterItemsNGuard;
    if (!CopyFilterItem(filterList, count, filterItemsNGuard)) {
        return NFD_ERROR;
    }

    // convert and normalize the default path, but only if it is not nullptr
    FreeCheck_Guard<nfdnchar_t> defaultPathNGuard;
    ConvertU8ToNative(defaultPath, defaultPathNGuard);
    NormalizePathSeparator(defaultPathNGuard.data);

    // call the native function
    nfdnchar_t* outPathN;
    nfdresult_t res =
        NFD_OpenDialogN(&outPathN, filterItemsNGuard.data, count, defaultPathNGuard.data);

    if (res != NFD_OKAY) {
        return res;
    }

    // convert the outPath to UTF-8
    res = CopyWCharToNFDChar(outPathN, *outPath);

    // free the native out path, and return the result
    NFD_FreePathN(outPathN);
    return res;
}

/* multiple file open dialog */
/* It is the caller's responsibility to free `outPaths` via NFD_PathSet_Free() if this function
 * returns NFD_OKAY */
nfdresult_t NFD_OpenDialogMultipleU8(const nfdpathset_t** outPaths,
                                     const nfdu8filteritem_t* filterList,
                                     nfdfiltersize_t count,
                                     const nfdu8char_t* defaultPath) {
    // populate the real nfdnfilteritem_t
    FilterItem_Guard filterItemsNGuard;
    if (!CopyFilterItem(filterList, count, filterItemsNGuard)) {
        return NFD_ERROR;
    }

    // convert and normalize the default path, but only if it is not nullptr
    FreeCheck_Guard<nfdnchar_t> defaultPathNGuard;
    ConvertU8ToNative(defaultPath, defaultPathNGuard);
    NormalizePathSeparator(defaultPathNGuard.data);

    // call the native function
    return NFD_OpenDialogMultipleN(outPaths, filterItemsNGuard.data, count, defaultPathNGuard.data);
}

/* save dialog */
/* It is the caller's responsibility to free `outPath` via NFD_FreePathU8() if this function returns
 * NFD_OKAY */
nfdresult_t NFD_SaveDialogU8(nfdu8char_t** outPath,
                             const nfdu8filteritem_t* filterList,
                             nfdfiltersize_t count,
                             const nfdu8char_t* defaultPath,
                             const nfdu8char_t* defaultName) {
    // populate the real nfdnfilteritem_t
    FilterItem_Guard filterItemsNGuard;
    if (!CopyFilterItem(filterList, count, filterItemsNGuard)) {
        return NFD_ERROR;
    }

    // convert and normalize the default path, but only if it is not nullptr
    FreeCheck_Guard<nfdnchar_t> defaultPathNGuard;
    ConvertU8ToNative(defaultPath, defaultPathNGuard);
    NormalizePathSeparator(defaultPathNGuard.data);

    // convert the default name, but only if it is not nullptr
    FreeCheck_Guard<nfdnchar_t> defaultNameNGuard;
    ConvertU8ToNative(defaultName, defaultNameNGuard);

    // call the native function
    nfdnchar_t* outPathN;
    nfdresult_t res = NFD_SaveDialogN(
        &outPathN, filterItemsNGuard.data, count, defaultPathNGuard.data, defaultNameNGuard.data);

    if (res != NFD_OKAY) {
        return res;
    }

    // convert the outPath to UTF-8
    res = CopyWCharToNFDChar(outPathN, *outPath);

    // free the native out path, and return the result
    NFD_FreePathN(outPathN);
    return res;
}

/* select folder dialog */
/* It is the caller's responsibility to free `outPath` via NFD_FreePathU8() if this function returns
 * NFD_OKAY */
nfdresult_t NFD_PickFolderU8(nfdu8char_t** outPath, const nfdu8char_t* defaultPath) {
    // convert and normalize the default path, but only if it is not nullptr
    FreeCheck_Guard<nfdnchar_t> defaultPathNGuard;
    ConvertU8ToNative(defaultPath, defaultPathNGuard);
    NormalizePathSeparator(defaultPathNGuard.data);

    // call the native function
    nfdnchar_t* outPathN;
    nfdresult_t res = NFD_PickFolderN(&outPathN, defaultPathNGuard.data);

    if (res != NFD_OKAY) {
        return res;
    }

    // convert the outPath to UTF-8
    res = CopyWCharToNFDChar(outPathN, *outPath);

    // free the native out path, and return the result
    NFD_FreePathN(outPathN);
    return res;
}

/* Get the UTF-8 path at offset index */
/* It is the caller's responsibility to free `outPath` via NFD_FreePathU8() if this function returns
 * NFD_OKAY */
nfdresult_t NFD_PathSet_GetPathU8(const nfdpathset_t* pathSet,
                                  nfdpathsetsize_t index,
                                  nfdu8char_t** outPath) {
    // call the native function
    nfdnchar_t* outPathN;
    nfdresult_t res = NFD_PathSet_GetPathN(pathSet, index, &outPathN);

    if (res != NFD_OKAY) {
        return res;
    }

    // convert the outPath to UTF-8
    res = CopyWCharToNFDChar(outPathN, *outPath);

    // free the native out path, and return the result
    NFD_FreePathN(outPathN);
    return res;
}

nfdresult_t NFD_PathSet_EnumNextU8(nfdpathsetenum_t* enumerator, nfdu8char_t** outPath) {
    // call the native function
    nfdnchar_t* outPathN;
    nfdresult_t res = NFD_PathSet_EnumNextN(enumerator, &outPathN);

    if (res != NFD_OKAY) {
        return res;
    }

    if (outPathN) {
        // convert the outPath to UTF-8
        res = CopyWCharToNFDChar(outPathN, *outPath);

        // free the native out path, and return the result
        NFD_FreePathN(outPathN);
    } else {
        *outPath = nullptr;
        res = NFD_OKAY;
    }

    return res;
}