Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/zabbix/zabbix.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/ui/tests/selenium/roles/testFormUserRoles.php
diff options
context:
space:
mode:
Diffstat (limited to 'ui/tests/selenium/roles/testFormUserRoles.php')
-rw-r--r--ui/tests/selenium/roles/testFormUserRoles.php141
1 files changed, 45 insertions, 96 deletions
diff --git a/ui/tests/selenium/roles/testFormUserRoles.php b/ui/tests/selenium/roles/testFormUserRoles.php
index 16a7a999a4c..059407eaf8e 100644
--- a/ui/tests/selenium/roles/testFormUserRoles.php
+++ b/ui/tests/selenium/roles/testFormUserRoles.php
@@ -24,10 +24,11 @@ require_once dirname(__FILE__).'/../../include/helpers/CDataHelper.php';
require_once dirname(__FILE__).'/../traits/TableTrait.php';
/**
+ * @dataSource EntitiesTags, Services
+ *
* @backup role, module, users
- * @onBefore prepareRoleData
- * @onBefore prepareUserData
- * @onBefore prepareServiceData
+ *
+ * @onBefore prepareRoleData, prepareUserData
*/
class testFormUserRoles extends CWebTest {
@@ -109,57 +110,6 @@ class testFormUserRoles extends CWebTest {
]);
}
- public function prepareServiceData() {
- CDataHelper::call('service.create', [
- [
- 'name' => 'Service_1',
- 'algorithm' => 1,
- 'sortorder' => 1
- ],
- [
- 'name' => 'Service_2',
- 'algorithm' => 2,
- 'sortorder' => 2,
- 'problem_tags' => [
- [
- 'tag' => 'tag1',
- 'value' => 'value1'
- ],
- [
- 'tag' => 'tag2',
- 'value' => 'value2'
- ],
- [
- 'tag' => 'tag3',
- 'value' => 'value3'
- ],
- [
- 'tag' => 'tag4',
- 'value' => 'value4'
- ]
- ],
- 'tags' => [
- [
- 'tag' => 'Service_tag1',
- 'value' => 'value1s'
- ],
- [
- 'tag' => 'Service_tag2',
- 'value' => 'value2s'
- ],
- [
- 'tag' => 'Service_tag3',
- 'value' => 'value3s'
- ],
- [
- 'tag' => 'Service_tag4',
- 'value' => 'value4s'
- ]
- ]
- ]
- ]);
- }
-
public static function getCreateData() {
return [
// Same name for 3 types of roles.
@@ -793,14 +743,14 @@ class testFormUserRoles extends CWebTest {
'Read-only access to services' => 'Service list'
],
'write_services' => [
- 'xpath:(//div[@class="multiselect-control"])[1]' => 'Service_1',
+ 'xpath:(//div[@class="multiselect-control"])[1]' => 'Update service',
'Read-write access to services with tag' => [
'service-write-tag-tag' => 'tag-write',
'service_write_tag_value' => 'value-write'
]
],
'read_services' => [
- 'xpath:(//div[@class="multiselect-control"])[2]' => ['Service_1', 'Service_2'],
+ 'xpath:(//div[@class="multiselect-control"])[2]' => ['Update service', 'Service for delete 2'],
'Read-only access to services with tag' => [
'service-read-tag-tag' => 'tag-read',
'service_read_tag_value' => 'value-read'
@@ -821,7 +771,7 @@ class testFormUserRoles extends CWebTest {
'API methods' => 'Deny list'
],
'read_services' => [
- 'xpath:(//div[@class="multiselect-control"])[2]' => ['Service_1', 'Service_2']
+ 'xpath:(//div[@class="multiselect-control"])[2]' => ['Update service', 'Service for delete 2']
],
'message_header' => 'User role created'
]
@@ -1274,7 +1224,7 @@ class testFormUserRoles extends CWebTest {
'API methods' => 'Deny list'
],
'read_services' => [
- 'xpath:(//div[@class="multiselect-control"])[2]' => ['Service_1', 'Service_2']
+ 'xpath:(//div[@class="multiselect-control"])[2]' => ['Update service', 'Service for delete 2']
],
'message_header' => 'User role updated'
]
@@ -1290,14 +1240,14 @@ class testFormUserRoles extends CWebTest {
'API methods' => 'Deny list'
],
'write_services' => [
- 'xpath:(//div[@class="multiselect-control"])[1]' => ['Service_1', 'Service_2'],
+ 'xpath:(//div[@class="multiselect-control"])[1]' => ['Update service', 'Service for delete 2'],
'Read-write access to services with tag' => [
'service-write-tag-tag' => 'tag-write',
'service_write_tag_value' => 'value-write'
]
],
'read_services' => [
- 'xpath:(//div[@class="multiselect-control"])[2]' => 'Service_1',
+ 'xpath:(//div[@class="multiselect-control"])[2]' => 'Update service',
'Read-only access to services with tag' => [
'service-read-tag-tag' => 'tag-read',
'service_read_tag_value' => 'value-read'
@@ -1395,12 +1345,19 @@ class testFormUserRoles extends CWebTest {
*/
public function testFormUserRoles_Modules() {
$this->page->login();
+
foreach ([true, false] as $enable_modules) {
$modules = ['4th Module', '5th Module'];
$this->page->open('zabbix.php?action=userrole.edit&roleid=2')->waitUntilReady();
$form = $this->query('id:userrole-form')->waitUntilPresent()->asForm()->one();
+
if ($enable_modules === true) {
- $this->assertTrue($form->query('xpath://label[text()="No enabled modules found."]')->one()->isDisplayed());
+ foreach ($modules as $module) {
+ $this->assertFalse($form->query("xpath:.//label[text()=".CXPathHelper::escapeQuotes($module)."]")
+ ->one(false)->isValid()
+ );
+ }
+
$this->page->open('zabbix.php?action=module.list')->waitUntilReady();
$this->query('button:Scan directory')->one()->click();
$table = $this->query('class:list-table')->asTable()->one();
@@ -1410,7 +1367,6 @@ class testFormUserRoles extends CWebTest {
$this->page->waitUntilReady();
}
else {
- $this->assertFalse($form->query('xpath://label[text()="No enabled modules found."]')->one($enable_modules)->isDisplayed());
foreach ($modules as $module) {
$form->getField($module)->isChecked();
}
@@ -1424,36 +1380,18 @@ class testFormUserRoles extends CWebTest {
public function testFormUserRoles_ServicesLayout() {
$services_table = [
[
- 'Name' => 'Service with tags for updating',
- 'Tags' => ['action: update', 'tag without value', 'test: update'],
- 'Problem tags' => ['problem action: problem update', 'problem tag without value', 'problem test: problem update']
- ],
- [
- 'Name' => 'Service with tags for cloning',
- 'Tags' => ['a: :a', 'action: clone', 'common tag on host and element: common value'],
- 'Problem tags' => [
- 'problem a: :problem a',
- 'problem action: problem clone',
- 'problem common tag on host and element: problem common value'
- ]
- ],
- [
- 'Name' => 'Service for removing tags',
- 'Tags' => ['action: remove', 'tag', 'tag: remove'],
- 'Problem tags' => [
- 'problem remove: problem remove',
- 'problem tag',
- 'problem tag: problem remove'
- ]
+ 'Name' => 'Service for delete by checkbox',
+ 'Tags' => '',
+ 'Problem tags' => ''
],
[
- 'Name' => 'Service_1',
- 'Tags' => '',
+ 'Name' => 'Service for delete',
+ 'Tags' => ['remove_tag_2: remove_value_2'],
'Problem tags' => ''
],
[
- 'Name' => 'Service_2',
- 'Tags' => ['Service_tag1: value1s', 'Service_tag2: value2s', 'Service_tag3: value3s', 'Service_tag4: value4s'],
+ 'Name' => 'Service for delete 2',
+ 'Tags' => ['3rd_tag: 3rd_value', '4th_tag: 4th_value', 'remove_tag_1: remove_value_1', 'remove_tag_2: remove_value_2'],
'Problem tags' => ['tag1: value1', 'tag2: value2', 'tag3: value3', 'tag4: value4']
]
];
@@ -1474,7 +1412,8 @@ class testFormUserRoles extends CWebTest {
// Check filter form.
$filter_form = $dialog->query('name:services_filter_form')->one();
$this->assertEquals('Name', $filter_form->query('xpath:.//label')->one()->getText());
- $this->assertEquals(255, $filter_form->query('name:filter_name')->one()->getAttribute('maxlength'));
+ $filter_input = $filter_form->query('name:filter_name')->one();
+ $this->assertEquals(255, $filter_input->getAttribute('maxlength'));
$this->assertEquals(4, $dialog->query('button', ['Filter', 'Reset', 'Select', 'Cancel'])->all()
->filter(new CElementFilter(CElementFilter::CLICKABLE))->count());
@@ -1506,16 +1445,22 @@ class testFormUserRoles extends CWebTest {
unset($tags);
}
+ // Filter out all unwanted services before checking table content.
+ $filter_input->fill('Service for delete');
+ $filter_button = $dialog->query('button:Filter')->one();
+ $filter_button->click();
+ $dialog->waitUntilReady();
+
// Check the content of the services list with modified expected value in tags column.
$this->assertTableData($services_table);
// Check filtering of services by name.
$searches = [
- 'ice_' => ['Service_1', 'Service_2'],
- '1' => ['Service_1'],
- 'Service_123' => null
+ 'child 1' => ['Child 1', 'Clone child 1'],
+ ' 2 ' => ['Parent for 2 levels of child services'],
+ 'empty result' => null
];
- $filter_button = $filter_form->query('button:Filter')->one();
+
foreach ($searches as $string => $result) {
$filter_form->query('name:filter_name')->one()->fill($string);
$filter_button->click();
@@ -1536,14 +1481,18 @@ class testFormUserRoles extends CWebTest {
// Select one of the Services and make sure its not displayed in the list anymore.
$filter_form->query('button:Reset')->one()->click();
$dialog->invalidate();
- $dialog->query('link:Service_1')->waitUntilClickable()->one()->click();
+ $dialog->query('link:Service for delete by checkbox')->waitUntilClickable()->one()->click();
$dialog->ensureNotPresent();
$multiselect->edit();
$dialog->invalidate();
- $this->assertTableDataColumn(['Service with tags for updating', 'Service with tags for cloning',
- 'Service for removing tags', 'Service_2']
- );
+
+ // Filter out all unwanted services befoce checking table content.
+ $dialog->query('name:filter_name')->one()->fill('Service for delete');
+ $dialog->query('button:Filter')->one()->click();
+ $dialog->waitUntilReady();
+
+ $this->assertTableDataColumn(['Service for delete', 'Service for delete 2']);
$dialog->close();
// Check the layout of tag related fields in Service section of user role config form.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-04 06:59:11 +0300