1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
|
<?php
/*
** Zabbix
** Copyright (C) 2001-2022 Zabbix SIA
**
** This program is free software; you can redistribute it and/or modify
** it under the terms of the GNU General Public License as published by
** the Free Software Foundation; either version 2 of the License, or
** (at your option) any later version.
**
** This program is distributed in the hope that it will be useful,
** but WITHOUT ANY WARRANTY; without even the implied warranty of
** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
** GNU General Public License for more details.
**
** You should have received a copy of the GNU General Public License
** along with this program; if not, write to the Free Software
** Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
**/
require_once dirname(__FILE__).'/../../include/CWebTest.php';
require_once dirname(__FILE__).'/../behaviors/CMessageBehavior.php';
require_once dirname(__FILE__).'/../../include/helpers/CDataHelper.php';
require_once dirname(__FILE__).'/../traits/PreprocessingTrait.php';
/**
* @backup items
*/
class testItemTypeSelection extends CWebTest {
use PreprocessingTrait;
const HOSTID = 40001;
const LLDID = 90001;
const PROTOTYPE = true;
/**
* Attach Message behavior to the test.
*
* @return array
*/
public function getBehaviors() {
return ['class' => CMessageBehavior::class];
}
public static function getItemData() {
return [
[
[
'fields' => [
'Name' => 'Character',
'Key' => 'agent.hostmetadata[{#KEY}]'
],
'type' => 'Character'
]
],
[
[
'fields' => [
'Name' => 'Numeric unsigned',
'Key' => 'agent.ping[{#KEY}]'
],
'type' => 'Numeric (unsigned)'
]
],
[
[
'fields' => [
'Name' => 'Numeric float',
'Key' => 'net.udp.service.perf[service,{#KEY}]'
],
'type' => 'Numeric (float)'
]
],
[
[
'fields' => [
'Type' => 'Zabbix agent (active)',
'Name' => 'Log',
'Key' => 'eventlog[name,{#KEY}]'
],
'type' => 'Log'
]
],
[
[
'fields' => [
'Name' => 'Log',
'Key' => 'eventlog[agent,{#KEY}]'
],
'type' => 'Numeric (unsigned)'
]
],
[
[
'fields' => [
'Name' => 'Text',
'Key' => 'net.if.discovery[{#KEY}]'
],
'type' => 'Text'
]
],
[
[
'fields' => [
'Name' => 'Custom key',
'Key' => 'custom.key[{#KEY}]'
],
'type' => 'Numeric (unsigned)'
]
],
[
[
'fields' => [
'Name' => 'Custom key 2',
'Key' => 'custom.key2[{#KEY}]',
'Type of information' => 'Text'
],
'type' => 'Text',
'hint' => false
]
],
[
[
'fields' => [
'Name' => 'Test Info Hint',
'Key' => 'net.if.list[{#KEY}]',
'Type of information' => 'Log'
],
'hint' => true,
'hint_text' => 'This type of information may not match the key.',
'automatic_type' => 'Text'
]
]
];
}
/**
* @dataProvider getItemData
*/
public function testItemTypeSelection_Item($data) {
$this->checkItemTypeSelection($data);
}
/**
* @dataProvider getItemData
*/
public function testItemTypeSelection_ItemPrototype($data) {
$this->checkItemTypeSelection($data, self::PROTOTYPE);
}
/**
* Function for checking automatic type selection for items and item prototypes.
*
* @param array $data data provider
* @param boolean $prototype true if it is item prototype, false if item
*/
public function checkItemTypeSelection($data, $prototype = false) {
$link = ($prototype)
? 'disc_prototypes.php?form=create&parent_discoveryid='.self::LLDID.'&context=host'
: 'items.php?form=create&hostid='.self::HOSTID.'&context=host';
$this->page->login()->open($link)->waitUntilReady();
$form = $this->query('id', ($prototype) ? 'item-prototype-form' : 'item-form')->asForm()->waitUntilReady()->one();
// Make names unique for items and prototypes.
$data['fields']['Name'] = $data['fields']['Name'].microtime();
$form->fill($data['fields']);
// Check hintbox text.
if (CTestArrayHelper::get($data, 'hint')) {
$icon = $this->query('id:js-item-type-hint')->waitUntilClickable()->one();
$icon->click();
$this->assertEquals($data['hint_text'],
$form->query('xpath://div[@class="hintbox-wrap"]')->waitUntilPresent()->one()->getText()
);
}
elseif (CTestArrayHelper::get($data, 'hint') === false) {
$this->assertFalse($form->query('id:js-item-type-hint')->waitUntilPresent()->one()->isVisible());
}
else {
// Check that type changed to automatic.
$this->assertEquals($data['type'], $form->getField('Type of information')->getValue());
}
$form->submit();
$this->assertMessage(TEST_GOOD, ($prototype) ? 'Item prototype added' : 'Item added');
// Check saved item form in DB and Frontend.
$id = CDBHelper::getValue('SELECT itemid FROM items'.
' WHERE key_ ='.zbx_dbstr($data['fields']['Key']).
' AND name ='.zbx_dbstr($data['fields']['Name'])
);
$saved_link = ($prototype)
? 'disc_prototypes.php?form=update&parent_discoveryid='.self::LLDID.'&itemid='.$id.'&context=host'
: 'items.php?form=update&hostid='.self::HOSTID.'&itemid='.$id.'&context=host';
$this->page->open($saved_link)->waitUntilReady();
$form->invalidate();
$form->checkValue($data['fields']);
if (CTestArrayHelper::get($data, 'hint')) {
// Check that info disappears when preprocessing step is added.
$form->selectTab('Preprocessing');
$this->addPreprocessingSteps([['type' => 'Regular expression', 'parameter_1' => 'pattern', 'parameter_2' => 'output']]);
$this->assertEquals($data['fields']['Type of information'], $form->getField('Type of information')->getValue());
$form->selectTab(($prototype) ? 'Item prototype' : 'Item');
$this->assertTrue($icon->isStalled());
$form->submit();
$this->assertMessage(TEST_GOOD, ($prototype) ? 'Item prototype updated' : 'Item updated');
// Check that custom type remained in saved form.
$this->page->open($saved_link)->waitUntilReady();
$form->invalidate();
$this->assertEquals($data['fields']['Type of information'], $form->getField('Type of information')->getValue());
// Check that type changes to automatic when preprocessing is cleared.
$form->selectTab('Preprocessing');
$form->query('xpath:.//li[@data-step="0"]')->waitUntilPresent()->one()->query('button:Remove')
->waitUntilClickable()->one()->click();
$form->selectTab(($prototype) ? 'Item prototype' : 'Item');
$this->assertEquals($data['automatic_type'], $form->getField('Type of information')->getValue());
// Check saved form.
$form->submit();
$this->assertMessage(TEST_GOOD, ($prototype) ? 'Item prototype updated' : 'Item updated');
$this->page->open($saved_link)->waitUntilReady();
$form->invalidate();
$this->assertEquals($data['automatic_type'], $form->getField('Type of information')->getValue());
}
else {
$this->assertEquals($data['type'], $form->getField('Type of information')->getValue());
}
}
}
|
