diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2020-08-25 10:26:57 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2020-08-25 10:27:48 +0300 |
| commit | ecf264e07f622a0dd55dda363ef6c0fecc228668 (patch) | |
| tree | 53101d8615ef1ab075326c7e2814098b25fdaf7c /.gitignore | |
| parent | 3f20df892807c5379dc349a6460c48f25ebce707 (diff) | |
Reintroduce gitaly-git2go support
With commit a6091637 (Merge branch 'pks-revert-git2go' into 'master',
2020-07-31), our new Git2Go dependency was reverted again due to several
issues:
- Some distributions didn't have a recent enough version of
CMake available. As a result, building libgit2 failed. This was
fixed by bumping the build images' CMake version.
- Build tags didn't work as expected and thus we ended up not using
them at all. This was fixed by passing build flags via the
Makefile. As this causes e.g. `go test ./...` to fail with a
linking error due to build tags not being specified and the
PKG_CONFIG_PATH not being set up as required. To work around this
issue and not break developer workflows, gitaly-git2go will now
only be built if build tags required for git2go are set.
- Invalidation of libgit2.a didn't work as required. E.g. if the
Makefile changes, it wasn't rebuilt and it was thus impossible to
provide fixes for any broken setups if libgit2.a was built
already. This was fixed by adding a build dependency on the
Makefile.
All in all, this should fix all currently known problems with building
libgit2.
Diffstat (limited to '.gitignore')
| -rw-r--r-- | .gitignore | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/.gitignore b/.gitignore index 25909590c..35e7aeb1f 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,7 @@ /_build /config.mak /gitaly +/gitaly-git2go /gitaly-hooks cmd/gitaly-ssh/gitaly-ssh /gitaly-ssh |