diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-15 22:02:43 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-19 09:52:44 +0300 |
| commit | 0cebf3c33a4e09cb1a3c2cc66e62e8777ab28920 (patch) | |
| tree | aded6d30fdb11e79d2fd78681193ec801798b90a /.golangci.yml | |
| parent | eab58f4482dc44df126d8f67eecb1e475817549a (diff) | |
sql: Report errors when failing to clean SQL database
After tests, we're running `glsql.Clean()` to remove any data which
we've written to the database during tests. We never verify that the
call actually succeeds though, which would thus hide any errors in case
this ever started to fail.
Fix the issue by logging an error in case the function fails and drop
the corresponding linter ignore rules.
Diffstat (limited to '.golangci.yml')
| -rw-r--r-- | .golangci.yml | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/.golangci.yml b/.golangci.yml index cc34057ab..6c7f52edb 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -844,10 +844,6 @@ issues: ## errcheck: Specific issues in *_test.go files - linters: - errcheck - path: "internal/praefect/replicator_test.go" - text: "Error return value of `glsql.Clean` is not checked" - - linters: - - errcheck path: "internal/middleware/sentryhandler/sentryhandler_test.go" text: "Error return value is not checked" - linters: @@ -856,10 +852,6 @@ issues: text: "Error return value of `cmd.Run` is not checked" - linters: - errcheck - path: "cmd/praefect/main_test.go" - text: "Error return value of `glsql.Clean` is not checked" - - linters: - - errcheck path: "internal/praefect/nodes/local_elector_test.go" text: "Error return value of `strategy.checkNodes` is not checked" ## END errcheck exclusions |