diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-09-06 15:49:49 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-09-07 09:34:57 +0300 |
| commit | 2b86a6e586f3ae1a223bf21193366272e72623c7 (patch) | |
| tree | 3426c298bf55d70bae12a3ffebe7e7e65af7530a /.golangci.yml | |
| parent | 1ea603e5db042d5dbc3d6b7a83b5934d2bfef86e (diff) | |
golangci-lint: Disallow importing public client package
Disallow importing the public `client` package, which is only intended
to be used by external clients. This brings multiple advantages:
- We have a clean boundary between public and internal code. This
ensures that we don't accidentally add interfaces to our public
packages that really are low-level details.
- It is easier to remain backwards compatibility as we now have two
distinct layers.
- We can perform internal refactorings more readily and iterate on
how things are handled internally without breaking the public API.
Other public packages will eventually follow to be added to the list of
disallowed imports.
Diffstat (limited to '.golangci.yml')
| -rw-r--r-- | .golangci.yml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/.golangci.yml b/.golangci.yml index 1ecf37840..825be0e44 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -50,6 +50,8 @@ linters-settings: desc: "ioutil is deprecated starting with Go 1.16" - pkg: "gitlab.com/gitlab-org/labkit/log" desc: "use internal/log instead" + - pkg: "gitlab.com/gitlab-org/gitaly/v16/client" + desc: "use internal/grpc/client instead" errcheck: # The following are functions for which we are currently not consistently # checking returned errors. This is not intended as a list of known-okay |