diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-06-09 19:23:56 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-06-14 08:52:34 +0300 |
| commit | ccbc77365afb603d01db7eddf7b3d6b2bdb86a41 (patch) | |
| tree | a73fcb5bc5eba7d08079cc7bd58fe6e2f58c1fb8 /.golangci.yml | |
| parent | 603058f365a004240e3e3badf9596f9f9c49baa5 (diff) | |
stats: Refactor the `Post` structure
The `Post` structure hosts statistics about a POST request against
git-upload-pack(1). Without knowing details about how git-upload-pack(1)
works though, one wouldn't be able to tell what it actually represents:
everything related to fetching the packfile.
Let's rename the structure to `HTTPFetchPack`, which more clearly labels
what it actually is about. While at it, this also refactors the way it's
constructed: instead of being constructed via the `Clone` structure,
it's now a standalone structure and can be constructed via
`performFetchPack()`. This disentangles concerns and makes it
easier to reason about the code.
Diffstat (limited to '.golangci.yml')
| -rw-r--r-- | .golangci.yml | 40 |
1 files changed, 0 insertions, 40 deletions
diff --git a/.golangci.yml b/.golangci.yml index 182a85533..a40cde050 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -246,46 +246,6 @@ issues: - linters: - golint path: "internal/git/stats/analyzehttp.go" - text: "exported type `Post` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.ResponseHeader` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.HTTPStatus` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.NAK` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.ResponseBody` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.Packets` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.LargestPacketSize` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.BandPackets` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.BandPayloadSize` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Post.BandFirstPacket` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" text: "exported type `Clone` should have comment or be unexported" - linters: - golint |