Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKim "BKC" Carlbäcker <kim.carlbacker@gmail.com>2017-10-13 18:35:29 +0300
committerKim "BKC" Carlbäcker <kim.carlbacker@gmail.com>2017-10-13 18:35:29 +0300
commit43d6042883f131600972da39c9b49101a85ed5e5 (patch)
treee1b1dcd52d2b263ed37c372b841dbde489d557b7
parent856722a54ed0f5fb47ce28d9d55e3f091181a725 (diff)
test non-exist in middle of list632-blob-service-get-blobs-by-shas
-rw-r--r--internal/service/blob/get_blobs_test.go39
1 files changed, 29 insertions, 10 deletions
diff --git a/internal/service/blob/get_blobs_test.go b/internal/service/blob/get_blobs_test.go
index e5c4e93d0..f35ed0a16 100644
--- a/internal/service/blob/get_blobs_test.go
+++ b/internal/service/blob/get_blobs_test.go
@@ -121,21 +121,40 @@ func TestGetBlobsNotFound(t *testing.T) {
client, conn := newBlobClient(t, serverSocketPath)
defer conn.Close()
- request := &pb.GetBlobsRequest{
- Repository: testRepo,
- Oids: []string{"doesnotexist", "95d9f0a5e7bb054e9dd3975589b8dfc689e20e88"}, // Second exist
+ tests := []struct {
+ desc string
+ req pb.GetBlobsRequest
+ }{
+ {
+ desc: "first of two is non-exist",
+ req: pb.GetBlobsRequest{
+ Repository: testRepo,
+ Oids: []string{"doesnotexist", "95d9f0a5e7bb054e9dd3975589b8dfc689e20e88"}, // Second exist
+ },
+ },
+ {
+ desc: "second of three is non-exist",
+ req: pb.GetBlobsRequest{
+ Repository: testRepo,
+ Oids: []string{"95d9f0a5e7bb054e9dd3975589b8dfc689e20e88", "doesnotexist", "95d9f0a5e7bb054e9dd3975589b8dfc689e20e88"}, // Second exist
+ },
+ },
}
- ctx, cancel := testhelper.Context()
- defer cancel()
+ for _, tc := range tests {
+ t.Run(tc.desc, func(t *testing.T) {
+ ctx, cancel := testhelper.Context()
+ defer cancel()
- stream, err := client.GetBlobs(ctx, request)
- require.NoError(t, err)
+ stream, err := client.GetBlobs(ctx, &tc.req)
+ require.NoError(t, err)
- blobs, err := getAllBlobs(stream)
- require.NoError(t, err)
+ blobs, err := getAllBlobs(stream)
+ require.NoError(t, err)
- require.Nil(t, blobs)
+ require.Nil(t, blobs)
+ })
+ }
}
func TestFailedGetBlobsRequestDueToValidationError(t *testing.T) {