diff options
| author | James Fargher <jfargher@gitlab.com> | 2021-06-17 05:04:40 +0300 |
|---|---|---|
| committer | James Fargher <jfargher@gitlab.com> | 2021-06-18 02:20:07 +0300 |
| commit | 091b5bdb4ae25c7a5807949acacc6cd0fd71106e (patch) | |
| tree | d43639761c9cb371cb68f6666359f9938d84b8aa | |
| parent | 581475e69cccbda5e0b2721accc7c8a2c5af5856 (diff) | |
Make FetchInternalRemote return errors by defaultenable_fetch_internal_remote_errors
Historically FetchInternalRemote returned a boolean to indicate if the
fetch failed. This makes debugging ReplicateRepository more difficult
than it needs to be. Instead we return the error so it can be diagnosed
without needing to scrape logs.
Changelog: changed
| -rw-r--r-- | internal/metadata/featureflag/feature_flags.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/metadata/featureflag/feature_flags.go b/internal/metadata/featureflag/feature_flags.go index 4b8d05bf6..1d2767d4d 100644 --- a/internal/metadata/featureflag/feature_flags.go +++ b/internal/metadata/featureflag/feature_flags.go @@ -12,7 +12,7 @@ var ( // GoUpdateRemoteMirror enables the Go implementation of UpdateRemoteMirror GoUpdateRemoteMirror = FeatureFlag{Name: "go_update_remote_mirror", OnByDefault: false} // FetchInternalRemoteErrors makes FetchInternalRemote return actual errors instead of a boolean - FetchInternalRemoteErrors = FeatureFlag{Name: "fetch_internal_remote_errors", OnByDefault: false} + FetchInternalRemoteErrors = FeatureFlag{Name: "fetch_internal_remote_errors", OnByDefault: true} // TxConfig enables transactional voting for SetConfig and DeleteConfig RPCs. TxConfig = FeatureFlag{Name: "tx_config", OnByDefault: true} // TxRemote enables transactional voting for AddRemote and DeleteRemote. |