diff options
author | Jacob Vosmaer <jacob@gitlab.com> | 2023-03-20 20:21:22 +0300 |
---|---|---|
committer | Jacob Vosmaer <jacob@gitlab.com> | 2023-03-30 18:24:38 +0300 |
commit | a436b45228cec032c022472de152ea507ad40295 (patch) | |
tree | d4ecb122fc856aa2852fde63f77f82f7098ad53d | |
parent | 64711495ceb9e9fd11c000cec8f9137d388197db (diff) |
Remove unnecessary test cleanup functionjv-remove-goroutine
-rw-r--r-- | internal/streamcache/pipe.go | 2 | ||||
-rw-r--r-- | internal/streamcache/pipe_test.go | 15 |
2 files changed, 1 insertions, 16 deletions
diff --git a/internal/streamcache/pipe.go b/internal/streamcache/pipe.go index 4cafacc40..58274957c 100644 --- a/internal/streamcache/pipe.go +++ b/internal/streamcache/pipe.go @@ -140,8 +140,6 @@ func (p *pipe) Close() error { return errClose } -func (p *pipe) RemoveFile() error { return os.Remove(p.name) } - func (p *pipe) OpenReader() (*pipeReader, error) { p.m.Lock() defer p.m.Unlock() diff --git a/internal/streamcache/pipe_test.go b/internal/streamcache/pipe_test.go index 41ec06691..e06efdd66 100644 --- a/internal/streamcache/pipe_test.go +++ b/internal/streamcache/pipe_test.go @@ -24,10 +24,7 @@ func createPipe(t *testing.T) (*pipeReader, *pipe) { pr, p, err := newPipe(f) require.NoError(t, err) - t.Cleanup(func() { - _ = p.RemoveFile() - p.Close() - }) + t.Cleanup(func() { p.Close() }) return pr, p } @@ -215,11 +212,6 @@ func TestPipe_closeWrongOrder(t *testing.T) { pr, p, err := newPipe(cs) require.NoError(t, err) - defer func() { - _ = p.RemoveFile() - p.Close() - }() - defer p.Close() defer pr.Close() @@ -248,11 +240,6 @@ func TestPipe_closeOrderHappy(t *testing.T) { pr1, p, err := newPipe(cs) require.NoError(t, err) - defer func() { - _ = p.RemoveFile() - p.Close() - }() - defer p.Close() defer pr1.Close() |