Ensure an absolute path is used for the internal socket dirmake-internal-socket-dir-absolute

In GDK, this is sometimes configured to a relative path, which doesn't
work with the GRPC dialer. Join it with the current working directory
to make these paths work.

Changelog: fixed

1 files changed, 5 insertions, 0 deletions

diff --git a/internal/gitaly/config/config.go b/internal/gitaly/config/config.go
index 09d6df1c2..687fecdb6 100644
--- a/internal/gitaly/config/config.go
+++ b/internal/gitaly/config/config.go
@@ -219,6 +219,11 @@ func (cfg *Cfg) setDefaults() error {
 		cfg.InternalSocketDir = tmpDir
 	}
 
+	// The GRPC dialer requires an absolute path, so convert relative paths
+	if !filepath.IsAbs(cfg.InternalSocketDir) {
+		cfg.InternalSocketDir = filepath.Abs(cfg.InternalSocketDir)
+	}
+
 	if reflect.DeepEqual(cfg.DailyMaintenance, DailyJob{}) {
 		cfg.DailyMaintenance = defaultMaintenanceWindow(cfg.Storages)
 	}