diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-08-10 16:02:42 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-08-10 16:02:42 +0300 |
| commit | 02082a58a64fae83ae59aba60aa8c44e882e66e4 (patch) | |
| tree | 5a5b19a58d34c560d6680ad4531c401b0f03616d | |
| parent | 03a82b12c4f30ff3ffce9ad3332223f104ef7c53 (diff) | |
objectpool: Default-enable pruning of refs to fix reference conflictspks-fetch-into-object-pool-prune-refs-default-enable
In 018958fb1 (objectpool: Fix conflicting references when fetching into
pools, 2022-07-27) we have introduced the logic to enable pruning of
references when we update an object pool via FetchIntoObjectPool. This
change was required because we have seen cases where updating object
pools continued to fail due to conflicting references which exist in the
pool repository and the member we have been fetching from. By pruning
any references which don't exist in the member anymore we were able to
resolve these conflicts and thus this bug.
This change has been rolled out to production on August 3rd without any
observed issues. So let's default-enable the feature flag guarding this
code so that the fix will be included in the next release.
Changelog: fixed
| -rw-r--r-- | internal/metadata/featureflag/ff_fetch_into_object_pool_prune_refs.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/metadata/featureflag/ff_fetch_into_object_pool_prune_refs.go b/internal/metadata/featureflag/ff_fetch_into_object_pool_prune_refs.go index 21d8eb3f0..4f0a2b41b 100644 --- a/internal/metadata/featureflag/ff_fetch_into_object_pool_prune_refs.go +++ b/internal/metadata/featureflag/ff_fetch_into_object_pool_prune_refs.go @@ -7,5 +7,5 @@ var FetchIntoObjectPoolPruneRefs = NewFeatureFlag( "fetch_into_object_pool_prune_refs", "v15.3.0", "https://gitlab.com/gitlab-org/gitaly/-/issues/4394", - false, + true, ) |