diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-15 15:01:14 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-03-18 16:40:30 +0300 |
| commit | 14b5c731309e9f84514ba080aba7a8d5d43e4e00 (patch) | |
| tree | e88dc40730fe9bf7fcee5e308d21265c9b173b82 | |
| parent | 8a298c5f11e2e9d4c752dead6feb8392b82651c8 (diff) | |
Makefile: Remove comment stating that `coverage` doesn't failpks-makefile-spring-cleanup
The `coverage` Makefile target used to not fail in the past. Nowadays it
does though because it executes `run_go_tests` on its own.
| -rw-r--r-- | Makefile | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -486,9 +486,8 @@ rubocop: ${SOURCE_DIR}/.ruby-bundle ## Generate coverage report via Go tests. cover: TEST_OPTIONS := ${TEST_OPTIONS} -coverprofile "${COVERAGE_DIR}/all.merged" cover: prepare-tests libgit2 ${GOCOVER_COBERTURA} - ${Q}echo "NOTE: make cover does not exit 1 on failure, don't use it to check for tests success!" + ${Q}rm -rf "${COVERAGE_DIR}" ${Q}mkdir -p "${COVERAGE_DIR}" - ${Q}rm -f "${COVERAGE_DIR}/all.merged" "${COVERAGE_DIR}/all.html" ${Q}$(call run_go_tests) ${Q}go tool cover -html "${COVERAGE_DIR}/all.merged" -o "${COVERAGE_DIR}/all.html" @ # sed is used below to convert file paths to repository root relative paths. See https://gitlab.com/gitlab-org/gitlab/-/issues/217664 |