diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-07-18 10:02:32 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-07-18 10:05:39 +0300 |
| commit | 0bcb54ba45a2744b87b71061d73f791e98de4403 (patch) | |
| tree | c68b2d9c674044d4e4186bd0da167d508c740f33 | |
| parent | 2ba30c8b1b5a428a645faf72881771af9a505ab2 (diff) | |
repository: Fix test writing into Gitaly's repositorypks-repository-clone-from-url-fix-test
One of our tests for `clnoeFromURLCommand()` tries to clone into a
subdirectory of the Gitaly repository itself. This is wrong: all test
data should always end up in a temporary directory.
Fix this by properly cloning into a temporary directory.
| -rw-r--r-- | internal/gitaly/service/repository/create_repository_from_url_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/gitaly/service/repository/create_repository_from_url_test.go b/internal/gitaly/service/repository/create_repository_from_url_test.go index 5fdd93ccb..c88e6c2f9 100644 --- a/internal/gitaly/service/repository/create_repository_from_url_test.go +++ b/internal/gitaly/service/repository/create_repository_from_url_test.go @@ -260,7 +260,7 @@ func TestServer_CloneFromURLCommand_withMirror(t *testing.T) { t.Parallel() ctx := testhelper.Context(t) - repositoryFullPath := "full/path/to/repository" + repositoryFullPath := filepath.Join(testhelper.TempDir(t), "full/path/to/repository") url := "https://www.example.com/secretrepo.git" cfg := testcfg.Build(t) |