Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSami Hiltunen <shiltunen@gitlab.com>2022-03-31 10:40:59 +0300
committerSami Hiltunen <shiltunen@gitlab.com>2022-03-31 15:13:59 +0300
commit190428776121daf932598d1529d36569f010e493 (patch)
tree535bbb92563f4474c2204e27aa7f68e69ebc2636
parente37f72c369b5ff63a42468a4efbc33782040d7cb (diff)
Don't disable Praefect in RemoveRepository testssmh-delete-object-pool-type
Praefect is currently disabled in RemoveRepository tests which allows for Praefect's RemoveRepository behavior to deviate from the Gitaly's. This commit enables Praefect for these tests so we can be sure we catch behavior deviations between the two handlers.
-rw-r--r--internal/gitaly/service/repository/remove_test.go5
1 files changed, 2 insertions, 3 deletions
diff --git a/internal/gitaly/service/repository/remove_test.go b/internal/gitaly/service/repository/remove_test.go
index 962b6e0b8..b6c922ecb 100644
--- a/internal/gitaly/service/repository/remove_test.go
+++ b/internal/gitaly/service/repository/remove_test.go
@@ -41,8 +41,7 @@ func TestRemoveRepository_doesNotExist(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
- // Praefect special-cases repository removals, so we disable Praefect here.
- cfg, client := setupRepositoryServiceWithoutRepo(t, testserver.WithDisablePraefect())
+ cfg, client := setupRepositoryServiceWithoutRepo(t)
_, err := client.RemoveRepository(ctx, &gitalypb.RemoveRepositoryRequest{
Repository: &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "/does/not/exist"},
@@ -54,7 +53,7 @@ func TestRemoveRepository_locking(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
- // Praefect special-cases repository removals, so we disable Praefect here.
+ // Praefect does not acquire a lock on repository deletion so disable the test case for Praefect.
_, repo, repoPath, client := setupRepositoryService(ctx, t, testserver.WithDisablePraefect())
// Simulate a concurrent RPC holding the repository lock.