diff options
| author | Sami Hiltunen <shiltunen@gitlab.com> | 2021-04-12 12:21:21 +0300 |
|---|---|---|
| committer | Sami Hiltunen <shiltunen@gitlab.com> | 2021-04-12 12:21:21 +0300 |
| commit | 16b576e437619a6fe4c4a572124bff820c98d0b3 (patch) | |
| tree | 79d0c0dc89aadab0705118c79681c114f4aa8e00 | |
| parent | c3f2b7baab9cd4781dbbab3f896683554a730d11 (diff) | |
match health check failure messages between the electorssmh-match-health-check-message
`per_repository` elector's health check failure log message differs
from what is outputted by the NodeManager. This is failing the QA
test pipeline which relies on the log message to identify when Praefect
has failed health checks from a secondary node. As a quick fix, let's
just match the log message so the pipeline passes.
| -rw-r--r-- | internal/praefect/nodes/health_manager.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/praefect/nodes/health_manager.go b/internal/praefect/nodes/health_manager.go index 1e37beb81..beb8154e5 100644 --- a/internal/praefect/nodes/health_manager.go +++ b/internal/praefect/nodes/health_manager.go @@ -247,7 +247,7 @@ func (hm *HealthManager) performHealthChecks(ctx context.Context) ([]string, []s logrus.ErrorKey: err, "virtual_storage": virtualStorages[i], "storage": physicalStorages[i], - }).Error("failed checking node health") + }).Error("error when pinging healthcheck") } healthy[i] = resp != nil && resp.Status == grpc_health_v1.HealthCheckResponse_SERVING |