diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-28 14:22:02 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-30 09:29:34 +0300 |
| commit | 8888a42205a6b621363e0fa1857a4fbbece5be88 (patch) | |
| tree | b21f444883e077e59d7e16f657b0e07e070ec09d | |
| parent | e6bf9caae47404fbc8e2b4cfe4e0e196c146d2e6 (diff) | |
proto: Un-deprecate GetLFSPointers
With the introduction of ListLFSPointers, it was thought that it could
also replace usage of GetLFSPointers. But as it turns out, this is not
easily doable: callers rely on the fact that even if given for example
the object ID of a tree containing LFS pointers, that there is no walk
and thus no result. This cannot be implemented via git-rev-list(1),
given that its "--no-walk" flag just keeps us from walking down commit
parents, but it will still traverse down the root tree of each commit.
So instead of awkwardly trying to somehow retrofit it into
ListLFSPointers, let's just un-deprecate GetLFSPointers.
| -rw-r--r-- | proto/blob.proto | 2 | ||||
| -rw-r--r-- | proto/go/gitalypb/blob.pb.go | 4 | ||||
| -rw-r--r-- | ruby/proto/gitaly/blob_services_pb.rb | 2 |
3 files changed, 0 insertions, 8 deletions
diff --git a/proto/blob.proto b/proto/blob.proto index 671a03b93..2f1b03241 100644 --- a/proto/blob.proto +++ b/proto/blob.proto @@ -25,8 +25,6 @@ service BlobService { // GetLFSPointers retrieves LFS pointers from a given set of object IDs. // This RPC filters all requested objects and only returns those which refer // to a valid LFS pointer. - // - // Deprecated in favor of `ListLFSPointers`, passing object IDs as revisions. rpc GetLFSPointers(GetLFSPointersRequest) returns (stream GetLFSPointersResponse) { option (op_type) = { op: ACCESSOR diff --git a/proto/go/gitalypb/blob.pb.go b/proto/go/gitalypb/blob.pb.go index 81c5f8499..09d80337d 100644 --- a/proto/go/gitalypb/blob.pb.go +++ b/proto/go/gitalypb/blob.pb.go @@ -826,8 +826,6 @@ type BlobServiceClient interface { // GetLFSPointers retrieves LFS pointers from a given set of object IDs. // This RPC filters all requested objects and only returns those which refer // to a valid LFS pointer. - // - // Deprecated in favor of `ListLFSPointers`, passing object IDs as revisions. GetLFSPointers(ctx context.Context, in *GetLFSPointersRequest, opts ...grpc.CallOption) (BlobService_GetLFSPointersClient, error) // ListLFSPointers retrieves LFS pointers reachable from a given set of // revisions by doing a graph walk. This includes both normal revisions like @@ -1019,8 +1017,6 @@ type BlobServiceServer interface { // GetLFSPointers retrieves LFS pointers from a given set of object IDs. // This RPC filters all requested objects and only returns those which refer // to a valid LFS pointer. - // - // Deprecated in favor of `ListLFSPointers`, passing object IDs as revisions. GetLFSPointers(*GetLFSPointersRequest, BlobService_GetLFSPointersServer) error // ListLFSPointers retrieves LFS pointers reachable from a given set of // revisions by doing a graph walk. This includes both normal revisions like diff --git a/ruby/proto/gitaly/blob_services_pb.rb b/ruby/proto/gitaly/blob_services_pb.rb index f37157b23..1048b21da 100644 --- a/ruby/proto/gitaly/blob_services_pb.rb +++ b/ruby/proto/gitaly/blob_services_pb.rb @@ -22,8 +22,6 @@ module Gitaly # GetLFSPointers retrieves LFS pointers from a given set of object IDs. # This RPC filters all requested objects and only returns those which refer # to a valid LFS pointer. - # - # Deprecated in favor of `ListLFSPointers`, passing object IDs as revisions. rpc :GetLFSPointers, Gitaly::GetLFSPointersRequest, stream(Gitaly::GetLFSPointersResponse) # ListLFSPointers retrieves LFS pointers reachable from a given set of # revisions by doing a graph walk. This includes both normal revisions like |