diff options
| author | Sami Hiltunen <shiltunen@gitlab.com> | 2023-08-18 17:36:30 +0300 |
|---|---|---|
| committer | Sami Hiltunen <shiltunen@gitlab.com> | 2023-08-28 15:26:06 +0300 |
| commit | 044a9b10648d2f4737c3a03bddc0f470e7f0af3c (patch) | |
| tree | 860af5adcbf665ef13e2f29072e748f58f60bbdb /cmd | |
| parent | 3f95a789b84a0fac1ecd8735573bc21c0097f810 (diff) | |
Disable RemoveAll tests with WAL
RemoveAll is a problematic RPC as it empties out the entire storage.
Doing so, it removes the disk state Gitaly is still operating on. This
causes issues with WAL as the transaction manager and the database don't
expect their disk state to suddenly disappear. Disable RemoveAll tests
with WAL until the RPC has been properly integrated.
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/gitaly-backup/restore_test.go | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/cmd/gitaly-backup/restore_test.go b/cmd/gitaly-backup/restore_test.go index 7b327f3eb..a36434b55 100644 --- a/cmd/gitaly-backup/restore_test.go +++ b/cmd/gitaly-backup/restore_test.go @@ -25,6 +25,13 @@ import ( func TestRestoreSubcommand(t *testing.T) { gittest.SkipWithSHA256(t) + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() ctx := testhelper.Context(t) @@ -101,6 +108,13 @@ func TestRestoreSubcommand(t *testing.T) { func TestRestoreSubcommand_serverSide(t *testing.T) { gittest.SkipWithSHA256(t) + testhelper.SkipWithWAL(t, ` +RemoveAll is removing the entire content of the storage. This would also remove the database's and +the transaction manager's disk state. The RPC needs to be updated to shut down all partitions and +the database and only then perform the removal. + +Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/5269`) + t.Parallel() ctx := testhelper.Context(t) |