diff options
| author | Rémy Coutable <remy@rymai.me> | 2020-07-07 08:28:07 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2020-07-07 08:28:07 +0300 |
| commit | a3c43b4f2d0dd3f91ec2cd1c468a699ff4cda65f (patch) | |
| tree | 88db0d6209f867a650cdff63ffbf732080187105 /danger | |
| parent | 8a5cc59b54a1ff87c49c0407b72b704b82690e23 (diff) | |
Support new feature:: and tooling:: labels to replace backstage
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'danger')
| -rw-r--r-- | danger/changelog/Dangerfile | 11 | ||||
| -rw-r--r-- | danger/labels/Dangerfile | 16 |
2 files changed, 17 insertions, 10 deletions
diff --git a/danger/changelog/Dangerfile b/danger/changelog/Dangerfile index 3fa83b39d..bad0cead8 100644 --- a/danger/changelog/Dangerfile +++ b/danger/changelog/Dangerfile @@ -1,7 +1,14 @@ # frozen_string_literal: true require 'yaml' -NO_CHANGELOG_LABELS = %w[backstage documentation test].freeze +NO_CHANGELOG_LABELS = [ + 'backstage', # To be removed by https://gitlab.com/gitlab-org/gitlab/-/issues/222360. + 'tooling', + 'tooling::pipelines', + 'tooling::workflow', + 'ci-build', + 'meta' +].freeze SEE_DOC = "See the [changelog documentation](https://docs.gitlab.com/ee/development/changelog.html)." CREATE_CHANGELOG_MESSAGE = <<~MSG You can create one with: @@ -48,7 +55,7 @@ rescue StandardError => e end def presented_no_changelog_labels - NO_CHANGELOG_LABELS.map { |label| "~#{label}" }.join(', ') + NO_CHANGELOG_LABELS.map { |label| %Q(~\\"#{label}\\") }.join(', ') end changelog_needed = (gitlab.mr_labels & NO_CHANGELOG_LABELS).empty? diff --git a/danger/labels/Dangerfile b/danger/labels/Dangerfile index e46d50114..b10259cd0 100644 --- a/danger/labels/Dangerfile +++ b/danger/labels/Dangerfile @@ -14,18 +14,18 @@ required_labels = %w[devops::create] required_labels << "group::gitaly" if GITALY_TEAM.include?(gitlab.mr_author) TYPE_TO_LABEL = { - 'added' => ['feature'], + 'added' => %w[feature feature::addition], 'fixed' => ['bug'], - 'changed' => ['backstage'], - 'deprecated' => ['backstage'], + 'changed' => %w[feature feature::maintenance], + 'deprecated' => %w[feature feature::maintenance], 'security' => ['security'], - 'removed' => ['backstage'], - 'performance' => ['performance', 'backstage'], - 'other' => ['backstage'], + 'removed' => %w[feature feature::maintenance], + 'performance' => %w[feature feature::maintenance performance], + 'other' => ['tooling'], nil => [] } -INHERIRABLE_LABELS = TYPE_TO_LABEL.values.flatten + %w[Deliverable] +INHERITABLE_LABELS = TYPE_TO_LABEL.values.flatten + %w[Deliverable] def inherited_labels gitlab.api @@ -33,7 +33,7 @@ def inherited_labels .flat_map { |i| i.labels } .compact .uniq - .select { |label| INHERIRABLE_LABELS.include?(label) } + .select { |label| INHERITABLE_LABELS.include?(label) } end required_labels.concat(TYPE_TO_LABEL[changelog_entry["type"]]) |