diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-02-25 12:55:31 +0300 |
|---|---|---|
| committer | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-02-25 14:58:59 +0300 |
| commit | 37859f9ae5ddf4a1d64280cf97efae1ebaf17fd2 (patch) | |
| tree | 1d44e2e70ad9887ad974c63d2bfe6c81dd041d69 /doc/PROCESS.md | |
| parent | f0db376ae133a135fffc14f40ade13d9cf8a2610 (diff) | |
Feature flag rollout docs: add reminders to set the feature to 100% && true
I screwed this up in [1] and [2] and as a result the feature didn't
get enabled 100% on January 14th like I thought, but on January 27th
when the changes [3][4] to remove the feature flag itself went
live ([4] being the relevant change).
1. https://gitlab.com/gitlab-org/gitaly/-/issues/3412#note_485304117
2. https://gitlab.com/gitlab-org/gitaly/-/issues/3413#note_485303898
3. https://gitlab.com/gitlab-org/gitaly/-/merge_requests/3035
4. https://gitlab.com/gitlab-org/gitaly/-/merge_requests/3033
Diffstat (limited to 'doc/PROCESS.md')
| -rw-r--r-- | doc/PROCESS.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/doc/PROCESS.md b/doc/PROCESS.md index 05a54671c..2042c92ca 100644 --- a/doc/PROCESS.md +++ b/doc/PROCESS.md @@ -185,6 +185,12 @@ Followed by: Note that you need both the `100` and `true` as separate commands. See [the documentation on actor gates][actor-gates] +If the feature is left at `50%` but is also set to `true` by default +the `50%` will win, even if `OnByDefault: true` is [set for +it](#feature-lifecycle-after-it-is-live). It'll only be 100% live once +the feature flag code is deleted. So make sure you don't skip the +`100%` step. + [actor-gates]: https://docs.gitlab.com/ee/development/feature_flags/controls.html#process ##### Discussion |