Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2021-01-12 17:47:34 +0300
committerÆvar Arnfjörð Bjarmason <avarab@gmail.com>2021-01-18 19:50:49 +0300
commit86c8480e89b290af7d30dd5d5d09a53df8b107a8 (patch)
tree7df4aec9a628248c9ce429d348d8fcd67b039e1e /doc/PROCESS.md
parent424c584cbe67d640705122802087ced5a4b728f4 (diff)
Feature flag rollout doc: expand on post-100% steps
Add more steps reflecting what we need to do after we have the feature at 100%. Includes a paraphrased version of what I noted in my a96949aef (Enable feature flag go_user_delete_{branch,tag} by default, 2021-01-12) as part of https://gitlab.com/gitlab-org/gitaly/-/merge_requests/2994
Diffstat (limited to 'doc/PROCESS.md')
-rw-r--r--doc/PROCESS.md21
1 files changed, 21 insertions, 0 deletions
diff --git a/doc/PROCESS.md b/doc/PROCESS.md
index 59e2d989a..171bac470 100644
--- a/doc/PROCESS.md
+++ b/doc/PROCESS.md
@@ -185,6 +185,27 @@ Nobody's better off if you wait 10 hours at 1% to get error data you
could have waited 1 hour at 10% to get, or just over 10 minutes with
close monitoring at 50%.
+#### Feature lifecycle after it is live
+
+##### Discussion
+
+After a feature is running at `100%` for what ever's deemed to be a
+safe amount of time we should change it to be `OnByDefault: true`. See
+[this MR for an example][example-on-by-default-mr].
+
+[example-on-by-default-mr]: https://gitlab.com/gitlab-org/gitaly/-/merge_requests/2994
+
+##### Two phase Ruby to Go rollouts
+
+Depending on what the feature does it may be bad to remove the `else`
+branch where we have the feature disabled at this point. E.g. if it's
+a rewrite of Ruby code in Go.
+
+As we deploy the Ruby code might be in the middle of auto-restarting,
+so we could remove its code before the Go code has a chance to update
+with its default, and would still want to call it. So therefore you
+need to do any such removal in two gitlab.com release cycles.
+
### Gitaly Releases
Gitaly releases are tagged automatically by