Extract file and executable permissions

Bulk update all file and executable permissions to use the new perm
package.

Strictly speaking changing os.ModePerm to perm.PublicFile is a
permission change (it goes from executable to normal), but since
ModePerm is only used in tests this should be safe.

1 files changed, 3 insertions, 3 deletions

diff --git a/internal/backup/filesystem_sink_test.go b/internal/backup/filesystem_sink_test.go
index 3346aab4a..fbb6b67b7 100644
--- a/internal/backup/filesystem_sink_test.go
+++ b/internal/backup/filesystem_sink_test.go
@@ -24,7 +24,7 @@ func TestFilesystemSink_GetReader(t *testing.T) {
 
 		dir := testhelper.TempDir(t)
 		const relativePath = "test.dat"
-		require.NoError(t, os.WriteFile(filepath.Join(dir, relativePath), []byte("test"), 0o644))
+		require.NoError(t, os.WriteFile(filepath.Join(dir, relativePath), []byte("test"), perm.SharedFile))
 
 		fsSink := NewFilesystemSink(dir)
 		reader, err := fsSink.GetReader(ctx, relativePath)
@@ -79,7 +79,7 @@ func TestFilesystemSink_Write(t *testing.T) {
 		fullPath := filepath.Join(dir, relativePath)
 
 		require.NoError(t, os.MkdirAll(filepath.Dir(fullPath), perm.SharedDir))
-		require.NoError(t, os.WriteFile(fullPath, []byte("initial"), 0o644))
+		require.NoError(t, os.WriteFile(fullPath, []byte("initial"), perm.SharedFile))
 
 		fsSink := NewFilesystemSink(dir)
 		require.NoError(t, fsSink.Write(ctx, relativePath, strings.NewReader("test")))
@@ -96,7 +96,7 @@ func TestFilesystemSink_Write(t *testing.T) {
 
 		dir := testhelper.TempDir(t)
 		const relativePath = "nested/test.dat"
-		require.NoError(t, os.WriteFile(filepath.Join(dir, "nested"), []byte("lock"), os.ModePerm))
+		require.NoError(t, os.WriteFile(filepath.Join(dir, "nested"), []byte("lock"), perm.PublicFile))
 
 		fsSink := NewFilesystemSink(dir)
 		err := fsSink.Write(ctx, relativePath, strings.NewReader("test"))