testcfg: Convert callers of `BuildWithRepo()`

The `BuildWithRepo()` function builds a Gitaly configuration and at the
same time creates a seed repository. There's two issues with this:

    - It is a layering violation as the configuration-related code
      should not depend on the repository-related logic. This means that
      e.g. the `gittest` package cannot depend on the `testcfg` package
      even though it is at a conceptually higher level.

    - It hides away the parameters used to create the repository. This
      means that we use seed repositories by default, but also that we
      skip creation via the Repository service. Both are bad and should
      require the caller to explicitly state that they want this.

Convert callers of `BuildWithRepo()` to instead use `Build()` to build
the configuration and `gittest.CreateRepository()` to create the
repository. Remove the now-unused `BuildWithRepo()` function.

1 files changed, 7 insertions, 2 deletions

diff --git a/internal/gitaly/server/auth_test.go b/internal/gitaly/server/auth_test.go
index b0322c6f6..2c008077e 100644
--- a/internal/gitaly/server/auth_test.go
+++ b/internal/gitaly/server/auth_test.go
@@ -306,7 +306,8 @@ func TestStreamingNoAuth(t *testing.T) {
 }
 
 func TestAuthBeforeLimit(t *testing.T) {
-	cfg, repo, repoPath := testcfg.BuildWithRepo(t, testcfg.WithBase(config.Cfg{
+	ctx := testhelper.Context(t)
+	cfg := testcfg.Build(t, testcfg.WithBase(config.Cfg{
 		Auth: auth.Config{Token: "abc123"},
 		Concurrency: []config.Concurrency{{
 			RPC:        "/gitaly.OperationService/UserCreateTag",
@@ -315,6 +316,11 @@ func TestAuthBeforeLimit(t *testing.T) {
 	},
 	))
 
+	repo, repoPath := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
+		SkipCreationViaService: true,
+		Seed:                   gittest.SeedGitLabTest,
+	})
+
 	gitlabURL, cleanup := gitlab.SetupAndStartGitlabServer(t, cfg.GitlabShell.Dir, &gitlab.TestServerOptions{
 		SecretToken:                 "secretToken",
 		GLID:                        gittest.GlID,
@@ -328,7 +334,6 @@ func TestAuthBeforeLimit(t *testing.T) {
 	serverSocketPath := runServer(t, cfg)
 	client, conn := newOperationClient(t, cfg.Auth.Token, serverSocketPath)
 	t.Cleanup(func() { conn.Close() })
-	ctx := testhelper.Context(t)
 
 	defer func(d time.Duration) {
 		gitalyauth.SetTokenValidityDuration(d)