transaction: Introduce Vote type

When voting, we currently only accept a byte slice representing the vote
itself. This requires the caller to know how to compute the vote and
thus leaks implementation details across all voters.

Improve the situation by introducing a new `Vote` type, which simply
maps to a fixed-size byte array, along with constructors to create a
`Vote`.

1 files changed, 7 insertions, 1 deletions

diff --git a/internal/gitaly/service/repository/apply_gitattributes.go b/internal/gitaly/service/repository/apply_gitattributes.go
index 6f7190b26..7a876fb81 100644
--- a/internal/gitaly/service/repository/apply_gitattributes.go
+++ b/internal/gitaly/service/repository/apply_gitattributes.go
@@ -11,6 +11,7 @@ import (
 
 	"gitlab.com/gitlab-org/gitaly/internal/git"
 	"gitlab.com/gitlab-org/gitaly/internal/git/catfile"
+	"gitlab.com/gitlab-org/gitaly/internal/gitaly/transaction"
 	"gitlab.com/gitlab-org/gitaly/internal/praefect/metadata"
 	"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
 	"google.golang.org/grpc/codes"
@@ -107,7 +108,12 @@ func (s *server) vote(ctx context.Context, oid git.ObjectID) error {
 		return fmt.Errorf("vote with invalid object ID: %w", err)
 	}
 
-	if err := s.txManager.Vote(ctx, tx, *praefect, hash); err != nil {
+	vote, err := transaction.VoteFromHash(hash)
+	if err != nil {
+		return fmt.Errorf("cannot convert OID to vote: %w", err)
+	}
+
+	if err := s.txManager.Vote(ctx, tx, *praefect, vote); err != nil {
 		return fmt.Errorf("vote failed: %w", err)
 	}