diff options
author | Quang-Minh Nguyen <qmnguyen@gitlab.com> | 2023-01-31 09:57:08 +0300 |
---|---|---|
committer | Quang-Minh Nguyen <qmnguyen@gitlab.com> | 2023-02-02 10:40:52 +0300 |
commit | 10bed3e86436571970a000ddf830d46d977ac17a (patch) | |
tree | 8c91a25a4f295df0db2e43d809c4238e9c4f9130 /proto/smarthttp.proto | |
parent | ed85386e4a808bab0023c28b9b1d7e103b50050e (diff) |
Remove PostUploadPack RPC
In prior versions, we introduced Sidechannel protocols as an optmization
to avoid transferring huge binary data over gRPC. This protocol was
applied in *Sidechannel version of existing RPCs. We rolled out those
RPCs and replaced all existing clients. There were no traffic to the old
RPCs for a long time. It's time to wipe them out, starting with
PostUploadPack RPC.
Diffstat (limited to 'proto/smarthttp.proto')
-rw-r--r-- | proto/smarthttp.proto | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/proto/smarthttp.proto b/proto/smarthttp.proto index a0e6aaad5..5072d40e3 100644 --- a/proto/smarthttp.proto +++ b/proto/smarthttp.proto @@ -28,13 +28,6 @@ service SmartHTTPService { }; } - // Request and response body for POST /upload-pack - rpc PostUploadPack(stream PostUploadPackRequest) returns (stream PostUploadPackResponse) { - option (op_type) = { - op: ACCESSOR - }; - } - // Request and response body for POST /upload-pack using sidechannel protocol rpc PostUploadPackWithSidechannel(PostUploadPackWithSidechannelRequest) returns (PostUploadPackWithSidechannelResponse) { option (op_type) = { @@ -68,25 +61,6 @@ message InfoRefsResponse { } // This comment is left unintentionally blank. -message PostUploadPackRequest { - // repository should only be present in the first message of the stream - Repository repository = 1 [(target_repository)=true]; - // Raw data to be copied to stdin of 'git upload-pack' - bytes data = 2; - // Parameters to use with git -c (key=value pairs) - repeated string git_config_options = 3; - - // Git protocol version - string git_protocol = 4; -} - -// This comment is left unintentionally blank. -message PostUploadPackResponse { - // Raw data from stdout of 'git upload-pack' - bytes data = 1; -} - -// This comment is left unintentionally blank. message PostUploadPackWithSidechannelRequest { // repository should only be present in the first message of the stream Repository repository = 1 [(target_repository)=true]; |