diff options
| author | Emily Chui <echui@gitlab.com> | 2023-12-05 05:57:57 +0300 |
|---|---|---|
| committer | Emily Chui <echui@gitlab.com> | 2023-12-05 05:57:57 +0300 |
| commit | 14d9f1ae93d635a8b5759e915d0e3c2915e7dd7f (patch) | |
| tree | 0babaacf0259f5f98778b1da52176ef7577fb808 /proto | |
| parent | 61813ee439cc7a3e0858b4955f4511315eaab650 (diff) | |
| parent | 639efdf921c3f7998fe40f47c539465970e2a334 (diff) | |
Merge branch 'jliu-rev-list-args-stdin' into 'master'
git: Pass rev-list arguments via stdin in the ObjectsSize RPC
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6561
Merged-by: Emily Chui <echui@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Approved-by: Emily Chui <echui@gitlab.com>
Reviewed-by: Emily Chui <echui@gitlab.com>
Co-authored-by: James Liu <jliu@gitlab.com>
Diffstat (limited to 'proto')
| -rw-r--r-- | proto/go/gitalypb/repository.pb.go | 4 | ||||
| -rw-r--r-- | proto/repository.proto | 4 |
2 files changed, 0 insertions, 8 deletions
diff --git a/proto/go/gitalypb/repository.pb.go b/proto/go/gitalypb/repository.pb.go index 171bd012b..ca005e2b5 100644 --- a/proto/go/gitalypb/repository.pb.go +++ b/proto/go/gitalypb/repository.pb.go @@ -531,10 +531,6 @@ type ObjectsSizeRequest struct { // revisions is the set of revisions that shall be used to compute the object size for. Supports normal revisions as // well as pseudo-revisions like `--not`, `--all`, `--branches[=pattern]`, `--tags[=pattern]` and `--glob=pattern`. // Please refer to the man pages gitrevisions(7) as well as git-rev-list(1) for more information. - // - // Note: due to a restriction in Git v2.41 and older all arguments need to be passed via command line parameters. So - // even though you can send multiple requests, the actual number of revisions that can be passed is limited by the - // maximum command line length. This limitation will be lifted once Gitaly has upgraded to Git v2.42 and later. Revisions [][]byte `protobuf:"bytes,2,rep,name=revisions,proto3" json:"revisions,omitempty"` } diff --git a/proto/repository.proto b/proto/repository.proto index 0445ce3a4..25d446f61 100644 --- a/proto/repository.proto +++ b/proto/repository.proto @@ -511,10 +511,6 @@ message ObjectsSizeRequest { // revisions is the set of revisions that shall be used to compute the object size for. Supports normal revisions as // well as pseudo-revisions like `--not`, `--all`, `--branches[=pattern]`, `--tags[=pattern]` and `--glob=pattern`. // Please refer to the man pages gitrevisions(7) as well as git-rev-list(1) for more information. - // - // Note: due to a restriction in Git v2.41 and older all arguments need to be passed via command line parameters. So - // even though you can send multiple requests, the actual number of revisions that can be passed is limited by the - // maximum command line length. This limitation will be lifted once Gitaly has upgraded to Git v2.42 and later. repeated bytes revisions = 2; } |