lint: Move custom linter settings to .golangci.yml file

In a prior change
(https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5398), we added
the support for custom linters on top of golangci-lint. In the first
iteration, all settings for them are put in the implemenation file.
This commit moves those settings to the manifeset file, along side with
other linter settings.

golangci-lint doesn't support an official way to load the settings in
de-facto manifest file `.golangci.yml`. Fortunately, we can hook into
configuration parsing library `viper` that golangci-lint uses. Our
custom linters are loaded at the end, just before executing the
commands. At this time, golangci-lint established some state that stores
the configuration. This state is process global, and accessible in our
source code. In the future, if this approach doesn't work anymore, we
can consider parsing the configuration file ourselves.

1 files changed, 2 insertions, 2 deletions

diff --git a/tools/golangci-lint/gitaly/quote_test.go b/tools/golangci-lint/gitaly/quote_test.go
index 9ba749288..7d262b5de 100644
--- a/tools/golangci-lint/gitaly/quote_test.go
+++ b/tools/golangci-lint/gitaly/quote_test.go
@@ -15,8 +15,8 @@ func TestQuoteInterpolationAnalyzer(t *testing.T) {
 	}
 
 	testdata := filepath.Join(wd, "testdata")
-	analyzer := NewQuoteInterpolationAnalyzer([]string{
+	analyzer := newQuoteInterpolationAnalyzer(&quoteInterpolationAnalyzerSettings{IncludedFunctions: []string{
 		"fmt.*",
-	})
+	}})
 	analysistest.Run(t, testdata, analyzer, "quote")
 }