diff options
Diffstat (limited to 'internal/gitaly/service/commit/find_all_commits.go')
| -rw-r--r-- | internal/gitaly/service/commit/find_all_commits.go | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/internal/gitaly/service/commit/find_all_commits.go b/internal/gitaly/service/commit/find_all_commits.go index 837ff1318..573894744 100644 --- a/internal/gitaly/service/commit/find_all_commits.go +++ b/internal/gitaly/service/commit/find_all_commits.go @@ -3,6 +3,7 @@ package commit import ( "fmt" + gitalyerrors "gitlab.com/gitlab-org/gitaly/v15/internal/errors" "gitlab.com/gitlab-org/gitaly/v15/internal/git" "gitlab.com/gitlab-org/gitaly/v15/internal/helper" "gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb" @@ -10,7 +11,7 @@ import ( func (s *server) FindAllCommits(in *gitalypb.FindAllCommitsRequest, stream gitalypb.CommitService_FindAllCommitsServer) error { if err := validateFindAllCommitsRequest(in); err != nil { - return err + return helper.ErrInvalidArgument(err) } ctx := stream.Context() @@ -39,8 +40,12 @@ func (s *server) FindAllCommits(in *gitalypb.FindAllCommitsRequest, stream gital } func validateFindAllCommitsRequest(in *gitalypb.FindAllCommitsRequest) error { + if in.GetRepository() == nil { + return gitalyerrors.ErrEmptyRepository + } + if err := git.ValidateRevisionAllowEmpty(in.Revision); err != nil { - return helper.ErrInvalidArgument(err) + return err } return nil |