| Age | Commit message (Collapse) | Author |
|---|
|
We don't use either Git2go nor libgit2 anymore, so let's stop mentioning
it.
|
|
Remove the now-unused gitaly-git2o command as well as its supporting
infrastructure.
|
|
|
|
After long rounds of refactoring we finally can remove
git.NewCommand function.
The change also includes removal of the TODO left because
of the NewCommand usage with the global config.Config variable.
And as a final step the doc is updated and now mentions usage
of the git.CommandFactory interface instead of git.NewCommand().
Part of: https://gitlab.com/gitlab-org/gitaly/-/issues/2699
|
|
Back when we introduced the Git DSL, we still had conflicting sets of
safe and unsafe functions. Because of this legacy, our safe set of
functions is still has the "Safe" prefix.
This commit now ends that chapter and renames `SafeCmd()`. In alginment
with the preceding renames, this is being renamed to `NewCommand()`.
|
|
Clarify the recently added documentation in 2cbfe50d7 (docs: Explain
how to interact with Git in Gitaly, 2020-09-23) to not draw a hard
line on using non-plumbing. As the change being made here argues this
doesn't reflect reality on the ground.
As a practical matter we make plenty of use of non-plumbing,
e.g. "gc", "bundle", "log", "remote", "config", "worktree" etc. What
we actually care about is the sort of command use I altered in
61b9b30a5 (git.Remote: use "git remote" exit code instead of parsing
stderr, 2020-11-10). Let's try to make the docs reflect that.
I also sent a note to the git ML about the general issue:
https://public-inbox.org/git/878sa7xujm.fsf@evledraar.gmail.com/T/
|
|
This is mainly done in preparation for a follow-up change, to make the
diff easier to read.
|
|
When interacting with Git repositories the Gitaly team contains a lot of
knowledge, but it's not written down. This makes it harder for
maintainers to spread their knowlegde, and would ease reviews if
contributors can learn what to do and not to do.
This would also allow maintainers to link to the docs during reviews
without explaining the full story, and speed them up.
|
