1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
|
package backup
import (
"bytes"
"errors"
"fmt"
"io"
"os"
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/helper/perm"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
_ "gocloud.dev/blob/memblob"
)
func TestResolveSink(t *testing.T) {
ctx := testhelper.Context(t)
isStorageServiceSink := func(expErrMsg string) func(t *testing.T, sink Sink) {
return func(t *testing.T, sink Sink) {
t.Helper()
sssink, ok := sink.(*StorageServiceSink)
require.True(t, ok)
_, err := sssink.bucket.List(nil).Next(ctx)
var ierr interface{ Unwrap() error }
require.True(t, errors.As(err, &ierr))
terr := ierr.Unwrap()
require.Contains(t, terr.Error(), expErrMsg)
}
}
tmpDir := testhelper.TempDir(t)
gsCreds := filepath.Join(tmpDir, "gs.creds")
require.NoError(t, os.WriteFile(gsCreds, []byte(`
{
"type": "service_account",
"project_id": "hostfactory-179005",
"private_key_id": "6253b144ccd94f50ce1224a73ffc48bda256d0a7",
"private_key": "-----BEGIN PRIVATE KEY-----\nXXXX<KEY CONTENT OMIT HERE> \n-----END PRIVATE KEY-----\n",
"client_email": "303721356529-compute@developer.gserviceaccount.com",
"client_id": "116595416948414952474",
"auth_uri": "https://accounts.google.com/o/oauth2/auth",
"token_uri": "https://accounts.google.com/o/oauth2/token",
"auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
"client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/303724477529-compute%40developer.gserviceaccount.com"
}`), perm.SharedFile))
for _, tc := range []struct {
desc string
envs map[string]string
path string
verify func(t *testing.T, sink Sink)
errMsg string
}{
{
desc: "AWS S3",
envs: map[string]string{
"AWS_ACCESS_KEY_ID": "test",
"AWS_SECRET_ACCESS_KEY": "test",
"AWS_REGION": "us-east-1",
},
path: "s3://bucket",
verify: isStorageServiceSink("The AWS Access Key Id you provided does not exist in our records."),
},
{
desc: "Google Cloud Storage",
envs: map[string]string{
"GOOGLE_APPLICATION_CREDENTIALS": gsCreds,
},
path: "blob+gs://bucket",
verify: isStorageServiceSink("storage.googleapis.com"),
},
{
desc: "Azure Cloud File Storage",
envs: map[string]string{
"AZURE_STORAGE_ACCOUNT": "test",
"AZURE_STORAGE_KEY": "test",
"AZURE_STORAGE_SAS_TOKEN": "test",
},
path: "blob+bucket+azblob://bucket",
verify: isStorageServiceSink("https://test.blob.core.windows.net"),
},
{
desc: "Filesystem",
path: "/some/path",
verify: func(t *testing.T, sink Sink) {
require.IsType(t, &FilesystemSink{}, sink)
},
},
{
desc: "undefined",
path: "some:invalid:path\x00",
errMsg: `parse "some:invalid:path\x00": net/url: invalid control character in URL`,
},
} {
t.Run(tc.desc, func(t *testing.T) {
for k, v := range tc.envs {
t.Setenv(k, v)
}
sink, err := ResolveSink(ctx, tc.path)
if tc.errMsg != "" {
require.EqualError(t, err, tc.errMsg)
return
}
defer testhelper.MustClose(t, sink)
tc.verify(t, sink)
})
}
}
func TestStorageServiceSink(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
sss, err := ResolveSink(ctx, "mem://test_bucket")
require.NoError(t, err)
defer func() { require.NoError(t, sss.Close()) }()
t.Run("write and retrieve", func(t *testing.T) {
const relativePath = "path/to/data"
data := []byte("test")
w, err := sss.GetWriter(ctx, relativePath)
require.NoError(t, err)
_, err = io.Copy(w, bytes.NewReader(data))
require.NoError(t, err)
require.NoError(t, w.Close())
reader, err := sss.GetReader(ctx, relativePath)
require.NoError(t, err)
defer func() { require.NoError(t, reader.Close()) }()
retrieved, err := io.ReadAll(reader)
require.NoError(t, err)
require.Equal(t, data, retrieved)
})
t.Run("not existing path", func(t *testing.T) {
reader, err := sss.GetReader(ctx, "not-existing")
require.Equal(t, fmt.Errorf(`storage service sink: new reader for "not-existing": %w`, ErrDoesntExist), err)
require.Nil(t, reader)
})
}
func TestStorageServiceSink_SignedURL_notImplemented(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
tmpDir := testhelper.TempDir(t)
for _, tc := range []struct {
desc string
bucketURL string
}{
{
desc: "memory bucket",
bucketURL: "mem://test_bucket",
},
{
desc: "fs bucket",
bucketURL: tmpDir,
},
} {
tc := tc
t.Run(tc.desc, func(t *testing.T) {
t.Parallel()
sss, err := ResolveSink(ctx, tc.bucketURL)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, sss.Close()) })
const relativePath = "path/to/data"
data := []byte("test")
w, err := sss.GetWriter(ctx, relativePath)
require.NoError(t, err)
_, err = io.Copy(w, bytes.NewReader(data))
require.NoError(t, err)
require.NoError(t, w.Close())
_, err = sss.SignedURL(ctx, relativePath, 10*time.Minute)
require.Error(t, err)
require.Contains(t, err.Error(), "not implemented")
})
}
}
|
