1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
|
package cache
import (
"context"
"io"
"io/ioutil"
"strings"
"sync"
"testing"
"time"
promtest "github.com/prometheus/client_golang/prometheus/testutil"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/internal/metadata/featureflag"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
)
func TestStreamDBNaiveKeyer(t *testing.T) {
cfg := testcfg.Build(t)
testRepo1, _, _ := gittest.CloneRepoAtStorage(t, cfg, cfg.Storages[0], "repository-1")
testRepo2, _, _ := gittest.CloneRepoAtStorage(t, cfg, cfg.Storages[0], "repository-2")
locator := config.NewLocator(cfg)
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()
ctx = testhelper.SetCtxGrpcMethod(ctx, "InfoRefsUploadPack")
cache := New(cfg, locator)
req1 := &gitalypb.InfoRefsRequest{
Repository: testRepo1,
}
req2 := &gitalypb.InfoRefsRequest{
Repository: testRepo2,
}
expectGetMiss := func(req *gitalypb.InfoRefsRequest) {
_, err := cache.GetStream(ctx, req.Repository, req)
require.Equal(t, ErrReqNotFound, err)
}
expectGetHit := func(expectStr string, req *gitalypb.InfoRefsRequest) {
actualStream, err := cache.GetStream(ctx, req.Repository, req)
require.NoError(t, err)
actualBytes, err := ioutil.ReadAll(actualStream)
require.NoError(t, err)
require.Equal(t, expectStr, string(actualBytes))
}
invalidationEvent := func(repo *gitalypb.Repository) {
lease, err := cache.StartLease(repo)
require.NoError(t, err)
// imagine repo being modified here
require.NoError(t, lease.EndLease(ctx))
}
storeAndRetrieve := func(expectStr string, req *gitalypb.InfoRefsRequest) {
require.NoError(t, cache.PutStream(ctx, req.Repository, req, strings.NewReader(expectStr)))
expectGetHit(expectStr, req)
}
// cache is initially empty
expectGetMiss(req1)
expectGetMiss(req2)
// populate cache
repo1contents := "store and retrieve value in repo 1"
storeAndRetrieve(repo1contents, req1)
repo2contents := "store and retrieve value in repo 2"
storeAndRetrieve(repo2contents, req2)
// invalidation makes previous value stale and unreachable
invalidationEvent(req1.Repository)
expectGetMiss(req1)
expectGetHit(repo2contents, req2) // repo1 invalidation doesn't affect repo2
// store new value for same cache value but at new generation
expectStream2 := "not what you were looking for"
require.NoError(t, cache.PutStream(ctx, req1.Repository, req1, strings.NewReader(expectStream2)))
expectGetHit(expectStream2, req1)
// enabled feature flags affect caching
oldCtx := ctx
ctx = featureflag.IncomingCtxWithFeatureFlag(ctx, featureflag.FeatureFlag{"meow", false})
expectGetMiss(req1)
ctx = oldCtx
expectGetHit(expectStream2, req1)
// start critical section without closing
repo1Lease, err := cache.StartLease(req1.Repository)
require.NoError(t, err)
// accessing repo cache with open critical section should fail
_, err = cache.GetStream(ctx, req1.Repository, req1)
require.Equal(t, err, ErrPendingExists)
err = cache.PutStream(ctx, req1.Repository, req1, strings.NewReader(repo1contents))
require.Equal(t, err, ErrPendingExists)
expectGetHit(repo2contents, req2) // other repo caches should be unaffected
// opening and closing a new critical zone doesn't resolve the issue
invalidationEvent(req1.Repository)
_, err = cache.GetStream(ctx, req1.Repository, req1)
require.Equal(t, err, ErrPendingExists)
// only completing/removing the pending generation file will allow access
require.NoError(t, repo1Lease.EndLease(ctx))
expectGetMiss(req1)
// creating a lease on a repo that doesn't exist yet should succeed
req1.Repository.RelativePath += "-does-not-exist"
_, err = cache.StartLease(req1.Repository)
require.NoError(t, err)
}
func TestLoserCount(t *testing.T) {
// the test can be contaminate by other tests using the cache, so a
// dedicated storage location should be used
cfgBuilder := testcfg.NewGitalyCfgBuilder(testcfg.WithStorages("storage-1", "storage-2"))
cfg := cfgBuilder.Build(t)
locator := config.NewLocator(cfg)
cache := New(cfg, locator)
req := &gitalypb.InfoRefsRequest{
Repository: &gitalypb.Repository{
RelativePath: "test",
StorageName: "storage-1",
},
}
ctx := testhelper.SetCtxGrpcMethod(context.Background(), "InfoRefsUploadPack")
leashes := []chan struct{}{make(chan struct{}), make(chan struct{}), make(chan struct{})}
errQ := make(chan error)
wg := &sync.WaitGroup{}
wg.Add(len(leashes))
// Run streams concurrently for the same repo and request
for _, l := range leashes {
go func(l chan struct{}) { errQ <- cache.PutStream(ctx, req.Repository, req, leashedReader{l, wg}) }(l)
l <- struct{}{}
}
wg.Wait()
start := int(promtest.ToFloat64(cache.bytesLoserTotals))
for _, l := range leashes {
close(l)
require.NoError(t, <-errQ)
}
require.Equal(t, start+len(leashes)-1, int(promtest.ToFloat64(cache.bytesLoserTotals)))
}
type leashedReader struct {
q <-chan struct{}
wg *sync.WaitGroup
}
func (lr leashedReader) Read(p []byte) (n int, err error) {
_, ok := <-lr.q
if !ok {
return 0, io.EOF // on channel close
}
lr.wg.Done()
lr.wg.Wait() // wait for all other readers to sync
return 1, nil // on receive, return 1 byte read
}
|
