1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
|
package cgroups
import (
"context"
"fmt"
"hash/crc32"
"os"
"os/exec"
"path/filepath"
"strconv"
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/command"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config/cgroups"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
)
func defaultCgroupsConfig() cgroups.Config {
return cgroups.Config{
Count: 3,
HierarchyRoot: "gitaly",
CPU: cgroups.CPU{
Enabled: true,
Shares: 256,
},
Memory: cgroups.Memory{
Enabled: true,
Limit: 1024000,
},
}
}
func TestSetup(t *testing.T) {
mock := newMock(t)
v1Manager := &CGroupV1Manager{
cfg: defaultCgroupsConfig(),
hierarchy: mock.hierarchy,
}
require.NoError(t, v1Manager.Setup())
for i := 0; i < 3; i++ {
memoryPath := filepath.Join(
mock.root, "memory", "gitaly", fmt.Sprintf("gitaly-%d", os.Getpid()), fmt.Sprintf("shard-%d", i), "memory.limit_in_bytes",
)
memoryContent := readCgroupFile(t, memoryPath)
require.Equal(t, string(memoryContent), "1024000")
cpuPath := filepath.Join(
mock.root, "cpu", "gitaly", fmt.Sprintf("gitaly-%d", os.Getpid()), fmt.Sprintf("shard-%d", i), "cpu.shares",
)
cpuContent := readCgroupFile(t, cpuPath)
require.Equal(t, string(cpuContent), "256")
}
}
func TestAddCommand(t *testing.T) {
mock := newMock(t)
config := defaultCgroupsConfig()
v1Manager1 := &CGroupV1Manager{
cfg: config,
hierarchy: mock.hierarchy,
}
require.NoError(t, v1Manager1.Setup())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
cmd1 := exec.Command("ls", "-hal", ".")
cmd2, err := command.New(ctx, cmd1, nil, nil, nil)
require.NoError(t, err)
require.NoError(t, cmd2.Wait())
v1Manager2 := &CGroupV1Manager{
cfg: config,
hierarchy: mock.hierarchy,
}
require.NoError(t, v1Manager2.AddCommand(cmd2))
checksum := crc32.ChecksumIEEE([]byte(strings.Join(cmd2.Args(), "")))
groupID := uint(checksum) % config.Count
for _, s := range mock.subsystems {
path := filepath.Join(mock.root, string(s.Name()), "gitaly", fmt.Sprintf("gitaly-%d", os.Getpid()), fmt.Sprintf("shard-%d", groupID), "cgroup.procs")
content := readCgroupFile(t, path)
pid, err := strconv.Atoi(string(content))
require.NoError(t, err)
require.Equal(t, cmd2.Pid(), pid)
}
}
func TestCleanup(t *testing.T) {
mock := newMock(t)
v1Manager := &CGroupV1Manager{
cfg: defaultCgroupsConfig(),
hierarchy: mock.hierarchy,
}
require.NoError(t, v1Manager.Setup())
require.NoError(t, v1Manager.Cleanup())
for i := 0; i < 3; i++ {
memoryPath := filepath.Join(mock.root, "memory", "gitaly", fmt.Sprintf("gitaly-%d", os.Getpid()), fmt.Sprintf("shard-%d", i))
cpuPath := filepath.Join(mock.root, "cpu", "gitaly", fmt.Sprintf("gitaly-%d", os.Getpid()), fmt.Sprintf("shard-%d", i))
require.NoDirExists(t, memoryPath)
require.NoDirExists(t, cpuPath)
}
}
func readCgroupFile(t *testing.T, path string) []byte {
t.Helper()
// The cgroups package defaults to permission 0 as it expects the file to be existing (the kernel creates the file)
// and its testing override the permission private variable to something sensible, hence we have to chmod ourselves
// so we can read the file.
require.NoError(t, os.Chmod(path, 0666))
return testhelper.MustReadFile(t, path)
}
|