1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
package catfile
import (
"fmt"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/git"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
"google.golang.org/protobuf/types/known/timestamppb"
)
func TestParser_ParseTag(t *testing.T) {
t.Parallel()
oid := gittest.DefaultObjectHash.EmptyTreeOID.String()
for _, tc := range []struct {
desc string
oid git.ObjectID
contents string
expectedTag *gitalypb.Tag
expectedTagged taggedObject
}{
{
desc: "tag without a message",
contents: fmt.Sprintf("object %s\ntype commit\ntag v2.6.16.28\ntagger Adrian Bunk <bunk@stusta.de> 1156539089 +0200", oid),
oid: "1234",
expectedTag: &gitalypb.Tag{
Id: "1234",
Name: []byte("v2.6.16.28"),
Tagger: &gitalypb.CommitAuthor{
Name: []byte("Adrian Bunk"),
Email: []byte("bunk@stusta.de"),
Date: ×tamppb.Timestamp{
Seconds: 1156539089,
},
Timezone: []byte("+0200"),
},
},
expectedTagged: taggedObject{
objectID: oid,
objectType: "commit",
},
},
{
desc: "tag with message",
contents: fmt.Sprintf("object %s\ntype commit\ntag v2.6.16.28\ntagger Adrian Bunk <bunk@stusta.de> 1156539089 +0200\n\nmessage", oid),
oid: "1234",
expectedTag: &gitalypb.Tag{
Id: "1234",
Name: []byte("v2.6.16.28"),
Message: []byte("message"),
MessageSize: 7,
Tagger: &gitalypb.CommitAuthor{
Name: []byte("Adrian Bunk"),
Email: []byte("bunk@stusta.de"),
Date: ×tamppb.Timestamp{
Seconds: 1156539089,
},
Timezone: []byte("+0200"),
},
},
expectedTagged: taggedObject{
objectID: oid,
objectType: "commit",
},
},
{
desc: "tag with empty message",
oid: "1234",
contents: fmt.Sprintf("object %s\ntype commit\ntag v2.6.16.28\ntagger Adrian Bunk <bunk@stusta.de> 1156539089 +0200\n\n", oid),
expectedTag: &gitalypb.Tag{
Id: "1234",
Name: []byte("v2.6.16.28"),
Message: []byte{},
Tagger: &gitalypb.CommitAuthor{
Name: []byte("Adrian Bunk"),
Email: []byte("bunk@stusta.de"),
Date: ×tamppb.Timestamp{
Seconds: 1156539089,
},
Timezone: []byte("+0200"),
},
},
expectedTagged: taggedObject{
objectID: oid,
objectType: "commit",
},
},
{
desc: "tag with message with empty line",
oid: "1234",
contents: fmt.Sprintf("object %s\ntype commit\ntag v2.6.16.28\ntagger Adrian Bunk <bunk@stusta.de> 1156539089 +0200\n\nHello world\n\nThis is a message", oid),
expectedTag: &gitalypb.Tag{
Id: "1234",
Name: []byte("v2.6.16.28"),
Message: []byte("Hello world\n\nThis is a message"),
MessageSize: 30,
Tagger: &gitalypb.CommitAuthor{
Name: []byte("Adrian Bunk"),
Email: []byte("bunk@stusta.de"),
Date: ×tamppb.Timestamp{
Seconds: 1156539089,
},
Timezone: []byte("+0200"),
},
},
expectedTagged: taggedObject{
objectID: oid,
objectType: "commit",
},
},
{
desc: "tag with message with empty line and right side new line",
contents: fmt.Sprintf("object %s\ntype commit\ntag v2.6.16.28\ntagger Adrian Bunk <bunk@stusta.de> 1156539089 +0200\n\nHello world\n\nThis is a message\n\n", oid),
oid: "1234",
expectedTag: &gitalypb.Tag{
Id: "1234",
Name: []byte("v2.6.16.28"),
Message: []byte("Hello world\n\nThis is a message\n\n"),
MessageSize: 32,
Tagger: &gitalypb.CommitAuthor{
Name: []byte("Adrian Bunk"),
Email: []byte("bunk@stusta.de"),
Date: ×tamppb.Timestamp{
Seconds: 1156539089,
},
Timezone: []byte("+0200"),
},
},
expectedTagged: taggedObject{
objectID: oid,
objectType: "commit",
},
},
{
desc: "tag with missing date and body",
contents: fmt.Sprintf("object %s\ntype commit\ntag syslinux-3.11-pre6\ntagger hpa <hpa>\n", oid),
oid: "1234",
expectedTag: &gitalypb.Tag{
Id: "1234",
Name: []byte("syslinux-3.11-pre6"),
Tagger: &gitalypb.CommitAuthor{
Name: []byte("hpa"),
Email: []byte("hpa"),
},
},
expectedTagged: taggedObject{
objectID: oid,
objectType: "commit",
},
},
{
desc: "tag signed with SSH",
oid: "1234",
contents: fmt.Sprintf(`object %s
type commit
tag v2.6.16.28
tagger Adrian Bunk <bunk@stusta.de> 1156539089 +0200
This tag is signed with SSH
-----BEGIN SSH SIGNATURE-----
U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtc+Qk8jhMwVZk/jFEFCM16LNQb
30q5kK30bbetfjyTMAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5
AAAAQLSyv010gOFwIs9QTtDvlfIEWiAw2iQL/T9usGcxHXn/W5l0cOFCd7O+WaMDg0t0nW
fF3T79iV8paT4/OfX8Ygg=
-----END SSH SIGNATURE-----`, oid),
expectedTag: &gitalypb.Tag{
Id: "1234",
Name: []byte("v2.6.16.28"),
Message: []byte(`This tag is signed with SSH
-----BEGIN SSH SIGNATURE-----
U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtc+Qk8jhMwVZk/jFEFCM16LNQb
30q5kK30bbetfjyTMAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5
AAAAQLSyv010gOFwIs9QTtDvlfIEWiAw2iQL/T9usGcxHXn/W5l0cOFCd7O+WaMDg0t0nW
fF3T79iV8paT4/OfX8Ygg=
-----END SSH SIGNATURE-----`),
MessageSize: 321,
Tagger: &gitalypb.CommitAuthor{
Name: []byte("Adrian Bunk"),
Email: []byte("bunk@stusta.de"),
Date: ×tamppb.Timestamp{
Seconds: 1156539089,
},
Timezone: []byte("+0200"),
},
SignatureType: gitalypb.SignatureType_SSH,
},
expectedTagged: taggedObject{
objectID: oid,
objectType: "commit",
},
},
} {
t.Run(tc.desc, func(t *testing.T) {
tag, tagged, err := newParser().parseTag(newStaticObject(tc.contents, "tag", tc.oid), nil)
require.NoError(t, err)
require.Equal(t, tc.expectedTag, tag)
require.Equal(t, tc.expectedTagged, tagged)
})
}
}
|
